All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Wahren <stefan.wahren@i2se.com>
To: Umang Jain <umang.jain@ideasonboard.com>,
	linux-staging@lists.linux.dev,
	linux-rpi-kernel@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Kees Cook <keescook@chromium.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Adrien Thierry <athierry@redhat.com>,
	Dan Carpenter <error27@gmail.com>,
	Dave Stevenson <dave.stevenson@raspberrypi.com>,
	Kieran Bingham <kieran.bingham@ideasonboard.com>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Subject: Re: [PATCH 3/7] staging: vc04_services: Drop VCHIQ_ERROR usage
Date: Thu, 15 Dec 2022 12:30:29 +0100	[thread overview]
Message-ID: <5c963fd9-97c9-d513-a8ae-5d3f22ef57cc@i2se.com> (raw)
In-Reply-To: <20221215065853.34477-4-umang.jain@ideasonboard.com>

Hi Umang,

thanks for taking care of this.

Am 15.12.22 um 07:58 schrieb Umang Jain:
> Drop the usage of VCHIQ_ERROR vchiq_status enum type. Replace it with
> -EINVAL to report the error.

I would prefer to use adequate error codes like ENOMEM and so on. I 
agree simply replacing all VCHIQ_ERROR with -EINVAL is easier, but 
wasn't the real intention of the TODO item.

The rest of the series looks good to me.

Best regards


WARNING: multiple messages have this Message-ID (diff)
From: Stefan Wahren <stefan.wahren@i2se.com>
To: Umang Jain <umang.jain@ideasonboard.com>,
	linux-staging@lists.linux.dev,
	linux-rpi-kernel@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Kees Cook <keescook@chromium.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Adrien Thierry <athierry@redhat.com>,
	Dan Carpenter <error27@gmail.com>,
	Dave Stevenson <dave.stevenson@raspberrypi.com>,
	Kieran Bingham <kieran.bingham@ideasonboard.com>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Subject: Re: [PATCH 3/7] staging: vc04_services: Drop VCHIQ_ERROR usage
Date: Thu, 15 Dec 2022 12:30:29 +0100	[thread overview]
Message-ID: <5c963fd9-97c9-d513-a8ae-5d3f22ef57cc@i2se.com> (raw)
In-Reply-To: <20221215065853.34477-4-umang.jain@ideasonboard.com>

Hi Umang,

thanks for taking care of this.

Am 15.12.22 um 07:58 schrieb Umang Jain:
> Drop the usage of VCHIQ_ERROR vchiq_status enum type. Replace it with
> -EINVAL to report the error.

I would prefer to use adequate error codes like ENOMEM and so on. I 
agree simply replacing all VCHIQ_ERROR with -EINVAL is easier, but 
wasn't the real intention of the TODO item.

The rest of the series looks good to me.

Best regards


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-12-15 11:30 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-15  6:58 [PATCH 0/7] staging: vc04_services: Remove custom return values Umang Jain
2022-12-15  6:58 ` Umang Jain
2022-12-15  6:58 ` [PATCH 1/7] staging: vc04_services: Replace vchiq_status return type to int Umang Jain
2022-12-15  6:58   ` Umang Jain
2022-12-15  6:58 ` [PATCH 2/7] staging: vc04_services: Drop VCHIQ_SUCCESS usage Umang Jain
2022-12-15  6:58   ` Umang Jain
2022-12-15  6:58 ` [PATCH 3/7] staging: vc04_services: Drop VCHIQ_ERROR usage Umang Jain
2022-12-15  6:58   ` Umang Jain
2022-12-15 11:30   ` Stefan Wahren [this message]
2022-12-15 11:30     ` Stefan Wahren
2022-12-15 13:26     ` Umang Jain
2022-12-15 13:26       ` Umang Jain
2022-12-15  6:58 ` [PATCH 4/7] staging: vc04_services: Drop VCHIQ_RETRY usage Umang Jain
2022-12-15  6:58   ` Umang Jain
2022-12-15  6:58 ` [PATCH 5/7] vc04_services: vchiq_arm: Drop VCHIQ_RETRY usage on disconnect Umang Jain
2022-12-15  6:58   ` Umang Jain
2022-12-15  7:59   ` Dan Carpenter
2022-12-15  7:59     ` Dan Carpenter
2022-12-15  6:58 ` [PATCH 6/7] staging: vc04_services: Drop enum vchiq_status remnants Umang Jain
2022-12-15  6:58   ` Umang Jain
2022-12-15  6:58 ` [PATCH 7/7] staging: vc04_services: vchiq: Drop custom return values from TODO Umang Jain
2022-12-15  6:58   ` Umang Jain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5c963fd9-97c9-d513-a8ae-5d3f22ef57cc@i2se.com \
    --to=stefan.wahren@i2se.com \
    --cc=athierry@redhat.com \
    --cc=dave.stevenson@raspberrypi.com \
    --cc=error27@gmail.com \
    --cc=f.fainelli@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=keescook@chromium.org \
    --cc=kieran.bingham@ideasonboard.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-rpi-kernel@lists.infradead.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=umang.jain@ideasonboard.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.