All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lakshmi Ramasubramanian <nramas@linux.microsoft.com>
To: Paul Moore <paul@paul-moore.com>
Cc: rgb@redhat.com, linux-kernel@vger.kernel.org,
	zohar@linux.ibm.com, linux-audit@redhat.com,
	linux-integrity@vger.kernel.org
Subject: Re: [PATCH 1/2] integrity: Add errno field in audit message
Date: Wed, 10 Jun 2020 18:58:45 -0700	[thread overview]
Message-ID: <5cc042be-a3cf-ae39-c4f5-e474d02c0613@linux.microsoft.com> (raw)
In-Reply-To: <CAHC9VhTZb_evUcdygs6MHP73Bi_r3esxV6+Ko6VDpncfmLYEZw@mail.gmail.com>

On 6/10/20 6:45 PM, Paul Moore wrote:

Hi Paul,

> I'm sorry I didn't get a chance to mention this before you posted this
> patch, but for the past several years we have been sticking with a
> policy of only adding new fields to the end of existing records;
> please adjust this patch accordingly.  Otherwise, this looks fine to
> me.
> 
>>          audit_log_untrustedstring(ab, get_task_comm(name, current));
>>          if (fname) {
>>                  audit_log_format(ab, " name=");
>> --

Steve mentioned that since this new field "errno" is not a searchable 
entry, it can be added anywhere in the audit log message.

But I have no problem moving this to the end of the audit record.

thanks,
  -lakshmi


--
Linux-audit mailing list
Linux-audit@redhat.com
https://www.redhat.com/mailman/listinfo/linux-audit


WARNING: multiple messages have this Message-ID (diff)
From: Lakshmi Ramasubramanian <nramas@linux.microsoft.com>
To: Paul Moore <paul@paul-moore.com>
Cc: zohar@linux.ibm.com, sgrubb@redhat.com, rgb@redhat.com,
	linux-integrity@vger.kernel.org, linux-audit@redhat.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] integrity: Add errno field in audit message
Date: Wed, 10 Jun 2020 18:58:45 -0700	[thread overview]
Message-ID: <5cc042be-a3cf-ae39-c4f5-e474d02c0613@linux.microsoft.com> (raw)
In-Reply-To: <CAHC9VhTZb_evUcdygs6MHP73Bi_r3esxV6+Ko6VDpncfmLYEZw@mail.gmail.com>

On 6/10/20 6:45 PM, Paul Moore wrote:

Hi Paul,

> I'm sorry I didn't get a chance to mention this before you posted this
> patch, but for the past several years we have been sticking with a
> policy of only adding new fields to the end of existing records;
> please adjust this patch accordingly.  Otherwise, this looks fine to
> me.
> 
>>          audit_log_untrustedstring(ab, get_task_comm(name, current));
>>          if (fname) {
>>                  audit_log_format(ab, " name=");
>> --

Steve mentioned that since this new field "errno" is not a searchable 
entry, it can be added anywhere in the audit log message.

But I have no problem moving this to the end of the audit record.

thanks,
  -lakshmi



  reply	other threads:[~2020-06-11 13:47 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-11  0:03 [PATCH 1/2] integrity: Add errno field in audit message Lakshmi Ramasubramanian
2020-06-11  0:03 ` Lakshmi Ramasubramanian
2020-06-11  0:04 ` [PATCH 2/2] IMA: Add audit log for failure conditions Lakshmi Ramasubramanian
2020-06-11  0:04   ` Lakshmi Ramasubramanian
2020-06-12 20:23   ` Mimi Zohar
2020-06-12 20:23     ` Mimi Zohar
2020-06-11  1:45 ` [PATCH 1/2] integrity: Add errno field in audit message Paul Moore
2020-06-11  1:45   ` Paul Moore
2020-06-11  1:58   ` Lakshmi Ramasubramanian [this message]
2020-06-11  1:58     ` Lakshmi Ramasubramanian
2020-06-11  2:19     ` Paul Moore
2020-06-11  2:19       ` Paul Moore
2020-06-12 19:25 ` Mimi Zohar
2020-06-12 19:25   ` Mimi Zohar
2020-06-12 19:50   ` Lakshmi Ramasubramanian
2020-06-12 19:50     ` Lakshmi Ramasubramanian
2020-06-15 22:23     ` Steve Grubb
2020-06-15 22:23       ` Steve Grubb
2020-06-15 22:58       ` Paul Moore
2020-06-15 22:58         ` Paul Moore
2020-06-16 15:29         ` Steve Grubb
2020-06-16 15:29           ` Steve Grubb
2020-06-16 15:43           ` Lakshmi Ramasubramanian
2020-06-16 15:43             ` Lakshmi Ramasubramanian
2020-06-16 15:55             ` Steve Grubb
2020-06-16 15:55               ` Steve Grubb
2020-06-16 19:53               ` Mimi Zohar
2020-06-16 19:53                 ` Mimi Zohar
2020-06-16 20:28                 ` Steve Grubb
2020-06-16 20:28                   ` Steve Grubb

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5cc042be-a3cf-ae39-c4f5-e474d02c0613@linux.microsoft.com \
    --to=nramas@linux.microsoft.com \
    --cc=linux-audit@redhat.com \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paul@paul-moore.com \
    --cc=rgb@redhat.com \
    --cc=zohar@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.