From: Stephen Boyd <swboyd@chromium.org>
To: Andy Gross <agross@kernel.org>, Vinod Koul <vkoul@kernel.org>
Cc: linux-arm-msm@vger.kernel.org,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Vinod Koul <vkoul@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Amit Kucheria <amit.kucheria@verdurent.com>,
Marc Gonzalez <marc.w.gonzalez@free.fr>
Subject: Re: [PATCH v2 4/5] arm64: dts: qcom: sdm845: remove macro from unit name
Date: Wed, 24 Jul 2019 07:11:41 -0700 [thread overview]
Message-ID: <5d38671e.1c69fb81.1f6f4.a5a1@mx.google.com> (raw)
In-Reply-To: <20190724044906.12007-5-vkoul@kernel.org>
Quoting Vinod Koul (2019-07-23 21:49:05)
> Unit name is supposed to be a number, using a macro with hex value is
> not recommended, so add the value in unit name.
>
> arch/arm64/boot/dts/qcom/pm8998.dtsi:81.18-84.6: Warning (unit_address_format): /soc/spmi@c440000/pmic@0/adc@3100/adc-chan@0x06: unit name should not have leading "0x"
> arch/arm64/boot/dts/qcom/pm8998.dtsi:81.18-84.6: Warning (unit_address_format): /soc/spmi@c440000/pmic@0/adc@3100/adc-chan@0x06: unit name should not have leading 0s
>
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
> ---
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Boyd <swboyd@chromium.org>
To: Andy Gross <agross@kernel.org>
Cc: linux-arm-msm@vger.kernel.org,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Vinod Koul <vkoul@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Amit Kucheria <amit.kucheria@verdurent.com>,
Marc Gonzalez <marc.w.gonzalez@free.fr>
Subject: Re: [PATCH v2 4/5] arm64: dts: qcom: sdm845: remove macro from unit name
Date: Wed, 24 Jul 2019 07:11:41 -0700 [thread overview]
Message-ID: <5d38671e.1c69fb81.1f6f4.a5a1@mx.google.com> (raw)
In-Reply-To: <20190724044906.12007-5-vkoul@kernel.org>
Quoting Vinod Koul (2019-07-23 21:49:05)
> Unit name is supposed to be a number, using a macro with hex value is
> not recommended, so add the value in unit name.
>
> arch/arm64/boot/dts/qcom/pm8998.dtsi:81.18-84.6: Warning (unit_address_format): /soc/spmi@c440000/pmic@0/adc@3100/adc-chan@0x06: unit name should not have leading "0x"
> arch/arm64/boot/dts/qcom/pm8998.dtsi:81.18-84.6: Warning (unit_address_format): /soc/spmi@c440000/pmic@0/adc@3100/adc-chan@0x06: unit name should not have leading 0s
>
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
> ---
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
next prev parent reply other threads:[~2019-07-24 14:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-24 4:49 [PATCH v2 0/5] arm64: dts: qcom: sdm845: Fix DTS warnings Vinod Koul
2019-07-24 4:49 ` [PATCH v2 1/5] arm64: dts: qcom: sdm845: Add unit name to soc node Vinod Koul
2019-07-24 5:00 ` Amit Kucheria
2019-10-07 17:44 ` John Stultz
2019-10-07 17:57 ` Rob Herring
2019-07-24 4:49 ` [PATCH v2 2/5] arm64: dts: qcom: sdm845: remove unnecessary properties for dsi nodes Vinod Koul
2019-07-24 5:01 ` Amit Kucheria
2019-07-24 4:49 ` [PATCH v2 3/5] arm64: dts: qcom: sdm845: remove unit name for thermal trip points Vinod Koul
2019-07-24 5:20 ` Amit Kucheria
2019-07-24 4:49 ` [PATCH v2 4/5] arm64: dts: qcom: sdm845: remove macro from unit name Vinod Koul
2019-07-24 5:21 ` Amit Kucheria
2019-07-24 14:11 ` Stephen Boyd [this message]
2019-07-24 14:11 ` Stephen Boyd
2019-07-24 4:49 ` [PATCH v2 5/5] arm64: dts: qcom: sdm845-cheza: " Vinod Koul
2019-07-24 5:21 ` Amit Kucheria
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d38671e.1c69fb81.1f6f4.a5a1@mx.google.com \
--to=swboyd@chromium.org \
--cc=agross@kernel.org \
--cc=amit.kucheria@verdurent.com \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.w.gonzalez@free.fr \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.