All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Boyd <swboyd@chromium.org>
To: Gilles.Muller@lip6.fr, Julia.Lawall@lip6.fr,
	gregkh@linuxfoundation.org, michal.lkml@markovi.net,
	nicolas.palix@imag.fr, yuehaibing@huawei.com
Cc: cocci@systeme.lip6.fr, linux-kernel@vger.kernel.org
Subject: Re: [Cocci] [PATCH -next] coccinelle: platform_get_irq: Fix parse error
Date: Thu, 05 Sep 2019 22:15:26 -0700	[thread overview]
Message-ID: <5d71eb6f.1c69fb81.31bc8.da2d@mx.google.com> (raw)
In-Reply-To: <20190906033006.17616-1-yuehaibing@huawei.com>

Quoting YueHaibing (2019-09-05 20:30:06)
> When do coccicheck, I get this error:
> 
> spatch -D report --no-show-diff --very-quiet --cocci-file
> ./scripts/coccinelle/api/platform_get_irq.cocci --include-headers
> --dir . -I ./arch/x86/include -I ./arch/x86/include/generated -I ./include
>  -I ./arch/x86/include/uapi -I ./arch/x86/include/generated/uapi
>  -I ./include/uapi -I ./include/generated/uapi
>  --include ./include/linux/kconfig.h --jobs 192 --chunksize 1
> minus: parse error:
>   File "./scripts/coccinelle/api/platform_get_irq.cocci", line 24, column 9, charpos = 355
>   around = '\(',
>   whole content = if ( ret \( < \| <= \) 0 )
> 
> In commit e56476897448 ("fpga: Remove dev_err() usage
> after platform_get_irq()") log, I found the semantic patch,
> it fix this issue.
> 
> Fixes: 98051ba2b28b ("coccinelle: Add script to check for platform_get_irq() excessive prints")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---

Hmm I had this earlier but someone asked me to change it.

Reviewed-by: Stephen Boyd <swboyd@chromium.org>

_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci

WARNING: multiple messages have this Message-ID (diff)
From: Stephen Boyd <swboyd@chromium.org>
To: Gilles.Muller@lip6.fr, Julia.Lawall@lip6.fr,
	gregkh@linuxfoundation.org, michal.lkml@markovi.net,
	nicolas.palix@imag.fr, yuehaibing@huawei.com
Cc: cocci@systeme.lip6.fr, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] coccinelle: platform_get_irq: Fix parse error
Date: Thu, 05 Sep 2019 22:15:26 -0700	[thread overview]
Message-ID: <5d71eb6f.1c69fb81.31bc8.da2d@mx.google.com> (raw)
In-Reply-To: <20190906033006.17616-1-yuehaibing@huawei.com>

Quoting YueHaibing (2019-09-05 20:30:06)
> When do coccicheck, I get this error:
> 
> spatch -D report --no-show-diff --very-quiet --cocci-file
> ./scripts/coccinelle/api/platform_get_irq.cocci --include-headers
> --dir . -I ./arch/x86/include -I ./arch/x86/include/generated -I ./include
>  -I ./arch/x86/include/uapi -I ./arch/x86/include/generated/uapi
>  -I ./include/uapi -I ./include/generated/uapi
>  --include ./include/linux/kconfig.h --jobs 192 --chunksize 1
> minus: parse error:
>   File "./scripts/coccinelle/api/platform_get_irq.cocci", line 24, column 9, charpos = 355
>   around = '\(',
>   whole content = if ( ret \( < \| <= \) 0 )
> 
> In commit e56476897448 ("fpga: Remove dev_err() usage
> after platform_get_irq()") log, I found the semantic patch,
> it fix this issue.
> 
> Fixes: 98051ba2b28b ("coccinelle: Add script to check for platform_get_irq() excessive prints")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---

Hmm I had this earlier but someone asked me to change it.

Reviewed-by: Stephen Boyd <swboyd@chromium.org>


  parent reply	other threads:[~2019-09-06  7:00 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-06  3:30 [Cocci] [PATCH -next] coccinelle: platform_get_irq: Fix parse error YueHaibing
2019-09-06  3:30 ` YueHaibing
2019-09-06  5:09 ` [Cocci] " Julia Lawall
2019-09-06  5:09   ` Julia Lawall
2019-09-06  5:15 ` Stephen Boyd [this message]
2019-09-06  5:15   ` Stephen Boyd
2019-09-06  6:52   ` [Cocci] " Markus Elfring
2019-09-06  6:52     ` Markus Elfring
2019-09-06  6:52     ` Markus Elfring
2019-09-06  6:59     ` [Cocci] " Julia Lawall
2019-09-06  6:59       ` Julia Lawall
2019-09-06  6:59       ` Julia Lawall
2019-09-06  7:40       ` Markus Elfring
2019-09-06  7:40         ` Markus Elfring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5d71eb6f.1c69fb81.31bc8.da2d@mx.google.com \
    --to=swboyd@chromium.org \
    --cc=Gilles.Muller@lip6.fr \
    --cc=Julia.Lawall@lip6.fr \
    --cc=cocci@systeme.lip6.fr \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michal.lkml@markovi.net \
    --cc=nicolas.palix@imag.fr \
    --cc=yuehaibing@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.