From: Rob Herring <robh@kernel.org>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>,
Mark Rutland <mark.rutland@arm.com>,
linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: Krzysztof Kozlowski <krzk@kernel.org>
Subject: Re: [PATCH 2/2] dt-bindings: watchdog: Add missing clocks requirement in Samsung SoC watchdog
Date: Fri, 13 Sep 2019 15:36:16 +0100 [thread overview]
Message-ID: <5d7ba961.1c69fb81.d2fcd.6ff4@mx.google.com> (raw)
In-Reply-To: <20190907144541.16949-2-krzk@kernel.org>
On Sat, 7 Sep 2019 16:45:41 +0200, Krzysztof Kozlowski wrote:
> The Samsung SoC watchdog driver always required providing a clock
> (either through platform data or from DT). However when bindings were
> added in commit 9487a9cc7140 ("watchdog: s3c2410: Add support for device
> tree based probe"), they missed the requirement of clock.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> .../devicetree/bindings/watchdog/samsung-wdt.yaml | 7 +++++++
> 1 file changed, 7 insertions(+)
>
Reviewed-by: Rob Herring <robh@kernel.org>
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>,
Mark Rutland <mark.rutland@arm.com>,
linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] dt-bindings: watchdog: Add missing clocks requirement in Samsung SoC watchdog
Date: Fri, 13 Sep 2019 15:36:16 +0100 [thread overview]
Message-ID: <5d7ba961.1c69fb81.d2fcd.6ff4@mx.google.com> (raw)
In-Reply-To: <20190907144541.16949-2-krzk@kernel.org>
On Sat, 7 Sep 2019 16:45:41 +0200, Krzysztof Kozlowski wrote:
> The Samsung SoC watchdog driver always required providing a clock
> (either through platform data or from DT). However when bindings were
> added in commit 9487a9cc7140 ("watchdog: s3c2410: Add support for device
> tree based probe"), they missed the requirement of clock.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> .../devicetree/bindings/watchdog/samsung-wdt.yaml | 7 +++++++
> 1 file changed, 7 insertions(+)
>
Reviewed-by: Rob Herring <robh@kernel.org>
next prev parent reply other threads:[~2019-09-13 14:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-07 14:45 [PATCH 1/2] dt-bindings: watchdog: Convert Samsung SoC watchdog bindings to json-schema Krzysztof Kozlowski
2019-09-07 14:45 ` [PATCH 2/2] dt-bindings: watchdog: Add missing clocks requirement in Samsung SoC watchdog Krzysztof Kozlowski
2019-09-13 14:36 ` Rob Herring [this message]
2019-09-13 14:36 ` Rob Herring
2019-09-13 14:36 ` [PATCH 1/2] dt-bindings: watchdog: Convert Samsung SoC watchdog bindings to json-schema Rob Herring
2019-09-18 11:26 ` Krzysztof Kozlowski
2019-09-20 15:46 ` Rob Herring
2019-09-20 15:52 ` Rob Herring
2019-09-20 16:15 ` Krzysztof Kozlowski
2019-09-20 16:00 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d7ba961.1c69fb81.d2fcd.6ff4@mx.google.com \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mark.rutland@arm.com \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.