From: Jesper Dangaard Brouer <hawk@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>, davem@davemloft.net
Cc: netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com,
aleksander.lobakin@intel.com, ilias.apalodimas@linaro.org,
corbet@lwn.net, linux-doc@vger.kernel.org,
Michael Chan <michael.chan@broadcom.com>,
Lorenzo Bianconi <lorenzo@kernel.org>,
Randy Dunlap <rdunlap@infradead.org>
Subject: Re: [PATCH net-next v2 1/2] docs: net: page_pool: document PP_FLAG_DMA_SYNC_DEV parameters
Date: Thu, 3 Aug 2023 09:04:38 +0200 [thread overview]
Message-ID: <5d7f0fcc-be07-822c-4803-1124e4bfaf16@kernel.org> (raw)
In-Reply-To: <20230802161821.3621985-2-kuba@kernel.org>
On 02/08/2023 18.18, Jakub Kicinski wrote:
> Using PP_FLAG_DMA_SYNC_DEV is a bit confusing. It was perhaps
> more obvious when it was introduced but the page pool use
> has grown beyond XDP and beyond packet-per-page so now
> making the heads and tails out of this feature is not
> trivial.
>
> Obviously making the API more user friendly would be
> a better fix, but until someone steps up to do that
> let's at least document what the parameters are.
>
> Relevant discussion in the first Link.
>
> Link: https://lore.kernel.org/all/20230731114427.0da1f73b@kernel.org/
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
Thanks for updating the documentation much appreciated.
Acked-by: Jesper Dangaard Brouer <hawk@kernel.org>
next prev parent reply other threads:[~2023-08-03 7:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-02 16:18 [PATCH net-next v2 0/2] docs: net: page_pool: sync dev and kdoc Jakub Kicinski
2023-08-02 16:18 ` [PATCH net-next v2 1/2] docs: net: page_pool: document PP_FLAG_DMA_SYNC_DEV parameters Jakub Kicinski
2023-08-03 3:17 ` Randy Dunlap
2023-08-03 6:30 ` Michael Chan
2023-08-03 7:04 ` Jesper Dangaard Brouer [this message]
2023-08-03 9:35 ` Somnath Kotur
2023-08-02 16:18 ` [PATCH net-next v2 2/2] docs: net: page_pool: use kdoc to avoid duplicating the information Jakub Kicinski
2023-08-03 3:17 ` Randy Dunlap
2023-08-03 7:08 ` Jesper Dangaard Brouer
2023-08-03 17:10 ` [PATCH net-next v2 0/2] docs: net: page_pool: sync dev and kdoc patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d7f0fcc-be07-822c-4803-1124e4bfaf16@kernel.org \
--to=hawk@kernel.org \
--cc=aleksander.lobakin@intel.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=ilias.apalodimas@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=lorenzo@kernel.org \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.