Re: [PATCH 2/2] dt-bindings: phy-qcom-qusb2: Add SC7180 QUSB2 phy support

[Stephen Boyd <swboyd@chromium.org>]

Quoting Sandeep Maheswaram (2019-10-30 22:38:07)
> Add QUSB2 phy entries for SC7180 in device tree bindings.
> 
> Signed-off-by: Sandeep Maheswaram <sanm@codeaurora.org>
> ---
>  Documentation/devicetree/bindings/phy/qcom-qusb2-phy.txt | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)

Can you convert this binding to YAML? It may make it easier to
understand what compatibles have certain properties.

> 
> diff --git a/Documentation/devicetree/bindings/phy/qcom-qusb2-phy.txt b/Documentation/devicetree/bindings/phy/qcom-qusb2-phy.txt
> index fe29f9e..d46fca7 100644
> --- a/Documentation/devicetree/bindings/phy/qcom-qusb2-phy.txt
> +++ b/Documentation/devicetree/bindings/phy/qcom-qusb2-phy.txt
> @@ -8,6 +8,7 @@ Required properties:
>                "qcom,msm8996-qusb2-phy" for 14nm PHY on msm8996,
>                "qcom,msm8998-qusb2-phy" for 10nm PHY on msm8998,
>                "qcom,sdm845-qusb2-phy" for 10nm PHY on sdm845.
> +              "qcom,sc7180-qusb2-phy" for 8nm PHY on sc7180.

Please sort compatible string here.

>  
>   - reg: offset and length of the PHY register set.
>   - #phy-cells: must be 0.
> @@ -31,23 +32,23 @@ Optional properties:
>   - qcom,imp-res-offset-value: It is a 6 bit value that specifies offset to be
>                 added to PHY refgen RESCODE via IMP_CTRL1 register. It is a PHY
>                 tuning parameter that may vary for different boards of same SOC.
> -               This property is applicable to only QUSB2 v2 PHY (sdm845).
> +               This property is applicable to only QUSB2 v2 PHY (sdm845,sc7180).

Put a space after that comma please.

>   - qcom,hstx-trim-value: It is a 4 bit value that specifies tuning for HSTX
>                 output current.
>                 Possible range is - 15mA to 24mA (stepsize of 600 uA).
>                 See dt-bindings/phy/phy-qcom-qusb2.h for applicable values.
> -               This property is applicable to only QUSB2 v2 PHY (sdm845).
> +               This property is applicable to only QUSB2 v2 PHY (sdm845,sc7180).
>                 Default value is 22.2mA for sdm845.
>   - qcom,preemphasis-level: It is a 2 bit value that specifies pre-emphasis level.
>                 Possible range is 0 to 15% (stepsize of 5%).
>                 See dt-bindings/phy/phy-qcom-qusb2.h for applicable values.
> -               This property is applicable to only QUSB2 v2 PHY (sdm845).
> +               This property is applicable to only QUSB2 v2 PHY (sdm845,sc7180).
>                 Default value is 10% for sdm845.
>  - qcom,preemphasis-width: It is a 1 bit value that specifies how long the HSTX
>                 pre-emphasis (specified using qcom,preemphasis-level) must be in
>                 effect. Duration could be half-bit of full-bit.
>                 See dt-bindings/phy/phy-qcom-qusb2.h for applicable values.
> -               This property is applicable to only QUSB2 v2 PHY (sdm845).
> +               This property is applicable to only QUSB2 v2 PHY (sdm845,sc7180).
>                 Default value is full-bit width for sdm845.
>  

Same comment.