From: Julien Grall <julien.grall@arm.com>
To: Manish Jaggi <mjaggi@caviumnetworks.com>,
Marc Zyngier <marc.zyngier@arm.com>,
xen-devel@lists.xenproject.org, sstabellini@kernel.org,
andre.przywara@arm.com
Subject: Re: [PATCH v2 02/17] arm64: vgic-v3: Add ICV_BPR1_EL1 handler
Date: Tue, 3 Apr 2018 16:59:00 +0100 [thread overview]
Message-ID: <5dcfab44-e282-0f58-7286-34ab3884c62a@arm.com> (raw)
In-Reply-To: <62aaedce-6ac5-f6b6-dbdf-f3879ba846da@caviumnetworks.com>
Hi,
On 28/03/18 04:51, Manish Jaggi wrote:
> On 03/27/2018 05:08 PM, Marc Zyngier wrote:
>> On 27/03/18 12:27, Manish Jaggi wrote:
>>>
>>> On 03/27/2018 04:55 PM, Marc Zyngier wrote:
>>>> On 27/03/18 12:15, Manish Jaggi wrote:
>>>>> On 03/27/2018 04:41 PM, Marc Zyngier wrote:
>>>>>> On 27/03/18 12:07, Manish Jaggi wrote:
>>>>>>> On 03/27/2018 04:35 PM, Marc Zyngier wrote:
>>>>>>>> On 27/03/18 11:56, Manish Jaggi wrote:
>>>>>>>>> On 03/27/2018 04:15 PM, Marc Zyngier wrote:
>>>>>>>>>> On 27/03/18 11:35, Manish Jaggi wrote:
>>>>>>>>>>> On 03/27/2018 04:00 PM, Marc Zyngier wrote:
>>>>>>>>>>>> On 27/03/18 10:07, Manish Jaggi wrote:
>>>>> Will it be possible to review the remaining part of the code, so
>>>>> that I
>>>>> can address
>>>>> other comments in v3 as well.
>>>> I suggest you wait until some other folks have a chance to properly
>>>> review the series. You only posted the stuff this morning, give them a
>>>> chance. A week between two versions is probably the right timing.
>>> Xen 4.11 window closes this week, so I have only few days.
I agree with Marc on giving a week between each version.
Maintainers/reviewers have other duty and you can't expect them to
review your series promptly. There are no difference with merge window
closing.
Instead you should plan well in advance if you want to get your code in
a specific release.
>>> I am hoping to get your ack before that.
>> My Ack is not the maintainers' (which you'd need anyway), and your
>> series is not the only one I need to review. I don't plan on having
>> another look at it this week anyway.
>>
>> As for the Xen deadline, I'm sure there will be another one.
> Hi Julien,
> Is it prudent to send v3 with the two changes of marc suggested in this
> mail ?
> Since this is a errata workaround, and hopefully it should make it to 4.11.
> I have tried to address the v1 comments in v2, could you please have a
> look at it.
You were probably aware from your management that I was traveling for
the past 2 weeks. So the cut-off for any patches I needed to review for
Xen 4.11 was right before my holidays (the week before easter).
Even if the code freeze was moved to end of this week, I am unlikely
going to have time to fully review the series by then. You can still
resend version while Xen is in code freeze, so this could be merge as
soon as the tree re-open.
Cheers,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-04-03 15:59 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-27 9:07 [PATCH v2 00/17] arm64: Mediate access to GICv3 sysregs at EL2 Manish Jaggi
2018-03-27 9:07 ` [PATCH v2 01/17] arm: Placeholder for handling Group0/1 traps Manish Jaggi
2018-03-27 10:01 ` Marc Zyngier
2018-03-27 10:10 ` Manish Jaggi
2018-03-27 10:22 ` Marc Zyngier
2018-03-27 20:16 ` Stefano Stabellini
2018-03-28 0:48 ` Julien Grall
2018-03-28 3:48 ` Manish Jaggi
2018-04-03 15:33 ` Julien Grall
2018-03-27 9:07 ` [PATCH v2 02/17] arm64: vgic-v3: Add ICV_BPR1_EL1 handler Manish Jaggi
2018-03-27 10:30 ` Marc Zyngier
2018-03-27 10:35 ` Manish Jaggi
2018-03-27 10:45 ` Marc Zyngier
2018-03-27 10:56 ` Manish Jaggi
2018-03-27 11:05 ` Marc Zyngier
2018-03-27 11:07 ` Manish Jaggi
2018-03-27 11:11 ` Marc Zyngier
2018-03-27 11:15 ` Manish Jaggi
2018-03-27 11:25 ` Marc Zyngier
2018-03-27 11:27 ` Manish Jaggi
2018-03-27 11:38 ` Marc Zyngier
2018-03-28 3:51 ` Manish Jaggi
2018-04-03 15:59 ` Julien Grall [this message]
2018-03-27 9:07 ` [PATCH v2 03/17] arm64: vgic-v3: Add ICV_IGRPEN1_EL1 handler Manish Jaggi
2018-03-27 9:07 ` [PATCH v2 04/17] arm64: Add accessors for the ICH_APxRn_EL2 registers Manish Jaggi
2018-03-27 9:07 ` [PATCH v2 05/17] Expose ich_read/write_lr in vgic-v3-sr.c Manish Jaggi
2018-03-27 9:07 ` [PATCH v2 06/17] arm64: Add ICV_IAR1_EL1 handler Manish Jaggi
2018-03-27 9:07 ` [PATCH v2 07/17] arm64: vgic-v3: Add ICV_EOIR1_EL1 handler Manish Jaggi
2018-03-27 10:18 ` Marc Zyngier
2018-04-02 11:03 ` Manish Jaggi
2018-04-02 11:17 ` Manish Jaggi
2018-04-05 9:40 ` Julien Grall
2018-04-05 19:53 ` Stefano Stabellini
2018-04-06 8:37 ` Manish Jaggi
2018-04-11 14:16 ` Julien Grall
2018-03-27 9:07 ` [PATCH v2 08/17] arm64: vgic-v3: Add ICV_AP1Rn_EL1 handler Manish Jaggi
2018-03-27 9:07 ` [PATCH v2 09/17] arm64: vgic-v3: Add ICV_HPPIR1_EL1 handler Manish Jaggi
2018-03-27 10:56 ` Marc Zyngier
2018-03-27 11:02 ` Manish Jaggi
2018-03-27 9:07 ` [PATCH v2 10/17] arm64: vgic-v3: Add ICV_BPR0_EL1 handler Manish Jaggi
2018-03-27 9:07 ` [PATCH v2 11/17] arm64: vgic-v3: Add ICV_IGRPEN0_EL1 handler Manish Jaggi
2018-03-27 9:07 ` [PATCH v2 12/17] arm64: vgic-v3: Add misc Group-0 handlers Manish Jaggi
2018-03-27 10:58 ` Marc Zyngier
2018-03-27 11:01 ` Manish Jaggi
2018-03-27 9:07 ` [PATCH v2 13/17] arm64: cputype: Add MIDR values for Cavium ThunderX1 CPU family Manish Jaggi
2018-03-27 9:07 ` [PATCH v2 14/17] arm64: Add config for Cavium Thunder erratum 30115 Manish Jaggi
2018-03-27 9:07 ` [PATCH v2 15/17] arm: Hook workaround handler from traps.c based on Cavium workaround_30115 Manish Jaggi
2018-03-27 9:07 ` [PATCH v2 16/17] arm64: if trapping a write-to-read-only GICv3 access inject Undef exception in guest Manish Jaggi
2018-03-27 9:07 ` [PATCH v2 17/17] arm64: if trapping a read-from-write-only GICv3 access inject undef " Manish Jaggi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5dcfab44-e282-0f58-7286-34ab3884c62a@arm.com \
--to=julien.grall@arm.com \
--cc=andre.przywara@arm.com \
--cc=marc.zyngier@arm.com \
--cc=mjaggi@caviumnetworks.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.