Re: [bvanassche:ufs-lrbp-as-priv-data 27/28] drivers/ufs/core/ufshcd.c:7594 ufshcd_advanced_rpmb_req_handler() warn: inconsistent returns '&hba->clk_scaling_lock'.

[Bart Van Assche <bvanassche@acm.org>]

On 10/30/25 11:06 PM, Dan Carpenter wrote:
> tree:   https://github.com/bvanassche/linux ufs-lrbp-as-priv-data
> head:   f5ce986a0b77ce2944bf8314554d60eec17968e8
> commit: 226979e4eb8a5844be9fb6047a1d042bf2cd72ab [27/28] ufs: core: Move code out of ufshcd_wait_for_dev_cmd()
> config: x86_64-randconfig-r071-20251031 (https://download.01.org/0day-ci/archive/20251031/202510311328.Is1wMfkq-lkp@intel.com/config)
> compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
> | Closes: https://lore.kernel.org/r/202510311328.Is1wMfkq-lkp@intel.com/
> 
> New smatch warnings:
> drivers/ufs/core/ufshcd.c:7594 ufshcd_advanced_rpmb_req_handler() warn: inconsistent returns '&hba->clk_scaling_lock'.
> drivers/ufs/core/ufshcd.c:7594 ufshcd_advanced_rpmb_req_handler() warn: inconsistent returns '&hba->dev_cmd.lock'.

Hi Dan,

Thanks for the report. This report applies to a patch series from July
10 (more than three months ago). I just pushed out the latest version of
this patch series to my github account. Can you please repeat your
analysis for https://github.com/bvanassche/linux ufs-lrbp-as-priv-data?

Thank you,

Bart.