Re: [bvanassche:ufs-lrbp-as-priv-data 27/28] drivers/ufs/core/ufshcd.c:7594 ufshcd_advanced_rpmb_req_handler() warn: inconsistent returns '&hba->clk_scaling_lock'.

[Bart Van Assche <bvanassche@acm.org>]

On 10/31/25 11:01 AM, Dan Carpenter wrote:
> These are from the zero day bot so how they are generated is mysterious.
> The zero day bot thought the patch was 3 days old.  I think someone did
> a merge or something.
> 
> I re-ran it on that branch and there were three warnings.  The "literal
> zero" is a style issue thing so I haven't published that check.
> 
> drivers/ufs/core/ufshcd.c:2955 __ufshcd_setup_cmd() warn: variable dereferenced before check 'cmd' (see line 2950)
> 
> drivers/ufs/core/ufshcd.c:6849 ufshcd_err_handler() warn: inconsistent returns '&hba->host_sem'.
>    Locked on  : 6696
>    Unlocked on: 6688,6849
> 
> drivers/ufs/core/ufshcd.c:9035 ufshcd_device_init() info: returning a literal zero is cleaner

Hi Dan,

The inconsistent returns issue for hba->host_sem has been fixed on 
Martin Petersen's fixes branch but unfortunately that fix is not yet
present on his for-next branch.

I plan to include a fix for the "variable dereferenced before check
'cmd'" complaint.

Is it expected that I don't see the above reports if I run smatch
myself? This is what I see if I run smatch (commit 2fb2b9093c5d 
("sleep_info: The synchronize_srcu() sleeps")):

$ make drivers/ufs/ C=2 CHECK="smatch -p=__kernel__"
   CHECK   scripts/mod/empty.c
   CALL    scripts/checksyscalls.sh
   CHECK   drivers/ufs/core/ufshcd.c
drivers/ufs/core/ufshcd.c:1536 ufshcd_clk_scaling_suspend_work() warn: 
ignoring unreachable code.
drivers/ufs/core/ufshcd.c:1551 ufshcd_clk_scaling_resume_work() warn: 
ignoring unreachable code.
drivers/ufs/core/ufshcd.c:1616 ufshcd_devfreq_target() warn: ignoring 
unreachable code.
drivers/ufs/core/ufshcd.c:1761 ufshcd_suspend_clkscaling() warn: 
ignoring unreachable code.
drivers/ufs/core/ufshcd.c:1777 ufshcd_resume_clkscaling() warn: ignoring 
unreachable code.
drivers/ufs/core/ufshcd.c:1910 ufshcd_ungate_work() warn: ignoring 
unreachable code.
drivers/ufs/core/ufshcd.c:2095 __ufshcd_release() warn: ignoring 
unreachable code.
drivers/ufs/core/ufshcd.c:9450 ufshcd_setup_clocks() warn: ignoring 
unreachable code.
   CHECK   drivers/ufs/core/ufs-sysfs.c
   CHECK   drivers/ufs/core/ufs-mcq.c
   CHECK   drivers/ufs/core/ufs-debugfs.c
   CHECK   drivers/ufs/core/ufs_bsg.c
   CHECK   drivers/ufs/core/ufshcd-crypto.c
   CHECK   drivers/ufs/core/ufs-fault-injection.c
   CHECK   drivers/ufs/host/tc-dwc-g210-pci.c
   CHECK   drivers/ufs/host/ufshcd-dwc.c
   CHECK   drivers/ufs/host/tc-dwc-g210.c
   CHECK   drivers/ufs/host/ufshcd-pci.c
drivers/ufs/host/ufshcd-pci.c:45 __intel_dsm_supported() warn: always 
true condition '(fn >= 0) => (0-u32max >= 0)'
   CHECK   drivers/ufs/host/ufshcd-pltfrm.c

Thanks!

Bart.