All of lore.kernel.org
 help / color / mirror / Atom feed
From: Surabhi Vishnoi <svishnoi@codeaurora.org>
To: Adrian Chadd <adrian@freebsd.org>
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH] ath10k: Fix the wrong value of enums for wmi tlv stats id
Date: Wed, 10 Apr 2019 17:17:33 +0530	[thread overview]
Message-ID: <5e133105e60e45a48986c54a814b5a60@codeaurora.org> (raw)
In-Reply-To: <CAJ-VmoncvErDWb4a2CNE38ECt2_8-vYr3sZ+AcjiPGCaPGuoCQ@mail.gmail.com>

On 2019-04-09 12:18, Adrian Chadd wrote:
> What about QCA6174 that uses TLV? Does this change its behaviour?
> 
> -a
> 

No, it will not break QCA6174, as earlier also same enum values 
(wmi_stats_id) were used for TLV targets,
enum wmi_stats_id {
         WMI_STAT_PEER = BIT(0),
         WMI_STAT_AP = BIT(1),
         WMI_STAT_PDEV = BIT(2),
         WMI_STAT_VDEV = BIT(3),
         WMI_STAT_BCNFLT = BIT(4),
         WMI_STAT_VDEV_RATE = BIT(5),
};

In the change f40a307eb92c ("ath10k: Fill rx duration for each peer in 
fw_stats for WCN3990), enum values for wmi_tlv_stats_id were wrongly 
added.

Thanks,
Surabhi Vishnoi


> On Mon, 8 Apr 2019 at 23:43, Surabhi Vishnoi <svishnoi@codeaurora.org>
> wrote:
> 
>> The enum value for WMI_TLV_STAT_PDEV, WMI_TLV_STAT_VDEV
>> and WMI_TLV_STAT_PEER is wrong, due to which the vdev stats
>> are not received from firmware in wmi_update_stats event.
>> 
>> Fix the enum values for above stats to receive all stats
>> from firmware in WMI_TLV_UPDATE_STATS_EVENTID.
>> 
>> Tested HW: WCN3990
>> Tested FW: WLAN.HL.3.1-00784-QCAHLSWMTPLZ-1
>> 
>> Fixes: f40a307eb92c ("ath10k: Fill rx duration for each peer in
>> fw_stats for WCN3990)
>> Signed-off-by: Surabhi Vishnoi <svishnoi@codeaurora.org>
>> ---
>> drivers/net/wireless/ath/ath10k/wmi.h | 7 ++++---
>> 1 file changed, 4 insertions(+), 3 deletions(-)
>> 
>> diff --git a/drivers/net/wireless/ath/ath10k/wmi.h
>> b/drivers/net/wireless/ath/ath10k/wmi.h
>> index e1c40bb..12f57f9 100644
>> --- a/drivers/net/wireless/ath/ath10k/wmi.h
>> +++ b/drivers/net/wireless/ath/ath10k/wmi.h
>> @@ -4535,9 +4535,10 @@ enum wmi_10_4_stats_id {
>> };
>> 
>> enum wmi_tlv_stats_id {
>> -       WMI_TLV_STAT_PDEV       = BIT(0),
>> -       WMI_TLV_STAT_VDEV       = BIT(1),
>> -       WMI_TLV_STAT_PEER       = BIT(2),
>> +       WMI_TLV_STAT_PEER       = BIT(0),
>> +       WMI_TLV_STAT_AP         = BIT(1),
>> +       WMI_TLV_STAT_PDEV       = BIT(2),
>> +       WMI_TLV_STAT_VDEV       = BIT(3),
>> WMI_TLV_STAT_PEER_EXTD  = BIT(10),
>> };
>> 
>> --
>> 1.9.1

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

WARNING: multiple messages have this Message-ID (diff)
From: Surabhi Vishnoi <svishnoi@codeaurora.org>
To: Adrian Chadd <adrian@freebsd.org>
Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] ath10k: Fix the wrong value of enums for wmi tlv stats id
Date: Wed, 10 Apr 2019 17:17:33 +0530	[thread overview]
Message-ID: <5e133105e60e45a48986c54a814b5a60@codeaurora.org> (raw)
In-Reply-To: <CAJ-VmoncvErDWb4a2CNE38ECt2_8-vYr3sZ+AcjiPGCaPGuoCQ@mail.gmail.com>

On 2019-04-09 12:18, Adrian Chadd wrote:
> What about QCA6174 that uses TLV? Does this change its behaviour?
> 
> -a
> 

No, it will not break QCA6174, as earlier also same enum values 
(wmi_stats_id) were used for TLV targets,
enum wmi_stats_id {
         WMI_STAT_PEER = BIT(0),
         WMI_STAT_AP = BIT(1),
         WMI_STAT_PDEV = BIT(2),
         WMI_STAT_VDEV = BIT(3),
         WMI_STAT_BCNFLT = BIT(4),
         WMI_STAT_VDEV_RATE = BIT(5),
};

In the change f40a307eb92c ("ath10k: Fill rx duration for each peer in 
fw_stats for WCN3990), enum values for wmi_tlv_stats_id were wrongly 
added.

Thanks,
Surabhi Vishnoi


> On Mon, 8 Apr 2019 at 23:43, Surabhi Vishnoi <svishnoi@codeaurora.org>
> wrote:
> 
>> The enum value for WMI_TLV_STAT_PDEV, WMI_TLV_STAT_VDEV
>> and WMI_TLV_STAT_PEER is wrong, due to which the vdev stats
>> are not received from firmware in wmi_update_stats event.
>> 
>> Fix the enum values for above stats to receive all stats
>> from firmware in WMI_TLV_UPDATE_STATS_EVENTID.
>> 
>> Tested HW: WCN3990
>> Tested FW: WLAN.HL.3.1-00784-QCAHLSWMTPLZ-1
>> 
>> Fixes: f40a307eb92c ("ath10k: Fill rx duration for each peer in
>> fw_stats for WCN3990)
>> Signed-off-by: Surabhi Vishnoi <svishnoi@codeaurora.org>
>> ---
>> drivers/net/wireless/ath/ath10k/wmi.h | 7 ++++---
>> 1 file changed, 4 insertions(+), 3 deletions(-)
>> 
>> diff --git a/drivers/net/wireless/ath/ath10k/wmi.h
>> b/drivers/net/wireless/ath/ath10k/wmi.h
>> index e1c40bb..12f57f9 100644
>> --- a/drivers/net/wireless/ath/ath10k/wmi.h
>> +++ b/drivers/net/wireless/ath/ath10k/wmi.h
>> @@ -4535,9 +4535,10 @@ enum wmi_10_4_stats_id {
>> };
>> 
>> enum wmi_tlv_stats_id {
>> -       WMI_TLV_STAT_PDEV       = BIT(0),
>> -       WMI_TLV_STAT_VDEV       = BIT(1),
>> -       WMI_TLV_STAT_PEER       = BIT(2),
>> +       WMI_TLV_STAT_PEER       = BIT(0),
>> +       WMI_TLV_STAT_AP         = BIT(1),
>> +       WMI_TLV_STAT_PDEV       = BIT(2),
>> +       WMI_TLV_STAT_VDEV       = BIT(3),
>> WMI_TLV_STAT_PEER_EXTD  = BIT(10),
>> };
>> 
>> --
>> 1.9.1

  parent reply	other threads:[~2019-04-10 11:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-09  6:43 [PATCH] ath10k: Fix the wrong value of enums for wmi tlv stats id Surabhi Vishnoi
2019-04-09  6:43 ` Surabhi Vishnoi
     [not found] ` <CAJ-VmoncvErDWb4a2CNE38ECt2_8-vYr3sZ+AcjiPGCaPGuoCQ@mail.gmail.com>
2019-04-10 11:47   ` Surabhi Vishnoi [this message]
2019-04-10 11:47     ` Surabhi Vishnoi
2019-05-07 13:55 ` Kalle Valo
2019-05-07 13:55 ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5e133105e60e45a48986c54a814b5a60@codeaurora.org \
    --to=svishnoi@codeaurora.org \
    --cc=adrian@freebsd.org \
    --cc=ath10k@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.