From: Krzysztof Kozlowski <krzk@kernel.org>
To: JuenKit Yip <hunterteaegg@126.com>, linux-hwmon@vger.kernel.org
Subject: Re: [PATCH 2/2] dt-bindings: trivial-devices: add sensirion,sht3x
Date: Tue, 19 Nov 2024 14:10:16 +0100 [thread overview]
Message-ID: <5e23d70b-8500-4ae9-8f58-e75eea9d2266@kernel.org> (raw)
In-Reply-To: <20241119102016.74418-1-hunterteaegg@126.com>
On 19/11/2024 11:20, JuenKit Yip wrote:
> add sensirion,sht3x as trivial device for devicetree support
Why? Where is the driver?
>
> Signed-off-by: JuenKit Yip <hunterteaegg@126.com>
> ---
> Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
> 1 file changed, 2 insertions(+)
<form letter>
Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC. It might happen, that command when run on an older
kernel, gives you outdated entries. Therefore please be sure you base
your patches on recent Linux kernel.
Tools like b4 or scripts/get_maintainer.pl provide you proper list of
people, so fix your workflow. Tools might also fail if you work on some
ancient tree (don't, instead use mainline) or work on fork of kernel
(don't, instead use mainline). Just use b4 and everything should be
fine, although remember about `b4 prep --auto-to-cc` if you added new
patches to the patchset.
You missed at least devicetree list (maybe more), so this won't be
tested by automated tooling. Performing review on untested code might be
a waste of time.
Please kindly resend and include all necessary To/Cc entries.
</form letter>
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-11-19 13:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-19 10:20 [PATCH 2/2] dt-bindings: trivial-devices: add sensirion,sht3x JuenKit Yip
2024-11-19 13:10 ` Krzysztof Kozlowski [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-11-19 14:07 [PATCH 1/2] hwmon: (sht3x) add devicetree support JuenKit Yip
2024-11-19 14:07 ` [PATCH 2/2] dt-bindings: trivial-devices: add sensirion,sht3x JuenKit Yip
2024-11-19 14:28 ` Krzysztof Kozlowski
[not found] <20241119092208.74360-1-hunterteaegg@126.com>
2024-11-20 17:33 ` Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e23d70b-8500-4ae9-8f58-e75eea9d2266@kernel.org \
--to=krzk@kernel.org \
--cc=hunterteaegg@126.com \
--cc=linux-hwmon@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.