[PATCH 2/2] dt-bindings: trivial-devices: add sensirion,sht3x

[PATCH 2/2] dt-bindings: trivial-devices: add sensirion,sht3x

[JuenKit Yip]

add sensirion,sht3x as trivial device for devicetree support

Signed-off-by: JuenKit Yip <hunterteaegg@126.com>
---
 Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
index 9bf0fb17a05e..be006b21b1ea 100644
--- a/Documentation/devicetree/bindings/trivial-devices.yaml
+++ b/Documentation/devicetree/bindings/trivial-devices.yaml
@@ -333,6 +333,8 @@ properties:
           - sensirion,sgp40
             # Sensirion low power multi-pixel gas sensor with I2C interface
           - sensirion,sgpc3
+            # Sensirion SHT3x-DIS humidity and temperature sensor with I2C interface
+          - sensirion,sht3x
             # Sensirion temperature & humidity sensor with I2C interface
           - sensirion,sht4x
             # Sensortek 3 axis accelerometer
-- 
2.39.5

Re: [PATCH 2/2] dt-bindings: trivial-devices: add sensirion,sht3x

[Krzysztof Kozlowski]

On 19/11/2024 11:20, JuenKit Yip wrote:
> add sensirion,sht3x as trivial device for devicetree support

Why? Where is the driver?

> 
> Signed-off-by: JuenKit Yip <hunterteaegg@126.com>
> ---
>  Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
>  1 file changed, 2 insertions(+)

<form letter>
Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC. It might happen, that command when run on an older
kernel, gives you outdated entries. Therefore please be sure you base
your patches on recent Linux kernel.

Tools like b4 or scripts/get_maintainer.pl provide you proper list of
people, so fix your workflow. Tools might also fail if you work on some
ancient tree (don't, instead use mainline) or work on fork of kernel
(don't, instead use mainline). Just use b4 and everything should be
fine, although remember about `b4 prep --auto-to-cc` if you added new
patches to the patchset.

You missed at least devicetree list (maybe more), so this won't be
tested by automated tooling. Performing review on untested code might be
a waste of time.

Please kindly resend and include all necessary To/Cc entries.
</form letter>


Best regards,
Krzysztof

[PATCH 1/2] hwmon: (sht3x) add devicetree support

[JuenKit Yip]

add "compatible" property for supporting devicetree

Signed-off-by: JuenKit Yip <hunterteaegg@126.com>
---
 drivers/hwmon/sht3x.c | 18 +++++++++++++++++-
 1 file changed, 17 insertions(+), 1 deletion(-)

diff --git a/drivers/hwmon/sht3x.c b/drivers/hwmon/sht3x.c
index 650b0bcc2359..2ac1537b3e3e 100644
--- a/drivers/hwmon/sht3x.c
+++ b/drivers/hwmon/sht3x.c
@@ -954,6 +954,19 @@ static int sht3x_probe(struct i2c_client *client)
 	return PTR_ERR_OR_ZERO(hwmon_dev);
 }
 
+/* devicetree ID table */
+static const struct of_device_id sht3x_of_match[] = {
+	{ .compatible = "sensirion,sht30", .data = (void *)sht3x },
+	{ .compatible = "sensirion,sht31", .data = (void *)sht3x },
+	{ .compatible = "sensirion,sht35", .data = (void *)sht3x },
+	{ .compatible = "sensirion,sts30", .data = (void *)sts3x },
+	{ .compatible = "sensirion,sts31", .data = (void *)sts3x },
+	{ .compatible = "sensirion,sts35", .data = (void *)sts3x },
+	{},
+};
+
+MODULE_DEVICE_TABLE(of, sht3x_of_match);
+
 /* device ID table */
 static const struct i2c_device_id sht3x_ids[] = {
 	{"sht3x", sht3x},
@@ -964,7 +977,10 @@ static const struct i2c_device_id sht3x_ids[] = {
 MODULE_DEVICE_TABLE(i2c, sht3x_ids);
 
 static struct i2c_driver sht3x_i2c_driver = {
-	.driver.name = "sht3x",
+	.driver = {
+		.name = "sht3x",
+		.of_match_table = sht3x_of_match,
+	},
 	.probe       = sht3x_probe,
 	.id_table    = sht3x_ids,
 };
-- 
2.39.5

[PATCH 2/2] dt-bindings: trivial-devices: add sensirion,sht3x

[JuenKit Yip]

add sensirion,sht3x as trivial device for devicetree support

Signed-off-by: JuenKit Yip <hunterteaegg@126.com>
---
 Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
index 9bf0fb17a05e..be006b21b1ea 100644
--- a/Documentation/devicetree/bindings/trivial-devices.yaml
+++ b/Documentation/devicetree/bindings/trivial-devices.yaml
@@ -333,6 +333,8 @@ properties:
           - sensirion,sgp40
             # Sensirion low power multi-pixel gas sensor with I2C interface
           - sensirion,sgpc3
+            # Sensirion SHT3x-DIS humidity and temperature sensor with I2C interface
+          - sensirion,sht3x
             # Sensirion temperature & humidity sensor with I2C interface
           - sensirion,sht4x
             # Sensortek 3 axis accelerometer
-- 
2.39.5

Re: [PATCH 2/2] dt-bindings: trivial-devices: add sensirion,sht3x

[Krzysztof Kozlowski]

On 19/11/2024 15:07, JuenKit Yip wrote:
> add sensirion,sht3x as trivial device for devicetree support
> 
> Signed-off-by: JuenKit Yip <hunterteaegg@126.com>
> ---
>  Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
I see now you sent the same binding to proper addresses. This is
therefore a RESEND and please mark it appropriately in the future. git
format-patch -2 --subject-prefix="PATCH RESEND"

or similar command for b4.

Best regards,
Krzysztof

Re: [PATCH 2/2] dt-bindings: trivial-devices: add sensirion,sht3x

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 1165 bytes --]

On Tue, Nov 19, 2024 at 04:22:08AM -0500, JuenKit Yip wrote:
> add sensirion,sht3x as trivial device for devicetree support

This has 2 supplies, an alert pin and a reset. I don't think it is a
trivial device.

> 
> Signed-off-by: JuenKit Yip <hunterteaegg@126.com>
> ---
>  Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
> index 9bf0fb17a05e..be006b21b1ea 100644
> --- a/Documentation/devicetree/bindings/trivial-devices.yaml
> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
> @@ -333,6 +333,8 @@ properties:
>            - sensirion,sgp40
>              # Sensirion low power multi-pixel gas sensor with I2C interface
>            - sensirion,sgpc3
> +            # Sensirion SHT3x-DIS humidity and temperature sensor with I2C interface
> +          - sensirion,sht3x
>              # Sensirion temperature & humidity sensor with I2C interface
>            - sensirion,sht4x
>              # Sensortek 3 axis accelerometer
> -- 
> 2.39.5
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]