From: Grygorii Strashko <grygorii.strashko@ti.com>
To: Anders Roxell <anders.roxell@linaro.org>
Cc: devicetree@vger.kernel.org, Lokesh Vutla <lokeshvutla@ti.com>,
Networking <netdev@vger.kernel.org>,
Richard Cochran <richardcochran@gmail.com>,
Sekhar Nori <nsekhar@ti.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>, Clay McClure <clay@daemons.net>,
Tero Kristo <t-kristo@ti.com>,
Murali Karicheri <m-karicheri2@ti.com>,
"David S. Miller" <davem@davemloft.net>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH net-next 3/7] net: ethernet: ti: am65-cpsw-nuss: enable packet timestamping support
Date: Tue, 5 May 2020 15:20:06 +0300 [thread overview]
Message-ID: <5f338763-b35b-e2b4-7f15-df3a5bcbb799@ti.com> (raw)
In-Reply-To: <CADYN=9LDCE2sQca12D4ow3BkaxXi1_bnc4Apu7pP4vnA=5AOKA@mail.gmail.com>
Hi Anders,
On 05/05/2020 14:59, Anders Roxell wrote:
> On Tue, 5 May 2020 at 13:16, Anders Roxell <anders.roxell@linaro.org> wrote:
>> On Tue, 5 May 2020 at 13:05, Grygorii Strashko <grygorii.strashko@ti.com> wrote:
>>> On 05/05/2020 13:17, Anders Roxell wrote:
>>>> On Fri, 1 May 2020 at 22:50, Grygorii Strashko <grygorii.strashko@ti.com> wrote:
>>>>>
>>>>> The MCU CPSW Common Platform Time Sync (CPTS) provides possibility to
>>>>> timestamp TX PTP packets and all RX packets.
>>>>>
>>>>> This enables corresponding support in TI AM65x/J721E MCU CPSW driver.
>>>>>
>>>>> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
>>>>> ---
>>>>> drivers/net/ethernet/ti/Kconfig | 1 +
>>>>> drivers/net/ethernet/ti/am65-cpsw-ethtool.c | 24 ++-
>>>>> drivers/net/ethernet/ti/am65-cpsw-nuss.c | 172 ++++++++++++++++++++
>>>>> drivers/net/ethernet/ti/am65-cpsw-nuss.h | 6 +-
>>>>> 4 files changed, 201 insertions(+), 2 deletions(-)
>>>>>
>>>>> diff --git a/drivers/net/ethernet/ti/Kconfig b/drivers/net/ethernet/ti/Kconfig
>>>>> index 1f4e5b6dc686..2c7bd1ccaaec 100644
>>>>> --- a/drivers/net/ethernet/ti/Kconfig
>>>>> +++ b/drivers/net/ethernet/ti/Kconfig
>>>>> @@ -100,6 +100,7 @@ config TI_K3_AM65_CPSW_NUSS
>>>>> depends on ARCH_K3 && OF && TI_K3_UDMA_GLUE_LAYER
>>>>> select TI_DAVINCI_MDIO
>>>>> imply PHY_TI_GMII_SEL
>>>>> + imply TI_AM65_CPTS
>>>>
>>>> Should this be TI_K3_AM65_CPTS ?
>
> instead of 'imply TI_K3_AM65_CPTS' don't you want to do this:
> 'depends on TI_K3_AM65_CPTS || !TI_K3_AM65_CPTS'
>
>
Right, I'll try. It seems your defconfig is produced by randconfig as
I can't get broken cfg TI_AM65_CPTS=m and TI_K3_AM65_CPSW_NUSS=y
with neither one below:
make ARCH=arm64 O=k3-arm64 defconfig
make ARCH=arm64 O=k3-arm64 allnoconfig
make ARCH=arm64 O=k3-arm64 allyesconfig
make ARCH=arm64 O=k3-arm64 allmodconfig
make ARCH=arm64 O=k3-arm64 alldefconfig
make ARCH=arm64 O=k3-arm64 yes2modconfig
make ARCH=arm64 O=k3-arm64 mod2yesconfig
Related legacy TI CPTS threads:
https://lkml.org/lkml/2020/5/2/344
https://lkml.org/lkml/2020/5/1/1348
I'd try summarize goal
TI_K3_AM65_CPSW_NUSS TI_AM65_CPTS
Y Y/N
M Y/M/N
N Y/M/N
--
Best regards,
grygorii
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Grygorii Strashko <grygorii.strashko@ti.com>
To: Anders Roxell <anders.roxell@linaro.org>
Cc: Richard Cochran <richardcochran@gmail.com>,
Murali Karicheri <m-karicheri2@ti.com>,
"David S. Miller" <davem@davemloft.net>,
Rob Herring <robh+dt@kernel.org>, Tero Kristo <t-kristo@ti.com>,
Lokesh Vutla <lokeshvutla@ti.com>,
Networking <netdev@vger.kernel.org>, Sekhar Nori <nsekhar@ti.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
<devicetree@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Clay McClure <clay@daemons.net>
Subject: Re: [PATCH net-next 3/7] net: ethernet: ti: am65-cpsw-nuss: enable packet timestamping support
Date: Tue, 5 May 2020 15:20:06 +0300 [thread overview]
Message-ID: <5f338763-b35b-e2b4-7f15-df3a5bcbb799@ti.com> (raw)
In-Reply-To: <CADYN=9LDCE2sQca12D4ow3BkaxXi1_bnc4Apu7pP4vnA=5AOKA@mail.gmail.com>
Hi Anders,
On 05/05/2020 14:59, Anders Roxell wrote:
> On Tue, 5 May 2020 at 13:16, Anders Roxell <anders.roxell@linaro.org> wrote:
>> On Tue, 5 May 2020 at 13:05, Grygorii Strashko <grygorii.strashko@ti.com> wrote:
>>> On 05/05/2020 13:17, Anders Roxell wrote:
>>>> On Fri, 1 May 2020 at 22:50, Grygorii Strashko <grygorii.strashko@ti.com> wrote:
>>>>>
>>>>> The MCU CPSW Common Platform Time Sync (CPTS) provides possibility to
>>>>> timestamp TX PTP packets and all RX packets.
>>>>>
>>>>> This enables corresponding support in TI AM65x/J721E MCU CPSW driver.
>>>>>
>>>>> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
>>>>> ---
>>>>> drivers/net/ethernet/ti/Kconfig | 1 +
>>>>> drivers/net/ethernet/ti/am65-cpsw-ethtool.c | 24 ++-
>>>>> drivers/net/ethernet/ti/am65-cpsw-nuss.c | 172 ++++++++++++++++++++
>>>>> drivers/net/ethernet/ti/am65-cpsw-nuss.h | 6 +-
>>>>> 4 files changed, 201 insertions(+), 2 deletions(-)
>>>>>
>>>>> diff --git a/drivers/net/ethernet/ti/Kconfig b/drivers/net/ethernet/ti/Kconfig
>>>>> index 1f4e5b6dc686..2c7bd1ccaaec 100644
>>>>> --- a/drivers/net/ethernet/ti/Kconfig
>>>>> +++ b/drivers/net/ethernet/ti/Kconfig
>>>>> @@ -100,6 +100,7 @@ config TI_K3_AM65_CPSW_NUSS
>>>>> depends on ARCH_K3 && OF && TI_K3_UDMA_GLUE_LAYER
>>>>> select TI_DAVINCI_MDIO
>>>>> imply PHY_TI_GMII_SEL
>>>>> + imply TI_AM65_CPTS
>>>>
>>>> Should this be TI_K3_AM65_CPTS ?
>
> instead of 'imply TI_K3_AM65_CPTS' don't you want to do this:
> 'depends on TI_K3_AM65_CPTS || !TI_K3_AM65_CPTS'
>
>
Right, I'll try. It seems your defconfig is produced by randconfig as
I can't get broken cfg TI_AM65_CPTS=m and TI_K3_AM65_CPSW_NUSS=y
with neither one below:
make ARCH=arm64 O=k3-arm64 defconfig
make ARCH=arm64 O=k3-arm64 allnoconfig
make ARCH=arm64 O=k3-arm64 allyesconfig
make ARCH=arm64 O=k3-arm64 allmodconfig
make ARCH=arm64 O=k3-arm64 alldefconfig
make ARCH=arm64 O=k3-arm64 yes2modconfig
make ARCH=arm64 O=k3-arm64 mod2yesconfig
Related legacy TI CPTS threads:
https://lkml.org/lkml/2020/5/2/344
https://lkml.org/lkml/2020/5/1/1348
I'd try summarize goal
TI_K3_AM65_CPSW_NUSS TI_AM65_CPTS
Y Y/N
M Y/M/N
N Y/M/N
--
Best regards,
grygorii
next prev parent reply other threads:[~2020-05-05 12:20 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-01 20:50 [PATCH net-next 0/7] net: ethernet: ti: k3: introduce common platform time sync driver - cpts Grygorii Strashko
2020-05-01 20:50 ` Grygorii Strashko
2020-05-01 20:50 ` [PATCH net-next 1/7] dt-binding: ti: am65x: document common platform time sync cpts module Grygorii Strashko
2020-05-01 20:50 ` Grygorii Strashko
2020-05-05 4:04 ` Rob Herring
2020-05-05 4:04 ` Rob Herring
2020-05-05 15:01 ` Grygorii Strashko
2020-05-05 15:01 ` Grygorii Strashko
2020-05-06 19:07 ` Rob Herring
2020-05-06 19:07 ` Rob Herring
2020-05-06 19:10 ` Grygorii Strashko
2020-05-06 19:10 ` Grygorii Strashko
2020-05-05 4:05 ` Rob Herring
2020-05-05 4:05 ` Rob Herring
2020-05-05 10:26 ` Grygorii Strashko
2020-05-05 10:26 ` Grygorii Strashko
2020-05-01 20:50 ` [PATCH net-next 2/7] net: ethernet: ti: introduce am654 common platform time sync driver Grygorii Strashko
2020-05-01 20:50 ` Grygorii Strashko
2020-05-01 20:50 ` [PATCH net-next 3/7] net: ethernet: ti: am65-cpsw-nuss: enable packet timestamping support Grygorii Strashko
2020-05-01 20:50 ` Grygorii Strashko
2020-05-05 10:17 ` Anders Roxell
2020-05-05 10:17 ` Anders Roxell
2020-05-05 11:05 ` Grygorii Strashko
2020-05-05 11:05 ` Grygorii Strashko
2020-05-05 11:16 ` Anders Roxell
2020-05-05 11:16 ` Anders Roxell
2020-05-05 11:59 ` Anders Roxell
2020-05-05 11:59 ` Anders Roxell
2020-05-05 12:20 ` Grygorii Strashko [this message]
2020-05-05 12:20 ` Grygorii Strashko
2020-05-05 13:31 ` Anders Roxell
2020-05-05 13:31 ` Anders Roxell
2020-05-05 12:55 ` Grygorii Strashko
2020-05-05 12:55 ` Grygorii Strashko
2020-05-01 20:50 ` [PATCH net-next 4/7] arm64: dts: ti: k3-am65-mcu: add cpsw cpts node Grygorii Strashko
2020-05-01 20:50 ` Grygorii Strashko
2020-05-01 20:50 ` [PATCH net-next 5/7] arm64: dts: ti: k3-am65-main: add main navss " Grygorii Strashko
2020-05-01 20:50 ` Grygorii Strashko
2020-05-01 20:50 ` [PATCH net-next 6/7] arm64: dts: ti: k3-j721e-mcu: add mcu cpsw " Grygorii Strashko
2020-05-01 20:50 ` Grygorii Strashko
2020-05-01 20:50 ` [PATCH net-next 7/7] arm64: dts: ti: j721e-main: add main navss " Grygorii Strashko
2020-05-01 20:50 ` Grygorii Strashko
2020-05-04 19:02 ` [PATCH net-next 0/7] net: ethernet: ti: k3: introduce common platform time sync driver - cpts David Miller
2020-05-04 19:02 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5f338763-b35b-e2b4-7f15-df3a5bcbb799@ti.com \
--to=grygorii.strashko@ti.com \
--cc=anders.roxell@linaro.org \
--cc=clay@daemons.net \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lokeshvutla@ti.com \
--cc=m-karicheri2@ti.com \
--cc=netdev@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=richardcochran@gmail.com \
--cc=robh+dt@kernel.org \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.