From: Jan Beulich <jbeulich@suse.com>
To: Luca Fancellu <Luca.Fancellu@arm.com>,
Michal Orzel <michal.orzel@amd.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>,
"Stefano Stabellini" <sstabellini@kernel.org>,
"Julien Grall" <julien@xen.org>,
"Bertrand Marquis" <Bertrand.Marquis@arm.com>,
"Volodymyr Babchuk" <Volodymyr_Babchuk@epam.com>,
"Andrew Cooper" <andrew.cooper3@citrix.com>,
"Roger Pau Monné" <roger.pau@citrix.com>, "Wei Liu" <wl@xen.org>
Subject: Re: [PATCH] xen: Append a newline character to panic() where missing
Date: Wed, 14 Jun 2023 10:00:41 +0200 [thread overview]
Message-ID: <5f53088d-5561-0750-e0a8-ca8fbd0a00f8@suse.com> (raw)
In-Reply-To: <6D17A0C9-1B69-42F8-88E9-E2E026C57CA3@arm.com>
On 14.06.2023 09:45, Luca Fancellu wrote:
>> On 14 Jun 2023, at 08:30, Michal Orzel <michal.orzel@amd.com> wrote:
>>
>> Missing newline is inconsistent with the rest of the callers, since
>> panic() expects it.
>>
>> Signed-off-by: Michal Orzel <michal.orzel@amd.com>
>
> Reviewed-by: Luca Fancellu <luca.fancellu@arm.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
next prev parent reply other threads:[~2023-06-14 8:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-14 7:30 [PATCH] xen: Append a newline character to panic() where missing Michal Orzel
2023-06-14 7:45 ` Luca Fancellu
2023-06-14 8:00 ` Jan Beulich [this message]
2023-06-14 8:04 ` Andrew Cooper
2023-06-14 8:09 ` Michal Orzel
2023-06-14 9:02 ` Julien Grall
2023-06-14 9:06 ` Michal Orzel
2023-06-14 9:09 ` Julien Grall
2023-06-15 20:53 ` Julien Grall
2023-06-14 9:51 ` Bertrand Marquis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5f53088d-5561-0750-e0a8-ca8fbd0a00f8@suse.com \
--to=jbeulich@suse.com \
--cc=Bertrand.Marquis@arm.com \
--cc=Luca.Fancellu@arm.com \
--cc=Volodymyr_Babchuk@epam.com \
--cc=andrew.cooper3@citrix.com \
--cc=julien@xen.org \
--cc=michal.orzel@amd.com \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.