Re: [PATCH] xen: Append a newline character to panic() where missing

[Michal Orzel <michal.orzel@amd.com>]

On 14/06/2023 10:04, Andrew Cooper wrote:
> 
> 
> On 14/06/2023 8:30 am, Michal Orzel wrote:
>> Missing newline is inconsistent with the rest of the callers, since
>> panic() expects it.
>>
>> Signed-off-by: Michal Orzel <michal.orzel@amd.com>
> 
> Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
> 
> although...
> 
>> ---
>>  xen/arch/arm/bootfdt.c            | 2 +-
>>  xen/arch/arm/domain_build.c       | 6 +++---
>>  xen/arch/x86/cpu/microcode/core.c | 2 +-
>>  3 files changed, 5 insertions(+), 5 deletions(-)
>>
>> diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c
>> index b6f92a174f5f..2673ad17a1e1 100644
>> --- a/xen/arch/arm/bootfdt.c
>> +++ b/xen/arch/arm/bootfdt.c
>> @@ -225,7 +225,7 @@ static int __init process_reserved_memory_node(const void *fdt, int node,
>>                                   size_cells, data);
>>
>>      if ( rc == -ENOSPC )
>> -        panic("Max number of supported reserved-memory regions reached.");
>> +        panic("Max number of supported reserved-memory regions reached.\n");
> 
> Trailing punctuation like . or ! is useless.  Most messages don't have
> them, and it just takes up space in .rodata, the console ring, and time
> on the UART.
> 
> I'd recommend dropping the ones you modify, and/or cleaning it up more
> widely.
I will keep in mind to do that in global scope in the next patch.
We also have quite a lot of printk() with trailing punctuation.

~Michal