From: Sagi Grimberg <sagi@grimberg.me>
To: David Miller <davem@davemloft.net>, amhetre@nvidia.com
Cc: axboe@kernel.dk, ulf.hansson@linaro.org,
herbert@gondor.apana.org.au, mmaddireddy@nvidia.com,
Snikam@nvidia.com, adrian.hunter@intel.com,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
vdumpa@nvidia.com, linux-crypto@vger.kernel.org,
linux-tegra@vger.kernel.org
Subject: Re: [PATCH] scatterlist: Update size type to support greater then 4GB size.
Date: Tue, 11 Dec 2018 22:49:16 -0800 [thread overview]
Message-ID: <5f70fc16-e3cd-37c1-e7ed-e131ad79d387@grimberg.me> (raw)
In-Reply-To: <20181211.222950.1995970751331458343.davem@davemloft.net>
>> struct nvme_sgl_desc {
>> __le64 addr;
>> - __le32 length;
>> + __le64 length;
>> __u8 rsvd[3];
>> __u8 type;
>> };
>
> Isn't this a device or protocol defined datastructure? You can't just
> change it like this.
You're correct, we can't...
[Replied before seeing this issue was already highlighted]
The positive side is that it can safely be removed without affecting the
rest of the patch...
WARNING: multiple messages have this Message-ID (diff)
From: sagi@grimberg.me (Sagi Grimberg)
Subject: [PATCH] scatterlist: Update size type to support greater then 4GB size.
Date: Tue, 11 Dec 2018 22:49:16 -0800 [thread overview]
Message-ID: <5f70fc16-e3cd-37c1-e7ed-e131ad79d387@grimberg.me> (raw)
In-Reply-To: <20181211.222950.1995970751331458343.davem@davemloft.net>
>> struct nvme_sgl_desc {
>> __le64 addr;
>> - __le32 length;
>> + __le64 length;
>> __u8 rsvd[3];
>> __u8 type;
>> };
>
> Isn't this a device or protocol defined datastructure? You can't just
> change it like this.
You're correct, we can't...
[Replied before seeing this issue was already highlighted]
The positive side is that it can safely be removed without affecting the
rest of the patch...
next prev parent reply other threads:[~2018-12-12 6:49 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-12 6:24 [PATCH] scatterlist: Update size type to support greater then 4GB size Ashish Mhetre
2018-12-12 6:24 ` Ashish Mhetre
2018-12-12 6:24 ` Ashish Mhetre
2018-12-12 6:29 ` David Miller
2018-12-12 6:29 ` David Miller
2018-12-12 6:49 ` Sagi Grimberg [this message]
2018-12-12 6:49 ` Sagi Grimberg
2018-12-12 7:45 ` Ashish Mhetre
2018-12-12 7:45 ` Ashish Mhetre
2018-12-12 7:45 ` Ashish Mhetre
2018-12-12 6:46 ` Sagi Grimberg
2018-12-12 6:46 ` Sagi Grimberg
2018-12-12 7:51 ` Ard Biesheuvel
2018-12-12 7:51 ` Ard Biesheuvel
2018-12-12 8:06 ` Christoph Hellwig
2018-12-12 8:06 ` Christoph Hellwig
2018-12-24 8:07 ` Ashish Mhetre
2018-12-24 8:07 ` Ashish Mhetre
2018-12-24 8:07 ` Ashish Mhetre
2018-12-14 14:13 ` kbuild test robot
2018-12-14 14:13 ` kbuild test robot
2018-12-14 14:13 ` kbuild test robot
2018-12-14 14:13 ` kbuild test robot
2018-12-14 14:13 ` kbuild test robot
2018-12-14 14:13 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5f70fc16-e3cd-37c1-e7ed-e131ad79d387@grimberg.me \
--to=sagi@grimberg.me \
--cc=Snikam@nvidia.com \
--cc=adrian.hunter@intel.com \
--cc=amhetre@nvidia.com \
--cc=axboe@kernel.dk \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mmaddireddy@nvidia.com \
--cc=ulf.hansson@linaro.org \
--cc=vdumpa@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.