From: "Edgecombe, Rick P" <rick.p.edgecombe@intel.com>
To: "seanjc@google.com" <seanjc@google.com>
Cc: "Zhao, Yan Y" <yan.y.zhao@intel.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"pbonzini@redhat.com" <pbonzini@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"sashiko-bot@kernel.org" <sashiko-bot@kernel.org>,
"Huang, Kai" <kai.huang@intel.com>
Subject: Re: [PATCH 2/4] KVM: x86/mmu: Harden "map private PFN" against unexpected root invalidation
Date: Mon, 10 Aug 2026 20:01:59 +0000 [thread overview]
Message-ID: <5f7cc285ea55bec73dd4b51391c4657432953c17.camel@intel.com> (raw)
In-Reply-To: <anZZsiNZAxcg3FPH@google.com>
On Fri, 2026-08-07 at 15:18 -0700, Sean Christopherson wrote:
> Yeah, I don't love the comment either. The subtlety that it doesn't capture is
> that KVM_REQ_MMU_FREE_OBSOLETE_ROOTS doesn't actually mean the current root is
> invalid, just that it might be invalid and the vCPU needs to check.
>
> How about this?
>
> /*
> * Because slots_lock is held, it should be impossible for *any*
> * roots to be invalidated after the initial MMU reload. WARN,
> * but continue on; the above MMU reload will do the right thing
> * if the current root is actually invalid.
> */
Looks good! thanks
next prev parent reply other threads:[~2026-08-10 20:02 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-06 21:40 [PATCH 0/4] KVM: x86/mmu: Fix pre-fault and map private loops Sean Christopherson
2026-08-06 21:40 ` [PATCH 1/4] KVM: x86/mmu: Reload MMU on *every* page pre-fault attempt/iteration Sean Christopherson
2026-08-07 8:58 ` Huang, Kai
2026-08-07 19:04 ` Edgecombe, Rick P
2026-08-07 19:11 ` Sean Christopherson
2026-08-06 21:40 ` [PATCH 2/4] KVM: x86/mmu: Harden "map private PFN" against unexpected root invalidation Sean Christopherson
2026-08-06 22:14 ` sashiko-bot
2026-08-06 22:21 ` Sean Christopherson
2026-08-07 20:26 ` Edgecombe, Rick P
2026-08-07 22:18 ` Sean Christopherson
2026-08-10 20:01 ` Edgecombe, Rick P [this message]
2026-08-11 7:01 ` Yan Zhao
2026-08-11 17:07 ` Sean Christopherson
2026-08-06 21:40 ` [PATCH 3/4] KVM: x86/mmu: Top-up memory caches when retrying "map private PFN" Sean Christopherson
2026-08-06 21:56 ` sashiko-bot
2026-08-06 22:07 ` Sean Christopherson
2026-08-07 20:38 ` Edgecombe, Rick P
2026-08-07 22:13 ` Sean Christopherson
2026-08-10 20:37 ` Edgecombe, Rick P
2026-08-10 20:43 ` Sean Christopherson
2026-08-06 21:40 ` [PATCH 4/4] KVM: x86/mmu: Add sanity check to detect stale page faults in " Sean Christopherson
2026-08-06 21:54 ` sashiko-bot
2026-08-06 22:12 ` Sean Christopherson
2026-08-11 0:25 ` Yan Zhao
2026-08-11 6:40 ` Yan Zhao
2026-08-11 17:12 ` Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5f7cc285ea55bec73dd4b51391c4657432953c17.camel@intel.com \
--to=rick.p.edgecombe@intel.com \
--cc=kai.huang@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=sashiko-bot@kernel.org \
--cc=seanjc@google.com \
--cc=yan.y.zhao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.