[PATCH] Bluetooth: btmtksdio: Add the missed release_firmware() in mtk_setup

All of lore.kernel.org
 help / color / mirror / Atom feed

* [PATCH] Bluetooth: btmtksdio: Add the missed release_firmware() in mtk_setup_firmware()
@ 2020-11-17  2:43 ` Jing Xiangfeng
  0 siblings, 0 replies; 7+ messages in thread
From: Jing Xiangfeng @ 2020-11-17  2:43 UTC (permalink / raw)
  To: marcel, johan.hedberg, matthias.bgg, Mark-YW.Chen, sean.wang
  Cc: linux-bluetooth, linux-arm-kernel, linux-mediatek, linux-kernel,
	jingxiangfeng

mtk_setup_firmware() misses to call release_firmware() in an error
path. Jump to free_fw to fix it.

Fixes: 737cd06072a7 ("Bluetooth: btmtksdio: fix up firmware download sequence")
Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
---
 drivers/bluetooth/btmtksdio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/bluetooth/btmtksdio.c b/drivers/bluetooth/btmtksdio.c
index c7ab7a23bd67..c2677ffbd3c0 100644
--- a/drivers/bluetooth/btmtksdio.c
+++ b/drivers/bluetooth/btmtksdio.c
@@ -704,7 +704,7 @@ static int mtk_setup_firmware(struct hci_dev *hdev, const char *fwname)
 	err = mtk_hci_wmt_sync(hdev, &wmt_params);
 	if (err < 0) {
 		bt_dev_err(hdev, "Failed to power on data RAM (%d)", err);
-		return err;
+		goto free_fw;
 	}
 
 	fw_ptr = fw->data;
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [PATCH] Bluetooth: btmtksdio: Add the missed release_firmware() in mtk_setup_firmware()
@ 2020-11-17  2:43 ` Jing Xiangfeng
  0 siblings, 0 replies; 7+ messages in thread
From: Jing Xiangfeng @ 2020-11-17  2:43 UTC (permalink / raw)
  To: marcel, johan.hedberg, matthias.bgg, Mark-YW.Chen, sean.wang
  Cc: linux-bluetooth, linux-mediatek, linux-kernel, linux-arm-kernel,
	jingxiangfeng

mtk_setup_firmware() misses to call release_firmware() in an error
path. Jump to free_fw to fix it.

Fixes: 737cd06072a7 ("Bluetooth: btmtksdio: fix up firmware download sequence")
Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
---
 drivers/bluetooth/btmtksdio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/bluetooth/btmtksdio.c b/drivers/bluetooth/btmtksdio.c
index c7ab7a23bd67..c2677ffbd3c0 100644
--- a/drivers/bluetooth/btmtksdio.c
+++ b/drivers/bluetooth/btmtksdio.c
@@ -704,7 +704,7 @@ static int mtk_setup_firmware(struct hci_dev *hdev, const char *fwname)
 	err = mtk_hci_wmt_sync(hdev, &wmt_params);
 	if (err < 0) {
 		bt_dev_err(hdev, "Failed to power on data RAM (%d)", err);
-		return err;
+		goto free_fw;
 	}
 
 	fw_ptr = fw->data;
-- 
2.17.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [PATCH] Bluetooth: btmtksdio: Add the missed release_firmware() in mtk_setup_firmware()
@ 2020-11-17  2:43 ` Jing Xiangfeng
  0 siblings, 0 replies; 7+ messages in thread
From: Jing Xiangfeng @ 2020-11-17  2:43 UTC (permalink / raw)
  To: marcel, johan.hedberg, matthias.bgg, Mark-YW.Chen, sean.wang
  Cc: linux-bluetooth, linux-mediatek, linux-kernel, linux-arm-kernel,
	jingxiangfeng

mtk_setup_firmware() misses to call release_firmware() in an error
path. Jump to free_fw to fix it.

Fixes: 737cd06072a7 ("Bluetooth: btmtksdio: fix up firmware download sequence")
Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
---
 drivers/bluetooth/btmtksdio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/bluetooth/btmtksdio.c b/drivers/bluetooth/btmtksdio.c
index c7ab7a23bd67..c2677ffbd3c0 100644
--- a/drivers/bluetooth/btmtksdio.c
+++ b/drivers/bluetooth/btmtksdio.c
@@ -704,7 +704,7 @@ static int mtk_setup_firmware(struct hci_dev *hdev, const char *fwname)
 	err = mtk_hci_wmt_sync(hdev, &wmt_params);
 	if (err < 0) {
 		bt_dev_err(hdev, "Failed to power on data RAM (%d)", err);
-		return err;
+		goto free_fw;
 	}
 
 	fw_ptr = fw->data;
-- 
2.17.1


_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* RE: Bluetooth: btmtksdio: Add the missed release_firmware() in mtk_setup_firmware()
  2020-11-17  2:43 ` Jing Xiangfeng
  (?)
  (?)
@ 2020-11-17  3:17 ` bluez.test.bot
  -1 siblings, 0 replies; 7+ messages in thread
From: bluez.test.bot @ 2020-11-17  3:17 UTC (permalink / raw)
  To: linux-bluetooth, jingxiangfeng

[-- Attachment #1: Type: text/plain, Size: 1258 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=385607

---Test result---

##############################
Test: CheckPatch - FAIL
Output:
workflow: Add workflow files for ci
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#20: 
new file mode 100644

total: 0 errors, 1 warnings, 49 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

"[PATCH] workflow: Add workflow files for ci" has style problems, please review.

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.

##############################
Test: CheckGitLint - FAIL
Output:
Bluetooth: btmtksdio: Add the missed release_firmware() in mtk_setup_firmware()
1: T1 Title exceeds max length (79>72): "Bluetooth: btmtksdio: Add the missed release_firmware() in mtk_setup_firmware()"

##############################
Test: CheckBuildK - PASS

---
Regards,
Linux Bluetooth

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] Bluetooth: btmtksdio: Add the missed release_firmware() in mtk_setup_firmware()
  2020-11-17  2:43 ` Jing Xiangfeng
  (?)
@ 2020-11-23 11:51   ` Marcel Holtmann
  -1 siblings, 0 replies; 7+ messages in thread
From: Marcel Holtmann @ 2020-11-23 11:51 UTC (permalink / raw)
  To: Jing Xiangfeng
  Cc: Johan Hedberg, matthias.bgg, Mark-YW.Chen, sean.wang,
	linux-bluetooth, linux-arm-kernel, linux-mediatek, linux-kernel

Hi Jing,

> mtk_setup_firmware() misses to call release_firmware() in an error
> path. Jump to free_fw to fix it.
> 
> Fixes: 737cd06072a7 ("Bluetooth: btmtksdio: fix up firmware download sequence")
> Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
> ---
> drivers/bluetooth/btmtksdio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

patch has been applied to bluetooth-next tree.

Regards

Marcel


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] Bluetooth: btmtksdio: Add the missed release_firmware() in mtk_setup_firmware()
@ 2020-11-23 11:51   ` Marcel Holtmann
  0 siblings, 0 replies; 7+ messages in thread
From: Marcel Holtmann @ 2020-11-23 11:51 UTC (permalink / raw)
  To: Jing Xiangfeng
  Cc: Johan Hedberg, Mark-YW.Chen, sean.wang, linux-kernel,
	linux-bluetooth, linux-mediatek, matthias.bgg, linux-arm-kernel

Hi Jing,

> mtk_setup_firmware() misses to call release_firmware() in an error
> path. Jump to free_fw to fix it.
> 
> Fixes: 737cd06072a7 ("Bluetooth: btmtksdio: fix up firmware download sequence")
> Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
> ---
> drivers/bluetooth/btmtksdio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

patch has been applied to bluetooth-next tree.

Regards

Marcel


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] Bluetooth: btmtksdio: Add the missed release_firmware() in mtk_setup_firmware()
@ 2020-11-23 11:51   ` Marcel Holtmann
  0 siblings, 0 replies; 7+ messages in thread
From: Marcel Holtmann @ 2020-11-23 11:51 UTC (permalink / raw)
  To: Jing Xiangfeng
  Cc: Johan Hedberg, Mark-YW.Chen, sean.wang, linux-kernel,
	linux-bluetooth, linux-mediatek, matthias.bgg, linux-arm-kernel

Hi Jing,

> mtk_setup_firmware() misses to call release_firmware() in an error
> path. Jump to free_fw to fix it.
> 
> Fixes: 737cd06072a7 ("Bluetooth: btmtksdio: fix up firmware download sequence")
> Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
> ---
> drivers/bluetooth/btmtksdio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

patch has been applied to bluetooth-next tree.

Regards

Marcel


_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2020-11-23 11:52 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-11-17  2:43 [PATCH] Bluetooth: btmtksdio: Add the missed release_firmware() in mtk_setup_firmware() Jing Xiangfeng
2020-11-17  2:43 ` Jing Xiangfeng
2020-11-17  2:43 ` Jing Xiangfeng
2020-11-17  3:17 ` bluez.test.bot
2020-11-23 11:51 ` [PATCH] " Marcel Holtmann
2020-11-23 11:51   ` Marcel Holtmann
2020-11-23 11:51   ` Marcel Holtmann

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.