Re: [PATCH v2 1/1] riscv: dts: spacemit: add Ethernet and PDMA to OrangePi RV2

From: Michael Opdenacker <michael.opdenacker@rootcommit.com>
To: Conor Dooley <conor@kernel.org>, Vivian Wang <wangruikang@iscas.ac.cn>
Cc: michael.opdenacker@rootcommit.com, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>, Yixun Lan <dlan@gentoo.org>,
	Paul Walmsley <pjw@kernel.org>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Alexandre Ghiti <alex@ghiti.fr>,
	Emil Renner Berthing <emil.renner.berthing@gmail.com>,
	devicetree@vger.kernel.org, linux-riscv@lists.infradead.org,
	spacemit@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/1] riscv: dts: spacemit: add Ethernet and PDMA to OrangePi RV2
Date: Fri, 24 Oct 2025 05:36:47 +0000 (UTC)	[thread overview]
Message-ID: <5fbb09f4-22e6-4073-a4e5-95165d3dabbb@rootcommit.com> (raw)
In-Reply-To: <20251023-lizard-sharpie-70f2a000327f@spud>

Hi Conor

Thanks for the review!

On 10/23/25 20:30, Conor Dooley wrote:
> On Thu, Oct 23, 2025 at 01:58:22PM +0800, Vivian Wang wrote:
>> Thank you so much for the patch and testing results. Only some nitpicks
>> follow.
>>
>> On 10/23/25 04:18, michael.opdenacker@rootcommit.com wrote:
>>> From: Michael Opdenacker <michael.opdenacker@rootcommit.com>
>>>
>>> The OrangePi RV2 board ships two RGMII ethernet ports.
>>> Each has an external Motorcomm YT8531C PHY attached, the PHY uses GPIO
>>> for reset pin control.
>>>
>>> Enable PDMA for the SpacemiT K1-based SoC in the OrangePi RV2 board.
>>>
>>> Signed-off-by: Michael Opdenacker <michael.opdenacker@rootcommit.com>
>>> CC: Emil Renner Berthing <emil.renner.berthing@gmail.com>
>>> CC: Yixun Lan <dlan@gentoo.org>
>>> CC: Vivian Wang <wangruikang@iscas.ac.cn>
>> Firstly, it is usually spelt "Cc:", with one upper-case C and one
>> lower-case c.
> I don't think this matters at all, the git tooling at least doesn't
> care.
>
>> Secondly, "Cc:" should not be necessary in the patch/commit message.
>>  From Documentation/process/submitting-patches.rst:
>>
>>      If a person has had the opportunity to comment on a patch, but has not
>>      provided such comments, you may optionally add a ``Cc:`` tag to the patch.
>>      This tag documents that potentially interested parties have been included in
>>      the discussion.
>>
>> If you look through the git logs of Linux, Cc tags are really not a
>> regular occurrence except those marking patches as suitable for
>> backporting to stable.
> If people want to handle CC lists by putting it in the patches (it's
> what I do when I have no cover letter) just put them after the --- line
> and git send-email will still pick the CCs up but they won't end up in
> the history.

Oh yes, that was my mistake. The CCs were never intended to make it to 
the final commits.
Thanks!
Michael.

-- 
Michael Opdenacker
Root Commit
Yocto Project and OpenEmbedded Training course - Learn by doing:
https://rootcommit.com/training/yocto/

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv