Re: [PATCH] RISC-V: fixup in-flight collision with ARCH_WANT_OPTIMIZE_VMEMMAP rename

From: "Konstantin Ryabitsev" <konstantin.ryabitsev@linux.dev>
To: "Palmer Dabbelt" <palmer@dabbelt.com>, "Conor Dooley" <conor@kernel.org>
Cc: "Conor Dooley" <conor.dooley@microchip.com>,
	"Linus Torvalds" <torvalds@linux-foundation.org>,
	akpm@linux-foundation.org, aneesh.kumar@linux.ibm.com,
	linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
	lukas.bulwahn@gmail.com
Subject: Re: [PATCH] RISC-V: fixup in-flight collision with ARCH_WANT_OPTIMIZE_VMEMMAP rename
Date: Sat, 29 Apr 2023 21:48:18 +0000	[thread overview]
Message-ID: <5fe1484b4f2b4ae960a9b599c4ab3ace@linux.dev> (raw)
In-Reply-To: <mhng-b5a20207-95a2-4607-9e6c-52396d569d91@palmer-ri-x1c9a>

April 29, 2023 4:17 PM, "Palmer Dabbelt" <palmer@dabbelt.com> wrote:
>>> I guess you picking this up for your second PR makes the most sense
>>> Palmer?
> 
> Yep, except it crashes b4
> 
> $ b4 shazam -lts https://lore.kernel.org/all/20230429-trilogy-jolly-12bf5c53d62d@spud
> Grabbing thread from lore.kernel.org/all/20230429-trilogy-jolly-12bf5c53d62d%40spud/t.mbox.gz
> Analyzing 2 messages in the thread
> Checking attestation on all messages, may take a moment...
> Traceback (most recent call last):
> File "/home/palmer/.local/src/b4/b4/command.py", line 383, in <module>
> cmd()
> File "/home/palmer/.local/src/b4/b4/command.py", line 366, in cmd
> cmdargs.func(cmdargs)
> File "/home/palmer/.local/src/b4/b4/command.py", line 100, in cmd_shazam
> b4.mbox.main(cmdargs)
> File "/home/palmer/.local/src/b4/b4/mbox.py", line 713, in main
> make_am(msgs, cmdargs, msgid)
> File "/home/palmer/.local/src/b4/b4/mbox.py", line 101, in make_am
> am_msgs = lser.get_am_ready(noaddtrailers=cmdargs.noaddtrailers,
> File "/home/palmer/.local/src/b4/b4/__init__.py", line 552, in get_am_ready
> checkmark, trailers, attcrit = lmsg.get_attestation_trailers(attpolicy, maxdays)
> File "/home/palmer/.local/src/b4/b4/__init__.py", line 1319, in get_attestation_trailers
> for attestor in self.attestors:
> File "/home/palmer/.local/src/b4/b4/__init__.py", line 1158, in attestors
> self._load_patatt_attestors()
> File "/home/palmer/.local/src/b4/b4/__init__.py", line 1261, in _load_patatt_attestors
> patatt_config = patatt.get_config_from_git(r'patatt\..*', multivals=['keyringsrc'])
> AttributeError: module 'patatt' has no attribute 'get_config_from_git'
> 
> So I probably need to just go update my setup, I've got a bunch of wacky stuff.
> I'll try and remember to do so, but I'm going to scrub through other bits
> first...

Indeed, you have a newer version of b4 without also updating the patatt dependency. If you're using b4 from git, you need to "git submodule update".

Regards,
-K

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv