All of lore.kernel.org
 help / color / mirror / Atom feed
From: Icenowy Zheng <icenowy@aosc.xyz>
To: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: "rui.zhang@intel.com" <rui.zhang@intel.com>,
	"edubezval@gmail.com" <edubezval@gmail.com>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"wens@csie.org" <wens@csie.org>,
	"emilio@elopez.com.ar" <emilio@elopez.com.ar>,
	"mark.rutland@arm.com" <mark.rutland@arm.com>,
	"linux@armlinux.org.uk" <linux@armlinux.org.uk>,
	"mturquette@baylibre.com" <mturquette@baylibre.com>,
	"sboyd@codeaurora.org" <sboyd@codeaurora.org>,
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>
Subject: Re: [RFC PATCH 3/5] thermal: Add support for the thermal sensor on A23/33
Date: Tue, 28 Jun 2016 21:56:22 +0800	[thread overview]
Message-ID: <60021467122182@web19j.yandex.ru> (raw)
In-Reply-To: <20160628114640.GE5550@lukather>



28.06.2016, 19:46, "Maxime Ripard" <maxime.ripard@free-electrons.com>:
> Hi,
>
> Thanks for working on this.
>
> On Tue, Jun 28, 2016 at 06:13:23PM +0800, Icenowy Zheng wrote:
>>  This patch adds support for the sun8iw3 thermal sensor on
>>  Allwinner A23/33 SoCs.
>>
>>  Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz>
>
> The IP is awfully similar to the A31's, which already has a driver
> (drivers/input/touchscreen/sun4i-ts.c).
>
> There's no reason to add a new one here.
>
> Thanks,
> Maxime
>
> --
> Maxime Ripard, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com

The reason for a dedicate driver is:
1. This IP have only thermal function, so it's not suitable to use a driver at drivers/input/touchscreen/.
2. Control Register are quite different.
3. This IP uses AUDIO PLL (PLL2) as its clock!

WARNING: multiple messages have this Message-ID (diff)
From: Icenowy Zheng <icenowy@aosc.xyz>
To: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: "mark.rutland@arm.com" <mark.rutland@arm.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
	"emilio@elopez.com.ar" <emilio@elopez.com.ar>,
	"mturquette@baylibre.com" <mturquette@baylibre.com>,
	"sboyd@codeaurora.org" <sboyd@codeaurora.org>,
	"linux@armlinux.org.uk" <linux@armlinux.org.uk>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"edubezval@gmail.com" <edubezval@gmail.com>,
	"wens@csie.org" <wens@csie.org>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"rui.zhang@intel.com" <rui.zhang@intel.com>,
	"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [RFC PATCH 3/5] thermal: Add support for the thermal sensor on A23/33
Date: Tue, 28 Jun 2016 21:56:22 +0800	[thread overview]
Message-ID: <60021467122182@web19j.yandex.ru> (raw)
In-Reply-To: <20160628114640.GE5550@lukather>



28.06.2016, 19:46, "Maxime Ripard" <maxime.ripard@free-electrons.com>:
> Hi,
>
> Thanks for working on this.
>
> On Tue, Jun 28, 2016 at 06:13:23PM +0800, Icenowy Zheng wrote:
>>  This patch adds support for the sun8iw3 thermal sensor on
>>  Allwinner A23/33 SoCs.
>>
>>  Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz>
>
> The IP is awfully similar to the A31's, which already has a driver
> (drivers/input/touchscreen/sun4i-ts.c).
>
> There's no reason to add a new one here.
>
> Thanks,
> Maxime
>
> --
> Maxime Ripard, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com

The reason for a dedicate driver is:
1. This IP have only thermal function, so it's not suitable to use a driver at drivers/input/touchscreen/.
2. Control Register are quite different.
3. This IP uses AUDIO PLL (PLL2) as its clock!

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: icenowy@aosc.xyz (Icenowy Zheng)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH 3/5] thermal: Add support for the thermal sensor on A23/33
Date: Tue, 28 Jun 2016 21:56:22 +0800	[thread overview]
Message-ID: <60021467122182@web19j.yandex.ru> (raw)
In-Reply-To: <20160628114640.GE5550@lukather>



28.06.2016, 19:46, "Maxime Ripard" <maxime.ripard@free-electrons.com>:
> Hi,
>
> Thanks for working on this.
>
> On Tue, Jun 28, 2016 at 06:13:23PM +0800, Icenowy Zheng wrote:
>> ?This patch adds support for the sun8iw3 thermal sensor on
>> ?Allwinner A23/33 SoCs.
>>
>> ?Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz>
>
> The IP is awfully similar to the A31's, which already has a driver
> (drivers/input/touchscreen/sun4i-ts.c).
>
> There's no reason to add a new one here.
>
> Thanks,
> Maxime
>
> --
> Maxime Ripard, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com

The reason for a dedicate driver is:
1. This IP have only thermal function, so it's not suitable to use a driver at drivers/input/touchscreen/.
2. Control Register are quite different.
3. This IP uses AUDIO PLL (PLL2) as its clock!

  reply	other threads:[~2016-06-28 13:56 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-28 10:13 [RFC PATCH 1/5] clk: sunxi: Add a driver for the PLL2 on A31/23/33 Icenowy Zheng
2016-06-28 10:13 ` Icenowy Zheng
2016-06-28 10:13 ` Icenowy Zheng
2016-06-28 10:13 ` [RFC PATCH 2/5] dt: bindings: add bindings for allwinner a23/33 ths Icenowy Zheng
2016-06-28 10:13   ` Icenowy Zheng
2016-06-28 10:13   ` Icenowy Zheng
2016-06-28 10:13 ` [RFC PATCH 3/5] thermal: Add support for the thermal sensor on A23/33 Icenowy Zheng
2016-06-28 10:13   ` Icenowy Zheng
2016-06-28 10:13   ` Icenowy Zheng
2016-06-28 11:46   ` Maxime Ripard
2016-06-28 11:46     ` Maxime Ripard
2016-06-28 11:46     ` Maxime Ripard
2016-06-28 13:56     ` Icenowy Zheng [this message]
2016-06-28 13:56       ` Icenowy Zheng
2016-06-28 13:56       ` Icenowy Zheng
2016-06-29 12:10       ` Maxime Ripard
2016-06-29 12:10         ` Maxime Ripard
2016-06-29 12:10         ` Maxime Ripard
2016-06-29 13:31         ` Icenowy Zheng
2016-06-29 13:31           ` Icenowy Zheng
2016-06-29 13:31           ` Icenowy Zheng
2016-06-29 13:42           ` Maxime Ripard
2016-06-29 13:42             ` Maxime Ripard
2016-06-29 13:42             ` Maxime Ripard
2016-06-29 13:52             ` Icenowy Zheng
2016-06-29 13:52               ` Icenowy Zheng
2016-06-29 13:52               ` Icenowy Zheng
2016-06-29 13:33         ` Icenowy Zheng
2016-06-29 13:33           ` Icenowy Zheng
2016-06-29 13:33           ` Icenowy Zheng
2016-06-29 13:42         ` Icenowy Zheng
2016-06-29 13:42           ` Icenowy Zheng
2016-06-29 13:42           ` Icenowy Zheng
2016-06-28 14:03     ` Icenowy Zheng
2016-06-28 14:03       ` Icenowy Zheng
2016-06-28 14:03       ` Icenowy Zheng
2016-06-28 10:13 ` [RFC PATCH 4/5] ARM: sun8i: enable PLL2 on a23/33 Icenowy Zheng
2016-06-28 10:13   ` Icenowy Zheng
2016-06-28 10:13   ` Icenowy Zheng
2016-06-28 10:13 ` [RFC PATCH 5/5] ARM: sun8i: enable ths node for A23/33 Icenowy Zheng
2016-06-28 10:13   ` Icenowy Zheng
2016-06-28 10:13   ` Icenowy Zheng
2016-07-05  6:12 ` [RFC PATCH 1/5] clk: sunxi: Add a driver for the PLL2 on A31/23/33 Maxime Ripard
2016-07-05  6:12   ` Maxime Ripard
2016-07-05  6:12   ` Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=60021467122182@web19j.yandex.ru \
    --to=icenowy@aosc.xyz \
    --cc=devicetree@vger.kernel.org \
    --cc=edubezval@gmail.com \
    --cc=emilio@elopez.com.ar \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=mark.rutland@arm.com \
    --cc=maxime.ripard@free-electrons.com \
    --cc=mturquette@baylibre.com \
    --cc=robh+dt@kernel.org \
    --cc=rui.zhang@intel.com \
    --cc=sboyd@codeaurora.org \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.