All of lore.kernel.org
 help / color / mirror / Atom feed
* [LTP] [PATCH] fanotify13.c/setxattr01.c: Remove requirement of needs_tmpdir
@ 2021-02-27  3:32 Zhao Gongyi
  2021-03-01  1:48 ` Yang Xu
  0 siblings, 1 reply; 3+ messages in thread
From: Zhao Gongyi @ 2021-02-27  3:32 UTC (permalink / raw)
  To: ltp

The testcases aim to run on all_filesystems, so we need remove the
requirement of needs_tmpdir.

Signed-off-by: Zhao Gongyi <zhaogongyi@huawei.com>
---
 testcases/kernel/syscalls/fanotify/fanotify13.c | 1 -
 testcases/kernel/syscalls/setxattr/setxattr01.c | 1 -
 2 files changed, 2 deletions(-)

diff --git a/testcases/kernel/syscalls/fanotify/fanotify13.c b/testcases/kernel/syscalls/fanotify/fanotify13.c
index 6d812cdd1..1fb12ae68 100644
--- a/testcases/kernel/syscalls/fanotify/fanotify13.c
+++ b/testcases/kernel/syscalls/fanotify/fanotify13.c
@@ -289,7 +289,6 @@ static struct tst_test test = {
 	.setup = do_setup,
 	.cleanup = do_cleanup,
 	.needs_root = 1,
-	.needs_tmpdir = 1,
 	.mount_device = 1,
 	.mntpoint = MOUNT_PATH,
 	.all_filesystems = 1,
diff --git a/testcases/kernel/syscalls/setxattr/setxattr01.c b/testcases/kernel/syscalls/setxattr/setxattr01.c
index 8b84dfe0d..8cd2821d0 100644
--- a/testcases/kernel/syscalls/setxattr/setxattr01.c
+++ b/testcases/kernel/syscalls/setxattr/setxattr01.c
@@ -210,7 +210,6 @@ static struct tst_test test = {
 	.mntpoint = MNTPOINT,
 	.mount_device = 1,
 	.all_filesystems = 1,
-	.needs_tmpdir = 1,
 	.needs_root = 1,
 };

--
2.17.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread
* [LTP] [PATCH] fanotify13.c/setxattr01.c: Remove requirement of needs_tmpdir
@ 2021-03-01  2:30 zhaogongyi
  0 siblings, 0 replies; 3+ messages in thread
From: zhaogongyi @ 2021-03-01  2:30 UTC (permalink / raw)
  To: ltp

Hi Xu,

> 
> Hi gongyi
> > The testcases aim to run on all_filesystems, so we need remove the
> > requirement of needs_tmpdir.
> >
> This commit message is confusing. See commit dae8427740f(" Remove
> duplicated ".needs_tmpdir=1" when using equivalent flags").
> 
> The needs_tmpdir flag is not needed to be set when use these flags:
> '.all_filesystems', '.format_device', '.mntpoint', '.mount_device'
> '.needs_checkpoints', '.needs_device', '.resource_file'.
>   These flags imply creating temporary directory.
> 
> Does have other case still have this duplicated flag?

	I have resubmit the patch which added 4 testcases that have this duplicated flag and midified the git log.


> 
> > Signed-off-by: Zhao Gongyi<zhaogongyi@huawei.com>
> > ---
> >   testcases/kernel/syscalls/fanotify/fanotify13.c | 1 -
> >   testcases/kernel/syscalls/setxattr/setxattr01.c | 1 -
> >   2 files changed, 2 deletions(-)
> >
> > diff --git a/testcases/kernel/syscalls/fanotify/fanotify13.c
> > b/testcases/kernel/syscalls/fanotify/fanotify13.c
> > index 6d812cdd1..1fb12ae68 100644
> > --- a/testcases/kernel/syscalls/fanotify/fanotify13.c
> > +++ b/testcases/kernel/syscalls/fanotify/fanotify13.c
> > @@ -289,7 +289,6 @@ static struct tst_test test = {
> >   	.setup = do_setup,
> >   	.cleanup = do_cleanup,
> >   	.needs_root = 1,
> > -	.needs_tmpdir = 1,
> >   	.mount_device = 1,
> >   	.mntpoint = MOUNT_PATH,
> >   	.all_filesystems = 1,
> > diff --git a/testcases/kernel/syscalls/setxattr/setxattr01.c
> > b/testcases/kernel/syscalls/setxattr/setxattr01.c
> > index 8b84dfe0d..8cd2821d0 100644
> > --- a/testcases/kernel/syscalls/setxattr/setxattr01.c
> > +++ b/testcases/kernel/syscalls/setxattr/setxattr01.c
> > @@ -210,7 +210,6 @@ static struct tst_test test = {
> >   	.mntpoint = MNTPOINT,
> >   	.mount_device = 1,
> >   	.all_filesystems = 1,
> > -	.needs_tmpdir = 1,
> >   	.needs_root = 1,
> >   };
> >
> > --
> > 2.17.1
> >
> >
> 
> 


^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-03-01  2:30 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-02-27  3:32 [LTP] [PATCH] fanotify13.c/setxattr01.c: Remove requirement of needs_tmpdir Zhao Gongyi
2021-03-01  1:48 ` Yang Xu
  -- strict thread matches above, loose matches on Subject: below --
2021-03-01  2:30 zhaogongyi

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.