Re: [PATCH 05/39] iio: hid-sensors: use iio_push_to_buffers_with_ts()

[srinivas pandruvada <srinivas.pandruvada@linux.intel.com>]

On Mon, 2026-10-26 at 16:05 -0700, Jonathan Cameron wrote:
> Replace the deprecated iio_push_to_buffers_with_timestamp() with
> iio_push_to_buffers_with_ts(), passing the size of the pushed buffer.
> 
> For hid-sensor-magn-3d, use IIO_DECLARE_BUFFER_WITH_TS() to suize the
> buffer for the maximum number of channels supported avoiding need
> for separate allocation.
> 
> Signed-off-by: Jonathan Cameron <jonathan.cameron@oss.qualcomm.com>

LGTM.
I will do some quick test on this and let you know.

Thanks,
Srinivas

> ---
> Cc: Jiri Kosina <jikos@kernel.org>
> Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> Cc: Zhang Lixu <lixu.zhang@intel.com>
> ---
>  drivers/iio/gyro/hid-sensor-gyro-3d.c               |  5 +++--
>  drivers/iio/humidity/hid-sensor-humidity.c          |  5 +++--
>  drivers/iio/magnetometer/hid-sensor-magn-3d.c       | 21 ++++++-----
> ----------
>  drivers/iio/orientation/hid-sensor-incl-3d.c        |  7 ++++---
>  .../iio/position/hid-sensor-custom-intel-hinge.c    |  4 ++--
>  5 files changed, 18 insertions(+), 24 deletions(-)
> 
> diff --git a/drivers/iio/gyro/hid-sensor-gyro-3d.c
> b/drivers/iio/gyro/hid-sensor-gyro-3d.c
> index 66778315e86d..083e82cf561c 100644
> --- a/drivers/iio/gyro/hid-sensor-gyro-3d.c
> +++ b/drivers/iio/gyro/hid-sensor-gyro-3d.c
> @@ -182,8 +182,9 @@ static int gyro_3d_proc_event(struct
> hid_sensor_hub_device *hsdev,
>  		if (!gyro_state->timestamp)
>  			gyro_state->timestamp =
> iio_get_time_ns(indio_dev);
>  
> -		iio_push_to_buffers_with_timestamp(indio_dev,
> &gyro_state->scan,
> -						   gyro_state-
> >timestamp);
> +		iio_push_to_buffers_with_ts(indio_dev, &gyro_state-
> >scan,
> +					    sizeof(gyro_state-
> >scan),
> +					    gyro_state->timestamp);
>  
>  		gyro_state->timestamp = 0;
>  	}
> diff --git a/drivers/iio/humidity/hid-sensor-humidity.c
> b/drivers/iio/humidity/hid-sensor-humidity.c
> index 12c88efe66be..c09986346c8f 100644
> --- a/drivers/iio/humidity/hid-sensor-humidity.c
> +++ b/drivers/iio/humidity/hid-sensor-humidity.c
> @@ -132,8 +132,9 @@ static int humidity_proc_event(struct
> hid_sensor_hub_device *hsdev,
>  	struct hid_humidity_state *humid_st = iio_priv(indio_dev);
>  
>  	if (atomic_read(&humid_st->common_attributes.data_ready))
> -		iio_push_to_buffers_with_timestamp(indio_dev,
> &humid_st->scan,
> -						  
> iio_get_time_ns(indio_dev));
> +		iio_push_to_buffers_with_ts(indio_dev, &humid_st-
> >scan,
> +					    sizeof(humid_st->scan),
> +					   
> iio_get_time_ns(indio_dev));
>  
>  	return 0;
>  }
> diff --git a/drivers/iio/magnetometer/hid-sensor-magn-3d.c
> b/drivers/iio/magnetometer/hid-sensor-magn-3d.c
> index c8b4fa7785c9..f869560b47fc 100644
> --- a/drivers/iio/magnetometer/hid-sensor-magn-3d.c
> +++ b/drivers/iio/magnetometer/hid-sensor-magn-3d.c
> @@ -37,8 +37,8 @@ struct magn_3d_state {
>  	struct hid_sensor_common rot_attributes;
>  	struct hid_sensor_hub_attribute_info
> magn[MAGN_3D_CHANNEL_MAX];
>  
> -	/* dynamically sized array to hold sensor values */
> -	u32 *iio_vals;
> +	/* array sized to hold maximum set of sensor values */
> +	IIO_DECLARE_BUFFER_WITH_TS(u32, iio_vals,
> MAGN_3D_CHANNEL_MAX);
>  	/* array of pointers to sensor value */
>  	u32 *magn_val_addr[MAGN_3D_CHANNEL_MAX];
>  
> @@ -275,9 +275,10 @@ static int magn_3d_proc_event(struct
> hid_sensor_hub_device *hsdev,
>  		if (!magn_state->timestamp)
>  			magn_state->timestamp =
> iio_get_time_ns(indio_dev);
>  
> -		iio_push_to_buffers_with_timestamp(indio_dev,
> -						   magn_state-
> >iio_vals,
> -						   magn_state-
> >timestamp);
> +		iio_push_to_buffers_with_ts(indio_dev,
> +					    magn_state->iio_vals,
> +					    sizeof(magn_state-
> >iio_vals),
> +					    magn_state->timestamp);
>  		magn_state->timestamp = 0;
>  	}
>  
> @@ -379,16 +380,6 @@ static int magn_3d_parse_report(struct
> platform_device *pdev,
>  		return -ENOMEM;
>  	}
>  
> -	/* attr_count include timestamp channel, and the iio_vals
> should be aligned to 8byte */
> -	st->iio_vals = devm_kcalloc(&pdev->dev,
> -				    ((attr_count + 1) % 2 +
> (attr_count + 1) / 2) * 2,
> -				    sizeof(u32), GFP_KERNEL);
> -	if (!st->iio_vals) {
> -		dev_err(&pdev->dev,
> -			"failed to allocate space for iio values
> array\n");
> -		return -ENOMEM;
> -	}
> -
>  	for (i = 0, *chan_count = 0;
>  	i < MAGN_3D_CHANNEL_MAX && *chan_count < attr_count;
>  	i++){
> diff --git a/drivers/iio/orientation/hid-sensor-incl-3d.c
> b/drivers/iio/orientation/hid-sensor-incl-3d.c
> index b5f70732d035..3880e479a499 100644
> --- a/drivers/iio/orientation/hid-sensor-incl-3d.c
> +++ b/drivers/iio/orientation/hid-sensor-incl-3d.c
> @@ -194,9 +194,10 @@ static int incl_3d_proc_event(struct
> hid_sensor_hub_device *hsdev,
>  		if (!incl_state->timestamp)
>  			incl_state->timestamp =
> iio_get_time_ns(indio_dev);
>  
> -		iio_push_to_buffers_with_timestamp(indio_dev,
> -						   &incl_state-
> >scan,
> -						   incl_state-
> >timestamp);
> +		iio_push_to_buffers_with_ts(indio_dev,
> +					    &incl_state->scan,
> +					    sizeof(incl_state-
> >scan),
> +					    incl_state->timestamp);
>  
>  		incl_state->timestamp = 0;
>  	}
> diff --git a/drivers/iio/position/hid-sensor-custom-intel-hinge.c
> b/drivers/iio/position/hid-sensor-custom-intel-hinge.c
> index 101d84b533c9..98a5e3e03bba 100644
> --- a/drivers/iio/position/hid-sensor-custom-intel-hinge.c
> +++ b/drivers/iio/position/hid-sensor-custom-intel-hinge.c
> @@ -198,8 +198,8 @@ static int hinge_proc_event(struct
> hid_sensor_hub_device *hsdev,
>  		if (!st->timestamp)
>  			st->timestamp = iio_get_time_ns(indio_dev);
>  
> -		iio_push_to_buffers_with_timestamp(indio_dev, &st-
> >scan,
> -						   st->timestamp);
> +		iio_push_to_buffers_with_ts(indio_dev, &st->scan,
> +					    sizeof(st->scan), st-
> >timestamp);
>  
>  		st->timestamp = 0;
>  	}