Re: [PATCH 36/39] iio: common: cros_ec_sensors: use iio_push_to_buffers_with_ts()

[Tzung-Bi Shih <tzungbi@kernel.org>]

On Mon, Oct 26, 2026 at 04:05:54PM -0700, Jonathan Cameron wrote:
> Replace the deprecated iio_push_to_buffers_with_timestamp() with
> iio_push_to_buffers_with_ts(), passing the size of the pushed buffer,
> at both call sites.
> 
> Replace the raw samples byte array with a scan struct containing the
> channel data and an aligned timestamp, matching the layout it was
> already manually maintaining and removing the need for the
> CROS_EC_SAMPLE_SIZE size calculation and the casts used to access it
> as an array of s16.
> 
> Signed-off-by: Jonathan Cameron <jonathan.cameron@oss.qualcomm.com>

The patch looks good to me.  Just a minor note below.

Reviewed-by: Tzung-Bi Shih <tzungbi@kernel.org>

> diff --git a/drivers/iio/common/cros_ec_sensors/cros_ec_sensors_core.c b/drivers/iio/common/cros_ec_sensors/cros_ec_sensors_core.c
...
> @@ -192,19 +191,17 @@ int cros_ec_sensors_push_data(struct iio_dev *indio_dev,
>  	if (!iio_device_try_claim_buffer_mode(indio_dev))
>  		return 0;
>  
> -	out = (s16 *)st->samples;
> -	iio_for_each_active_channel(indio_dev, i) {
> -		*out = data[i];
> -		out++;
> -	}
> +	j = 0;
> +	iio_for_each_active_channel(indio_dev, i)
> +		st->scan.channels[j++] = data[i];

This is a pre-existing issue, but there is no bounds check on `j`.  I'm
not sure if the number of active channels can ever exceed 4.