All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heiko Stuebner <heiko@sntech.de>
To: Marc Kleine-Budde <mkl@pengutronix.de>,
	Vincent Mailhol <mailhol@kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	Wolfgang Grandegger <wg@grandegger.com>,
	Oliver Hartkopp <socketcan@hartkopp.net>,
	kernel <kernel@pengutronix.de>,
	Eric Dumazet <edumazet@kernel.org>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Simon Horman <horms@kernel.org>, Jonathan Corbet <corbet@lwn.net>,
	Shuah Khan <skhan@linuxfoundation.org>,
	Randy Dunlap <rdunlap@infradead.org>,
	Cunhao Lu <1579567540@qq.com>
Cc: linux-can <linux-can@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	linux-rockchip <linux-rockchip@lists.infradead.org>,
	netdev <netdev@vger.kernel.org>,
	linux-doc <linux-doc@vger.kernel.org>,
	stable <stable@vger.kernel.org>
Subject: Re: [PATCH net v7 0/7] can: fix bus-off restart and device close races
Date: Sat, 07 Nov 2026 15:40:55 +0100	[thread overview]
Message-ID: <6105577.1B3tZ46Xf9@phil> (raw)
In-Reply-To: <tencent_B3369A1199D0849091BB8015C41BBFF0A607@qq.com>

Hi,

Am Samstag, 7. November 2026, 03:57:26 Mitteleuropäische Normalzeit schrieb Cunhao Lu:
> > > This series depends on the three patches in "can: skb: make CAN skb
> > > freeing safe in any IRQ context" [1] and the three patches in "can:
> > > rockchip_canfd: fix TX stalls and races" [2].
> > > 
> > > [1] https://lore.kernel.org/linux-can/tencent_CD05F020BAFB2537F5D1F4CBB425588EA80A@qq.com/
> > > [2] https://lore.kernel.org/linux-can/tencent_E25C9BE6689264E4138A464803B810FDFD09@qq.com/
> > 
> > Both these series are from july and seemingly from before you started
> > using the b4-relay. So they may or may not have survived the kernel
> > releases and their threading is broken both on lore and in any maibox
> > they arrived in.
> > 
> > And if there haven't been any responses to them since then, I'd think
> > they have been lost or so.
> > 
> > So I'd suggest rolling both your dependencies forward on top of the can
> > tree and sending them as a new version, so that reviewers can find them?
> 
> Thank you very much for the guidance! :-P
> 
> I just checked: the "can: skb: make CAN skb freeing safe in any IRQ
> context" series was merged into mainline yesterday, so I won't send a
> new version of it. I'll remove its link from the cover letter.
> 
> The "can: rockchip_canfd: fix TX stalls and races" series still has some
> issues reported by the bots during submission to the net tree that I
> need to address. Since those patches overlap with this series, I plan
> to fold them into the next version (v8) and send them together.

As that series is also "just" for the Rockchip CAN driver, merging both
sounds like a good plan - especially as it makes it easier to keep track
of things :-) .


Heiko



WARNING: multiple messages have this Message-ID (diff)
From: Heiko Stuebner <heiko@sntech.de>
To: Marc Kleine-Budde <mkl@pengutronix.de>,
	Vincent Mailhol <mailhol@kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	Wolfgang Grandegger <wg@grandegger.com>,
	Oliver Hartkopp <socketcan@hartkopp.net>,
	kernel <kernel@pengutronix.de>,
	Eric Dumazet <edumazet@kernel.org>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Simon Horman <horms@kernel.org>, Jonathan Corbet <corbet@lwn.net>,
	Shuah Khan <skhan@linuxfoundation.org>,
	Randy Dunlap <rdunlap@infradead.org>,
	Cunhao Lu <1579567540@qq.com>
Cc: linux-can <linux-can@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	linux-rockchip <linux-rockchip@lists.infradead.org>,
	netdev <netdev@vger.kernel.org>,
	linux-doc <linux-doc@vger.kernel.org>,
	stable <stable@vger.kernel.org>
Subject: Re: [PATCH net v7 0/7] can: fix bus-off restart and device close races
Date: Sat, 07 Nov 2026 15:40:55 +0100	[thread overview]
Message-ID: <6105577.1B3tZ46Xf9@phil> (raw)
In-Reply-To: <tencent_B3369A1199D0849091BB8015C41BBFF0A607@qq.com>

Hi,

Am Samstag, 7. November 2026, 03:57:26 Mitteleuropäische Normalzeit schrieb Cunhao Lu:
> > > This series depends on the three patches in "can: skb: make CAN skb
> > > freeing safe in any IRQ context" [1] and the three patches in "can:
> > > rockchip_canfd: fix TX stalls and races" [2].
> > > 
> > > [1] https://lore.kernel.org/linux-can/tencent_CD05F020BAFB2537F5D1F4CBB425588EA80A@qq.com/
> > > [2] https://lore.kernel.org/linux-can/tencent_E25C9BE6689264E4138A464803B810FDFD09@qq.com/
> > 
> > Both these series are from july and seemingly from before you started
> > using the b4-relay. So they may or may not have survived the kernel
> > releases and their threading is broken both on lore and in any maibox
> > they arrived in.
> > 
> > And if there haven't been any responses to them since then, I'd think
> > they have been lost or so.
> > 
> > So I'd suggest rolling both your dependencies forward on top of the can
> > tree and sending them as a new version, so that reviewers can find them?
> 
> Thank you very much for the guidance! :-P
> 
> I just checked: the "can: skb: make CAN skb freeing safe in any IRQ
> context" series was merged into mainline yesterday, so I won't send a
> new version of it. I'll remove its link from the cover letter.
> 
> The "can: rockchip_canfd: fix TX stalls and races" series still has some
> issues reported by the bots during submission to the net tree that I
> need to address. Since those patches overlap with this series, I plan
> to fold them into the next version (v8) and send them together.

As that series is also "just" for the Rockchip CAN driver, merging both
sounds like a good plan - especially as it makes it easier to keep track
of things :-) .


Heiko



_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

  reply	other threads:[~2026-11-07 14:41 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-06  9:37 [PATCH net v7 0/7] can: fix bus-off restart and device close races Cunhao Lu via B4 Relay
2026-11-06  9:37 ` Cunhao Lu via B4 Relay
2026-11-06  9:37 ` Cunhao Lu
2026-11-06  9:37 ` [PATCH net v7 1/7] can: dev: check netif_running() before bus-off recovery Cunhao Lu via B4 Relay
2026-11-06  9:37   ` Cunhao Lu via B4 Relay
2026-11-06  9:37   ` Cunhao Lu
2026-11-06  9:37 ` [PATCH net v7 2/7] can: dev: add close_candev_cancel_restart_sync() Cunhao Lu via B4 Relay
2026-11-06  9:37   ` Cunhao Lu via B4 Relay
2026-11-06  9:37   ` Cunhao Lu
2026-11-06  9:37 ` [PATCH net v7 3/7] can: rockchip_canfd: cancel bus-off restart before closing the device Cunhao Lu via B4 Relay
2026-11-06  9:37   ` Cunhao Lu via B4 Relay
2026-11-06  9:37   ` Cunhao Lu
2026-11-06  9:37 ` [PATCH net v7 4/7] can: rockchip_canfd: disable RX offload on open failure Cunhao Lu via B4 Relay
2026-11-06  9:37   ` Cunhao Lu via B4 Relay
2026-11-06  9:37   ` Cunhao Lu
2026-11-06  9:37 ` [PATCH net v7 5/7] can: rockchip_canfd: serialize TX with bus-off and restart Cunhao Lu via B4 Relay
2026-11-06  9:37   ` Cunhao Lu via B4 Relay
2026-11-06  9:37   ` Cunhao Lu
2026-11-06  9:37 ` [PATCH net v7 6/7] can: rockchip_canfd: prevent timestamp work from rearming after bus-off Cunhao Lu via B4 Relay
2026-11-06  9:37   ` Cunhao Lu via B4 Relay
2026-11-06  9:37   ` Cunhao Lu
2026-11-06  9:37 ` [PATCH net v7 7/7] can: rockchip_canfd: serialize timecounter timestamp conversion Cunhao Lu via B4 Relay
2026-11-06  9:37   ` Cunhao Lu via B4 Relay
2026-11-06  9:37   ` Cunhao Lu
2026-11-06 12:50 ` [PATCH net v7 0/7] can: fix bus-off restart and device close races Heiko Stübner
2026-11-06 12:50   ` Heiko Stübner
2026-11-07  2:57   ` Cunhao Lu
2026-11-07  2:57     ` Cunhao Lu
2026-11-07 14:40     ` Heiko Stuebner [this message]
2026-11-07 14:40       ` Heiko Stuebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6105577.1B3tZ46Xf9@phil \
    --to=heiko@sntech.de \
    --cc=1579567540@qq.com \
    --cc=corbet@lwn.net \
    --cc=davem@davemloft.net \
    --cc=edumazet@kernel.org \
    --cc=horms@kernel.org \
    --cc=kernel@pengutronix.de \
    --cc=kuba@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-can@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=mailhol@kernel.org \
    --cc=mkl@pengutronix.de \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=rdunlap@infradead.org \
    --cc=skhan@linuxfoundation.org \
    --cc=socketcan@hartkopp.net \
    --cc=stable@vger.kernel.org \
    --cc=wg@grandegger.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.