From: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
To: Carlos de Paula <me-FwFLQrstKkX3oGB3hsPCZA@public.gmane.org>
Cc: papadakospan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
jose.abreu-HKixBCOQz3hWk0Htik3J/w@public.gmane.org,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Robin Murphy <robin.murphy-5wv7dgnIgG8@public.gmane.org>,
Jonas Karlman <jonas-uIzNG4q0ceqzQB+pC5nmwQ@public.gmane.org>,
Peter Geis <pgwipeout-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Katsuhiro Suzuki
<katsuhiro-WKCMddiH/C4xsqv6Oivclw@public.gmane.org>,
Johan Jonker <jbx6244-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Philipp Tomsich
<philipp.tomsich-SN7IsUiht6C/RdPyistoZJqQE7yCjDx5@public.gmane.org>,
Christoph Muellner
<christoph.muellner-SN7IsUiht6C/RdPyistoZJqQE7yCjDx5@public.gmane.org>,
Enric Balletbo i Serra
<enric.balletbo-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>,
Daniel Lezcano
<daniel.lezcano-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] arm64: dts: rockchip: Add txpbl node for RK3399/RK3328
Date: Sun, 01 Mar 2020 01:25:16 +0100 [thread overview]
Message-ID: <6132615.msM8OCcsVu@phil> (raw)
In-Reply-To: <20200218221040.10955-1-me-FwFLQrstKkX3oGB3hsPCZA@public.gmane.org>
Am Dienstag, 18. Februar 2020, 23:10:37 CET schrieb Carlos de Paula:
> Some rockchip SoCs like the RK3399 and RK3328 exhibit an issue
> where tx checksumming does not work with packets larger than 1498.
>
> The default Programmable Buffer Length for TX in these GMAC's is
> not suitable for MTUs higher than 1498. The workaround is to disable
> TX offloading with 'ethtool -K eth0 tx off rx off' causing performance
> impacts as it disables hardware checksumming.
>
> This patch sets snps,txpbl to 0x4 which is a safe number tested ok for
> the most popular MTU value of 1500.
>
> For reference, see https://lkml.org/lkml/2019/4/1/1382.
>
> Signed-off-by: Carlos de Paula <me-FwFLQrstKkX3oGB3hsPCZA@public.gmane.org>
applied for 5.7
Thanks
Heiko
WARNING: multiple messages have this Message-ID (diff)
From: Heiko Stuebner <heiko@sntech.de>
To: Carlos de Paula <me@carlosedp.com>
Cc: jose.abreu@synopsys.com, Mark Rutland <mark.rutland@arm.com>,
Jonas Karlman <jonas@kwiboo.se>,
Katsuhiro Suzuki <katsuhiro@katsuster.net>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
devicetree@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org,
Peter Geis <pgwipeout@gmail.com>,
Enric Balletbo i Serra <enric.balletbo@collabora.com>,
Johan Jonker <jbx6244@gmail.com>,
Philipp Tomsich <philipp.tomsich@theobroma-systems.com>,
Robin Murphy <robin.murphy@arm.com>,
papadakospan@gmail.com,
Christoph Muellner <christoph.muellner@theobroma-systems.com>
Subject: Re: [PATCH] arm64: dts: rockchip: Add txpbl node for RK3399/RK3328
Date: Sun, 01 Mar 2020 01:25:16 +0100 [thread overview]
Message-ID: <6132615.msM8OCcsVu@phil> (raw)
In-Reply-To: <20200218221040.10955-1-me@carlosedp.com>
Am Dienstag, 18. Februar 2020, 23:10:37 CET schrieb Carlos de Paula:
> Some rockchip SoCs like the RK3399 and RK3328 exhibit an issue
> where tx checksumming does not work with packets larger than 1498.
>
> The default Programmable Buffer Length for TX in these GMAC's is
> not suitable for MTUs higher than 1498. The workaround is to disable
> TX offloading with 'ethtool -K eth0 tx off rx off' causing performance
> impacts as it disables hardware checksumming.
>
> This patch sets snps,txpbl to 0x4 which is a safe number tested ok for
> the most popular MTU value of 1500.
>
> For reference, see https://lkml.org/lkml/2019/4/1/1382.
>
> Signed-off-by: Carlos de Paula <me@carlosedp.com>
applied for 5.7
Thanks
Heiko
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Heiko Stuebner <heiko@sntech.de>
To: Carlos de Paula <me@carlosedp.com>
Cc: papadakospan@gmail.com, jose.abreu@synopsys.com,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Robin Murphy <robin.murphy@arm.com>,
Jonas Karlman <jonas@kwiboo.se>, Peter Geis <pgwipeout@gmail.com>,
Katsuhiro Suzuki <katsuhiro@katsuster.net>,
Johan Jonker <jbx6244@gmail.com>,
Philipp Tomsich <philipp.tomsich@theobroma-systems.com>,
Christoph Muellner <christoph.muellner@theobroma-systems.com>,
Enric Balletbo i Serra <enric.balletbo@collabora.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: rockchip: Add txpbl node for RK3399/RK3328
Date: Sun, 01 Mar 2020 01:25:16 +0100 [thread overview]
Message-ID: <6132615.msM8OCcsVu@phil> (raw)
In-Reply-To: <20200218221040.10955-1-me@carlosedp.com>
Am Dienstag, 18. Februar 2020, 23:10:37 CET schrieb Carlos de Paula:
> Some rockchip SoCs like the RK3399 and RK3328 exhibit an issue
> where tx checksumming does not work with packets larger than 1498.
>
> The default Programmable Buffer Length for TX in these GMAC's is
> not suitable for MTUs higher than 1498. The workaround is to disable
> TX offloading with 'ethtool -K eth0 tx off rx off' causing performance
> impacts as it disables hardware checksumming.
>
> This patch sets snps,txpbl to 0x4 which is a safe number tested ok for
> the most popular MTU value of 1500.
>
> For reference, see https://lkml.org/lkml/2019/4/1/1382.
>
> Signed-off-by: Carlos de Paula <me@carlosedp.com>
applied for 5.7
Thanks
Heiko
next prev parent reply other threads:[~2020-03-01 0:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-18 22:10 [PATCH] arm64: dts: rockchip: Add txpbl node for RK3399/RK3328 Carlos de Paula
2020-02-18 22:10 ` Carlos de Paula
2020-02-18 22:10 ` Carlos de Paula
2020-03-01 8:22 ` Daniel Lezcano
2020-03-01 8:22 ` Daniel Lezcano
[not found] ` <20200218221040.10955-1-me-FwFLQrstKkX3oGB3hsPCZA@public.gmane.org>
2020-03-01 0:25 ` Heiko Stuebner [this message]
2020-03-01 0:25 ` Heiko Stuebner
2020-03-01 0:25 ` Heiko Stuebner
2020-03-01 2:06 ` Leonidas P.
2020-03-01 2:06 ` Leonidas P.
2020-03-01 2:06 ` Leonidas P.
2020-03-01 9:02 ` Daniel Lezcano
2020-03-01 9:02 ` Daniel Lezcano
2020-03-01 9:02 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6132615.msM8OCcsVu@phil \
--to=heiko-4mtyjxux2i+zqb+pc5nmwq@public.gmane.org \
--cc=christoph.muellner-SN7IsUiht6C/RdPyistoZJqQE7yCjDx5@public.gmane.org \
--cc=daniel.lezcano-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=enric.balletbo-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org \
--cc=jbx6244-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=jonas-uIzNG4q0ceqzQB+pC5nmwQ@public.gmane.org \
--cc=jose.abreu-HKixBCOQz3hWk0Htik3J/w@public.gmane.org \
--cc=katsuhiro-WKCMddiH/C4xsqv6Oivclw@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=me-FwFLQrstKkX3oGB3hsPCZA@public.gmane.org \
--cc=papadakospan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=pgwipeout-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=philipp.tomsich-SN7IsUiht6C/RdPyistoZJqQE7yCjDx5@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=robin.murphy-5wv7dgnIgG8@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.