All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miles Glenn <milesg@linux.ibm.com>
To: Nicholas Piggin <npiggin@gmail.com>, qemu-ppc@nongnu.org
Cc: qemu-devel@nongnu.org, Chalapathi V <chalapathi.v@linux.ibm.com>,
	Harsh Prateek Bora <harshpb@linux.ibm.com>
Subject: Re: [PATCH 4/4] ppc/pnv: Add xscom- prefix to pervasive-control region name
Date: Mon, 25 Nov 2024 10:28:11 -0600	[thread overview]
Message-ID: <613eb9bb44df7bac82244a3dfae35d8bcf4a4d83.camel@linux.ibm.com> (raw)
In-Reply-To: <20241125132042.325734-5-npiggin@gmail.com>

Reviewed-by: Glenn Miles <milesg@linux.ibm.com>

On Mon, 2024-11-25 at 23:20 +1000, Nicholas Piggin wrote:
> By convention, xscom regions get a xscom- prefix.
> 
> Fixes: 1adf24708bf7 ("hw/ppc: Add pnv nest pervasive common chiplet
> model")
> Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
> ---
>  hw/ppc/pnv_nest_pervasive.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/ppc/pnv_nest_pervasive.c
> b/hw/ppc/pnv_nest_pervasive.c
> index 77476753a4..780fa69dde 100644
> --- a/hw/ppc/pnv_nest_pervasive.c
> +++ b/hw/ppc/pnv_nest_pervasive.c
> @@ -177,7 +177,7 @@ static void
> pnv_nest_pervasive_realize(DeviceState *dev, Error **errp)
>      pnv_xscom_region_init(&nest_pervasive->xscom_ctrl_regs_mr,
>                            OBJECT(nest_pervasive),
>                            &pnv_nest_pervasive_control_xscom_ops,
> -                          nest_pervasive, "pervasive-control",
> +                          nest_pervasive, "xscom-pervasive-control",
>                            PNV10_XSCOM_CHIPLET_CTRL_REGS_SIZE);
>  }
>  



  reply	other threads:[~2024-11-25 16:28 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-25 13:20 [PATCH 0/4] ppc: various fixes for 9.2 Nicholas Piggin
2024-11-25 13:20 ` [PATCH 1/4] target/ppc: Fix non-maskable interrupt while halted Nicholas Piggin
2024-11-25 16:26   ` Miles Glenn
2024-11-25 13:20 ` [PATCH 2/4] ppc/pnv: Fix direct controls quiesce Nicholas Piggin
2024-11-25 16:31   ` Miles Glenn
2024-11-25 13:20 ` [PATCH 3/4] target/ppc: Fix THREAD_SIBLING_FOREACH for mult-socket Nicholas Piggin
2024-11-25 16:26   ` Miles Glenn
2024-11-25 13:20 ` [PATCH 4/4] ppc/pnv: Add xscom- prefix to pervasive-control region name Nicholas Piggin
2024-11-25 16:28   ` Miles Glenn [this message]
2024-11-25 19:28   ` Philippe Mathieu-Daudé
2024-11-26  3:54     ` Nicholas Piggin
2024-11-26  5:19       ` Philippe Mathieu-Daudé
2024-11-26 15:43         ` Peter Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=613eb9bb44df7bac82244a3dfae35d8bcf4a4d83.camel@linux.ibm.com \
    --to=milesg@linux.ibm.com \
    --cc=chalapathi.v@linux.ibm.com \
    --cc=harshpb@linux.ibm.com \
    --cc=npiggin@gmail.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.