From: Heiner Kallweit <hkallweit1@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
David Miller <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH 1/4 net-next] net: phy: aquantia: shorten name space prefix to aqr_
Date: Sun, 3 Feb 2019 20:42:05 +0100 [thread overview]
Message-ID: <614dcb79-e824-ec33-868f-80718138c0be@gmail.com> (raw)
In-Reply-To: <20190203193847.GD27045@lunn.ch>
On 03.02.2019 20:38, Andrew Lunn wrote:
> On Sun, Feb 03, 2019 at 08:33:13PM +0100, Heiner Kallweit wrote:
>> From: Andrew Lunn <andrew@lunn.ch>
>> aquantia_ as a name space prefix is rather long, resulting in lots of
>> lines needing wrapping, reducing readability. Use the prefix aqr_
>> instead, which fits with the vendor naming there devices aqr107, for
>> example.
>>
>> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
>
> Hi Heiner
>
> You need to add your signed-off-by here. Anybody who handles the patch
> on its way into the kernel needs to add a SOB.
>
> Andrew
>
Each day you learn something new .. I was under the impression that I have
to do this in case of changes only. And this patch I forwarded as is.
Let me know whether you have other review comments. Then I bundle the
changes in a v2.
Heiner
next prev parent reply other threads:[~2019-02-03 19:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-03 19:32 [PATCH 0/4 net-next] net: phy: aquantia: number of improvements Heiner Kallweit
2019-02-03 19:33 ` [PATCH 1/4 net-next] net: phy: aquantia: shorten name space prefix to aqr_ Heiner Kallweit
2019-02-03 19:38 ` Andrew Lunn
2019-02-03 19:42 ` Heiner Kallweit [this message]
2019-02-03 19:33 ` [PATCH 2/4 net-next] net: phy: aquantia: remove unneeded includes Heiner Kallweit
2019-02-03 19:54 ` Andrew Lunn
2019-02-03 20:08 ` Heiner Kallweit
2019-02-03 19:34 ` [PATCH 3/4 net-next] net: phy: aquantia: use macro PHY_ID_MATCH_MODEL Heiner Kallweit
2019-02-03 19:54 ` Andrew Lunn
2019-02-03 19:35 ` [PATCH 4/4 net-next] net: phy: aquantia: replace magic numbers with constants Heiner Kallweit
2019-02-03 19:56 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=614dcb79-e824-ec33-868f-80718138c0be@gmail.com \
--to=hkallweit1@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.