All of lore.kernel.org
 help / color / mirror / Atom feed
From: Roger Quadros <rogerq@kernel.org>
To: Joe Hershberger <joe.hershberger@ni.com>,
	Ramon Fried <rfried.dev@gmail.com>, Tom Rini <trini@konsulko.com>,
	Nishanth Menon <nm@ti.com>,
	Robert Nelson <robertcnelson@gmail.com>,
	Wadim Egorov <w.egorov@phytec.de>,
	Marcel Ziswiler <marcel.ziswiler@toradex.com>,
	Simon Glass <sjg@chromium.org>
Cc: srk@ti.com, s-vadapalli@ti.com, vigneshr@ti.com,
	r-gunasekaran@ti.com, danishanwar@ti.com, u-boot@lists.denx.de
Subject: Re: [PATCH 0/5] net: mdio-uclass: probe generic Ethernet PHY driver & Fix Beagleplay Ethernet
Date: Fri, 8 Mar 2024 10:22:02 +0200	[thread overview]
Message-ID: <615aa2aa-6d02-439b-a091-1bc8fc38495f@kernel.org> (raw)
In-Reply-To: <20240305-for-2024-07-beagleplay-eth-v1-0-e1294a575cc1@kernel.org>



On 05/03/2024 15:24, Roger Quadros wrote:
> Currently, the GPIO Reset Device Tree properties of the
> PHY node are ignored when the PHY is probed via mdio-uclass driver [1].
> 
> To resolve this, for each child of the MDIO bus node, bind and probe
> the generic Ethernet PHY driver if CONFIG_DM_ETH_PHY is enabled.
> 
> This should now show the generic_phy_driver in "dm tree"
> and also apply the GPIO reset before the MDIO bus driver scans the bus
> for the PHYs.
> 
>  ethernet      0  [ + ]   am65_cpsw_nuss_port       |   |-- ethernet@8000000port@1
>  bootdev       3  [   ]   eth_bootdev               |   |   `-- port@1.bootdev
>  mdio          0  [ + ]   cpsw_mdio                 |   `-- mdio@f00
>  eth_phy_ge    0  [ + ]   eth_phy_generic_drv       |       |-- ethernet-phy@0
>  eth_phy_ge    1  [ + ]   eth_phy_generic_drv       |       `-- ethernet-phy@1
> 
> To test this on Beagleplay, the following series is required
> 
> [1] Switch am65-cpsw to DM MDIO
>  https://lore.kernel.org/all/20240228-for-2024-07-am65-cpsw-mdio-v2-0-f74f972eafeb@kernel.org/
> 
> The last 3 patches are marked [not-for-merge]. They are to show how the
> whole solution can work to fix Ethernet on Beagleplay, which has been broken
> so far. Those DT patches will be sent once the device tree changes are merged
> into Linux tree.
> 
> Signed-off-by: Roger Quadros <rogerq@kernel.org>

Some CI tests failed. I will fix and send v2.
https://github.com/u-boot/u-boot/pull/495

> ---
> Roger Quadros (5):
>       net: mdio-uclass: Bind and probe generic Ethernet PHY driver
>       configs/am62x_beagleplay_a53_defconfig: enable DM_ETH_PHY
>       [not-for-merge] arm: dts: k3-am62*: sync with linux-next-20240229
>       [not-for-merge] k3-am625-beagleplay-u-boot: get CPSW Ethernet to work
>       [not-for-merge] arm: dts: k3-am625-beagleplay: Fix Ethernet PHY reset GPIO
> 
>  arch/arm/dts/k3-am62-main.dtsi               | 126 ++++++++++++++---
>  arch/arm/dts/k3-am62-mcu.dtsi                |   4 +-
>  arch/arm/dts/k3-am62-phycore-som.dtsi        |   5 +-
>  arch/arm/dts/k3-am62-thermal.dtsi            |   5 +-
>  arch/arm/dts/k3-am62-verdin-dev.dtsi         |   4 +-
>  arch/arm/dts/k3-am62-verdin-wifi.dtsi        |   1 -
>  arch/arm/dts/k3-am62-verdin.dtsi             |  76 +++++++---
>  arch/arm/dts/k3-am62-wakeup.dtsi             |  38 +++--
>  arch/arm/dts/k3-am62.dtsi                    |   4 +-
>  arch/arm/dts/k3-am625-beagleplay-u-boot.dtsi |  63 +++++++++
>  arch/arm/dts/k3-am625-beagleplay.dts         |  66 ++++-----
>  arch/arm/dts/k3-am625-phyboard-lyra-rdk.dts  | 104 +++++++++++++-
>  arch/arm/dts/k3-am625-sk.dts                 |   4 +-
>  arch/arm/dts/k3-am625.dtsi                   |   4 +-
>  arch/arm/dts/k3-am62a-main.dtsi              | 201 +++++++++++++++++++++++++--
>  arch/arm/dts/k3-am62a-mcu.dtsi               |   4 +-
>  arch/arm/dts/k3-am62a-thermal.dtsi           |   5 +-
>  arch/arm/dts/k3-am62a-wakeup.dtsi            |   4 +-
>  arch/arm/dts/k3-am62a.dtsi                   |   4 +-
>  arch/arm/dts/k3-am62a7-sk.dts                | 162 ++++++++++++++++++++-
>  arch/arm/dts/k3-am62a7.dtsi                  |   4 +-
>  arch/arm/dts/k3-am62x-sk-common.dtsi         |  24 +++-
>  configs/am62x_beagleplay_a53_defconfig       |   2 +-
>  net/mdio-uclass.c                            |  41 ++++++
>  24 files changed, 825 insertions(+), 130 deletions(-)
> ---
> base-commit: 84f5bb0be0ec9fbf98f8f3317b578dfc114cf44e
> change-id: 20240305-for-2024-07-beagleplay-eth-f82a51197937
> 
> Best regards,

-- 
cheers,
-roger

  parent reply	other threads:[~2024-03-08  8:22 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-05 13:24 [PATCH 0/5] net: mdio-uclass: probe generic Ethernet PHY driver & Fix Beagleplay Ethernet Roger Quadros
2024-03-05 13:24 ` [PATCH 1/5] net: mdio-uclass: Bind and probe generic Ethernet PHY driver Roger Quadros
2024-03-28 15:09   ` Tom Rini
2024-03-05 13:24 ` [PATCH 2/5] configs/am62x_beagleplay_a53_defconfig: enable DM_ETH_PHY Roger Quadros
2024-03-28 15:09   ` Tom Rini
2024-03-05 13:24 ` [PATCH not-for-merge 3/5] arm: dts: k3-am62*: sync with linux-next-20240229 Roger Quadros
2024-03-05 13:24 ` [PATCH not-for-merge 4/5] k3-am625-beagleplay-u-boot: get CPSW Ethernet to work Roger Quadros
2024-03-05 13:24 ` [PATCH not-for-merge 5/5] arm: dts: k3-am625-beagleplay: Fix Ethernet PHY reset GPIO Roger Quadros
2024-03-08  8:22 ` Roger Quadros [this message]
2024-03-08  8:26   ` [PATCH 0/5] net: mdio-uclass: probe generic Ethernet PHY driver & Fix Beagleplay Ethernet Roger Quadros
2024-03-25 12:16 ` Roger Quadros
2024-03-26  2:00   ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=615aa2aa-6d02-439b-a091-1bc8fc38495f@kernel.org \
    --to=rogerq@kernel.org \
    --cc=danishanwar@ti.com \
    --cc=joe.hershberger@ni.com \
    --cc=marcel.ziswiler@toradex.com \
    --cc=nm@ti.com \
    --cc=r-gunasekaran@ti.com \
    --cc=rfried.dev@gmail.com \
    --cc=robertcnelson@gmail.com \
    --cc=s-vadapalli@ti.com \
    --cc=sjg@chromium.org \
    --cc=srk@ti.com \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=vigneshr@ti.com \
    --cc=w.egorov@phytec.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.