All of lore.kernel.org
 help / color / mirror / Atom feed
From: Phillip Wood <phillip.wood123@gmail.com>
To: Jeff King <peff@peff.net>, Patrick Steinhardt <ps@pks.im>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
	Kaartic Sivaraam <kaartic.sivaraam@gmail.com>
Subject: Re: [PATCH 8/8] t/test-lib: make feature-testbed job more accessible
Date: Wed, 28 Oct 2026 14:33:15 +0000	[thread overview]
Message-ID: <617fa828-387a-4f4a-bc85-099ca691bca4@gmail.com> (raw)
In-Reply-To: <20261027212349.GA774120@coredump.intra.peff.net>

On 27/10/2026 21:23, Jeff King wrote:
> 
> IMHO this whole thing isn't really worth the complexity, but if we are
> going to do it, should it be "make FEATURE_TESTBED=1", and then that
> enables the right build knobs, and test-lib.sh respects that variable
> coming from BUILD-OPTIONS rather than the command line?

If we want to be able to recreate the CI job locally then I agree a 
Makefile flag is a better solution. I seem to remember Ævar trying to 
add Makefile targets for some of the CI jobs so they could be run locally.

Thanks

Phillip


  parent reply	other threads:[~2026-10-28 14:33 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-27  8:18 [PATCH 0/8] ci: consolidate test variables Patrick Steinhardt
2026-10-27  8:18 ` [PATCH 1/8] ci: consolidate setup of test environment Patrick Steinhardt
2026-10-27  8:18 ` [PATCH 2/8] ci/lib: always set GIT_TEST_USE_SET_E on Linux jobs Patrick Steinhardt
2026-10-27  8:18 ` [PATCH 3/8] ci/lib: deduplicate test variables by pattern matching Patrick Steinhardt
2026-10-27  8:18 ` [PATCH 4/8] ci/lib: merge switches for specific job names Patrick Steinhardt
2026-10-27  8:18 ` [PATCH 5/8] t: honor default ref storage format Patrick Steinhardt
2026-10-27  8:18 ` [PATCH 6/8] ci/lib: add another NO_RUST build using glibc Patrick Steinhardt
2026-10-27  8:18 ` [PATCH 7/8] ci: don't override initial branch name in testbed job Patrick Steinhardt
2026-10-27  8:18 ` [PATCH 8/8] t/test-lib: make feature-testbed job more accessible Patrick Steinhardt
2026-10-27 14:53   ` Phillip Wood
2026-10-27 20:59     ` Junio C Hamano
2026-10-28  7:41       ` Patrick Steinhardt
2026-10-27 21:23   ` Jeff King
2026-10-27 21:47     ` Junio C Hamano
2026-10-28  7:39     ` Patrick Steinhardt
2026-10-28 14:33     ` Phillip Wood [this message]
2026-10-27 15:00 ` [PATCH 0/8] ci: consolidate test variables Phillip Wood
2026-10-27 20:59   ` Junio C Hamano
2026-10-27 21:24 ` Jeff King
2026-10-28 14:40   ` Toon Claes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=617fa828-387a-4f4a-bc85-099ca691bca4@gmail.com \
    --to=phillip.wood123@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=kaartic.sivaraam@gmail.com \
    --cc=peff@peff.net \
    --cc=phillip.wood@dunelm.org.uk \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.