From: Junio C Hamano <gitster@pobox.com>
To: Phillip Wood <phillip.wood123@gmail.com>
Cc: Patrick Steinhardt <ps@pks.im>,
git@vger.kernel.org, Jeff King <peff@peff.net>,
Kaartic Sivaraam <kaartic.sivaraam@gmail.com>
Subject: Re: [PATCH 0/8] ci: consolidate test variables
Date: Tue, 27 Oct 2026 13:59:57 -0700 [thread overview]
Message-ID: <xmqqzevyhnaq.fsf@gitster.g> (raw)
In-Reply-To: <e1d49985-0ce5-4411-aab7-11d90969363f@gmail.com> (Phillip Wood's message of "Tue, 27 Oct 2026 15:00:48 +0000")
Phillip Wood <phillip.wood123@gmail.com> writes:
> Hi Patrick
>
> On 27/10/2026 08:18, Patrick Steinhardt wrote:
>> Hi,
>>
>> this patch series consolidates our test variables as a follow up on the
>> discussions in [1].
>>
>> The series is built on top of 37b3475fb53 (The 9th batch, 2026-10-25).
>
> I looked at the diff for the whole series rather than the individual
> patches and it looks nice. The changes to move all the job dependent
> variable assignments into ci/lib.sh and the removal of the
> linux-reftable-sha256 job while maintaining our coverage are very
> welcome. It probably makes sense to disable rust for the sanitizer job
> which is aimed at checking our C code, though if we end up with more
> unsafe rust in the future maybe the balance will shift?
>
> Thanks
>
> Phillip
Thanks for writing and reviewing.
next prev parent reply other threads:[~2026-10-27 20:59 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-27 8:18 [PATCH 0/8] ci: consolidate test variables Patrick Steinhardt
2026-10-27 8:18 ` [PATCH 1/8] ci: consolidate setup of test environment Patrick Steinhardt
2026-10-27 8:18 ` [PATCH 2/8] ci/lib: always set GIT_TEST_USE_SET_E on Linux jobs Patrick Steinhardt
2026-10-27 8:18 ` [PATCH 3/8] ci/lib: deduplicate test variables by pattern matching Patrick Steinhardt
2026-10-27 8:18 ` [PATCH 4/8] ci/lib: merge switches for specific job names Patrick Steinhardt
2026-10-27 8:18 ` [PATCH 5/8] t: honor default ref storage format Patrick Steinhardt
2026-10-27 8:18 ` [PATCH 6/8] ci/lib: add another NO_RUST build using glibc Patrick Steinhardt
2026-10-27 8:18 ` [PATCH 7/8] ci: don't override initial branch name in testbed job Patrick Steinhardt
2026-10-27 8:18 ` [PATCH 8/8] t/test-lib: make feature-testbed job more accessible Patrick Steinhardt
2026-10-27 14:53 ` Phillip Wood
2026-10-27 20:59 ` Junio C Hamano
2026-10-28 7:41 ` Patrick Steinhardt
2026-10-27 21:23 ` Jeff King
2026-10-27 21:47 ` Junio C Hamano
2026-10-28 7:39 ` Patrick Steinhardt
2026-10-28 14:33 ` Phillip Wood
2026-10-27 15:00 ` [PATCH 0/8] ci: consolidate test variables Phillip Wood
2026-10-27 20:59 ` Junio C Hamano [this message]
2026-10-27 21:24 ` Jeff King
2026-10-28 14:40 ` Toon Claes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqzevyhnaq.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=kaartic.sivaraam@gmail.com \
--cc=peff@peff.net \
--cc=phillip.wood123@gmail.com \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.