From: Antonio Argenziano <antonio.argenziano@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] i915/gem_exec_basic: Drop per-engine testing of *execbuf
Date: Mon, 3 Feb 2020 14:37:40 -0800 [thread overview]
Message-ID: <61c41fec-e783-35bf-17e6-98f5048543a8@intel.com> (raw)
In-Reply-To: <158076833186.27392.1232173407287492916@skylake-alporthouse-com>
On 03/02/20 14:18, Chris Wilson wrote:
> Quoting Antonio Argenziano (2020-02-03 22:15:26)
>>
>>
>> On 03/02/20 13:45, Chris Wilson wrote:
>>> @@ -121,30 +43,29 @@ igt_main
>>>
>>> igt_fixture {
>>> fd = drm_open_driver(DRIVER_INTEL);
>>> - igt_require_gem(fd);
>>> -
>>> + /* igt_require_gem(fd); // test is mandatory */
>>
>> What if that fd is bad? Assert?
>
> fd can't be bad, that's taken care of by drm_open_driver(). If the
> driver is unusable for execbuf, we want the test failure. It's a choice.
>
> Not sure the right answer, both have advantages.
Fair enough.
>
>>> +static void mmapped(int i915)
>>> +{
>>> + struct drm_i915_gem_execbuffer2 *execbuf;
>>> + struct drm_i915_gem_exec_object2 *exec;
>>> + uint32_t handle;
>>
>> gem_require_mappable_ggtt()?
>
> No... I was dropping a hint in the name. How's the toolbox?
I'm afraid I'm not the right person to develop new stuff for IGT...
gem_require_mappable_ggtt() /* insert comment about extending the test
*/? :)
Antonio
> -Chris
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
WARNING: multiple messages have this Message-ID (diff)
From: Antonio Argenziano <antonio.argenziano@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH i-g-t] i915/gem_exec_basic: Drop per-engine testing of *execbuf
Date: Mon, 3 Feb 2020 14:37:40 -0800 [thread overview]
Message-ID: <61c41fec-e783-35bf-17e6-98f5048543a8@intel.com> (raw)
In-Reply-To: <158076833186.27392.1232173407287492916@skylake-alporthouse-com>
On 03/02/20 14:18, Chris Wilson wrote:
> Quoting Antonio Argenziano (2020-02-03 22:15:26)
>>
>>
>> On 03/02/20 13:45, Chris Wilson wrote:
>>> @@ -121,30 +43,29 @@ igt_main
>>>
>>> igt_fixture {
>>> fd = drm_open_driver(DRIVER_INTEL);
>>> - igt_require_gem(fd);
>>> -
>>> + /* igt_require_gem(fd); // test is mandatory */
>>
>> What if that fd is bad? Assert?
>
> fd can't be bad, that's taken care of by drm_open_driver(). If the
> driver is unusable for execbuf, we want the test failure. It's a choice.
>
> Not sure the right answer, both have advantages.
Fair enough.
>
>>> +static void mmapped(int i915)
>>> +{
>>> + struct drm_i915_gem_execbuffer2 *execbuf;
>>> + struct drm_i915_gem_exec_object2 *exec;
>>> + uint32_t handle;
>>
>> gem_require_mappable_ggtt()?
>
> No... I was dropping a hint in the name. How's the toolbox?
I'm afraid I'm not the right person to develop new stuff for IGT...
gem_require_mappable_ggtt() /* insert comment about extending the test
*/? :)
Antonio
> -Chris
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-02-03 22:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-03 21:45 [Intel-gfx] [PATCH i-g-t] i915/gem_exec_basic: Drop per-engine testing of *execbuf Chris Wilson
2020-02-03 22:15 ` [igt-dev] " Antonio Argenziano
2020-02-03 22:15 ` [Intel-gfx] " Antonio Argenziano
2020-02-03 22:18 ` [igt-dev] " Chris Wilson
2020-02-03 22:18 ` [Intel-gfx] " Chris Wilson
2020-02-03 22:37 ` Antonio Argenziano [this message]
2020-02-03 22:37 ` Antonio Argenziano
2020-02-03 22:45 ` [igt-dev] " Antonio Argenziano
2020-02-03 22:45 ` [Intel-gfx] " Antonio Argenziano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61c41fec-e783-35bf-17e6-98f5048543a8@intel.com \
--to=antonio.argenziano@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=igt-dev@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.