[PATCH v2] gdbus: Emit InterfacesAdded of parents objects first

[PATCH v2] gdbus: Emit InterfacesAdded of parents objects first

[Luiz Augusto von Dentz]

From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

This makes InterfacesAdded respect the object hierarchy in case its
parent has pending interfaces to be added.

Fixes: https://github.com/bluez/bluez/issues/272
Fixes: https://github.com/bluez/bluez/issues/284
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1534857
Fixes: https://bugs.archlinux.org/task/57464
---
v2: Fix typo chield/child and add links for previously reports of the same
issue.

 gdbus/object.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/gdbus/object.c b/gdbus/object.c
index 50a8b4ff1..f7c8c2be5 100644
--- a/gdbus/object.c
+++ b/gdbus/object.c
@@ -551,6 +551,12 @@ static void emit_interfaces_added(struct generic_data *data)
 	if (root == NULL || data == root)
 		return;
 
+	/* Emit InterfacesAdded on the parent first so it appears first on the
+	 * bus as child objects may point to it.
+	 */
+	if (data->parent && data->parent->added)
+		emit_interfaces_added(data->parent);
+
 	signal = dbus_message_new_signal(root->path,
 					DBUS_INTERFACE_OBJECT_MANAGER,
 					"InterfacesAdded");
-- 
2.34.1

RE: [v2] gdbus: Emit InterfacesAdded of parents objects first

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 995 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=611401

---Test result---

Test Summary:
CheckPatch                    PASS      1.45 seconds
GitLint                       PASS      1.02 seconds
Prep - Setup ELL              PASS      43.52 seconds
Build - Prep                  PASS      0.74 seconds
Build - Configure             PASS      8.75 seconds
Build - Make                  PASS      1440.21 seconds
Make Check                    PASS      12.26 seconds
Make Check w/Valgrind         PASS      451.94 seconds
Make Distcheck                PASS      235.40 seconds
Build w/ext ELL - Configure   PASS      8.75 seconds
Build w/ext ELL - Make        PASS      1436.60 seconds
Incremental Build with patchesPASS      0.00 seconds



---
Regards,
Linux Bluetooth

Re: [v2] gdbus: Emit InterfacesAdded of parents objects first

[Luiz Augusto von Dentz]

Hi,

On Fri, Feb 4, 2022 at 12:43 PM <bluez.test.bot@gmail.com> wrote:
>
> This is automated email and please do not reply to this email!
>
> Dear submitter,
>
> Thank you for submitting the patches to the linux bluetooth mailing list.
> This is a CI test results with your patch series:
> PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=611401
>
> ---Test result---
>
> Test Summary:
> CheckPatch                    PASS      1.45 seconds
> GitLint                       PASS      1.02 seconds
> Prep - Setup ELL              PASS      43.52 seconds
> Build - Prep                  PASS      0.74 seconds
> Build - Configure             PASS      8.75 seconds
> Build - Make                  PASS      1440.21 seconds
> Make Check                    PASS      12.26 seconds
> Make Check w/Valgrind         PASS      451.94 seconds
> Make Distcheck                PASS      235.40 seconds
> Build w/ext ELL - Configure   PASS      8.75 seconds
> Build w/ext ELL - Make        PASS      1436.60 seconds
> Incremental Build with patchesPASS      0.00 seconds
>
>
>
> ---
> Regards,
> Linux Bluetooth

Pushed.

-- 
Luiz Augusto von Dentz