All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Bluetooth: make array bt_uuid_any static const
@ 2022-02-14 21:51 Colin Ian King
  2022-02-14 23:01 ` bluez.test.bot
  2022-02-16 10:28 ` [PATCH] " Marcel Holtmann
  0 siblings, 2 replies; 3+ messages in thread
From: Colin Ian King @ 2022-02-14 21:51 UTC (permalink / raw)
  To: Marcel Holtmann, Johan Hedberg, David S . Miller, Jakub Kicinski,
	linux-bluetooth, netdev
  Cc: kernel-janitors, linux-kernel

Don't populate the read-only array bt_uuid_any on the stack but
instead make it static const. Also makes the object code a little
smaller.

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
 net/bluetooth/mgmt.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c
index 914e2f2d3586..4b15b95e61e6 100644
--- a/net/bluetooth/mgmt.c
+++ b/net/bluetooth/mgmt.c
@@ -2269,7 +2269,9 @@ static int remove_uuid(struct sock *sk, struct hci_dev *hdev, void *data,
 	struct mgmt_cp_remove_uuid *cp = data;
 	struct mgmt_pending_cmd *cmd;
 	struct bt_uuid *match, *tmp;
-	u8 bt_uuid_any[] = { 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0 };
+	static const u8 bt_uuid_any[] = {
+		0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0
+	};
 	int err, found;
 
 	bt_dev_dbg(hdev, "sock %p", sk);
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* RE: Bluetooth: make array bt_uuid_any static const
  2022-02-14 21:51 [PATCH] Bluetooth: make array bt_uuid_any static const Colin Ian King
@ 2022-02-14 23:01 ` bluez.test.bot
  2022-02-16 10:28 ` [PATCH] " Marcel Holtmann
  1 sibling, 0 replies; 3+ messages in thread
From: bluez.test.bot @ 2022-02-14 23:01 UTC (permalink / raw)
  To: linux-bluetooth, colin.i.king

[-- Attachment #1: Type: text/plain, Size: 1097 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=614273

---Test result---

Test Summary:
CheckPatch                    PASS      1.72 seconds
GitLint                       PASS      1.00 seconds
SubjectPrefix                 PASS      0.85 seconds
BuildKernel                   PASS      35.83 seconds
BuildKernel32                 PASS      31.55 seconds
Incremental Build with patchesPASS      43.09 seconds
TestRunner: Setup             PASS      551.11 seconds
TestRunner: l2cap-tester      PASS      15.52 seconds
TestRunner: bnep-tester       PASS      7.08 seconds
TestRunner: mgmt-tester       PASS      116.61 seconds
TestRunner: rfcomm-tester     PASS      8.96 seconds
TestRunner: sco-tester        PASS      8.89 seconds
TestRunner: smp-tester        PASS      8.89 seconds
TestRunner: userchan-tester   PASS      7.47 seconds



---
Regards,
Linux Bluetooth


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] Bluetooth: make array bt_uuid_any static const
  2022-02-14 21:51 [PATCH] Bluetooth: make array bt_uuid_any static const Colin Ian King
  2022-02-14 23:01 ` bluez.test.bot
@ 2022-02-16 10:28 ` Marcel Holtmann
  1 sibling, 0 replies; 3+ messages in thread
From: Marcel Holtmann @ 2022-02-16 10:28 UTC (permalink / raw)
  To: Colin Ian King
  Cc: Johan Hedberg, David S. Miller, Jakub Kicinski, linux-bluetooth,
	netdev, kernel-janitors, linux-kernel

Hi Colin,

> Don't populate the read-only array bt_uuid_any on the stack but
> instead make it static const. Also makes the object code a little
> smaller.
> 
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
> net/bluetooth/mgmt.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)

patch has been applied to bluetooth-next tree.

Regards

Marcel


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-02-16 10:29 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-02-14 21:51 [PATCH] Bluetooth: make array bt_uuid_any static const Colin Ian King
2022-02-14 23:01 ` bluez.test.bot
2022-02-16 10:28 ` [PATCH] " Marcel Holtmann

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.