[meta-oe][PATCH v2] libgpiod: RDEPENDS bats, python3-packaging for libgpiod-ptest

[meta-oe][PATCH v2] libgpiod: RDEPENDS bats, python3-packaging for libgpiod-ptest

[Douglas Royds]

When ptest is included in the DISTRO_FEATURES, we were adding bats and
python3-packaging to the libgpiod RDEPENDS, and unwittingly dragging bash and
python3 into the rootfs whether libgpiod-ptest was installed or not.

Add bats and python3-packaging to the RDEPENDS for the libgpiod-ptest package only.

Signed-off-by: Douglas Royds <douglas.royds@taitradio.com>
---
 meta-oe/recipes-support/libgpiod/libgpiod_1.6.3.bb | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/meta-oe/recipes-support/libgpiod/libgpiod_1.6.3.bb b/meta-oe/recipes-support/libgpiod/libgpiod_1.6.3.bb
index 51b74ba5b..c08e38712 100644
--- a/meta-oe/recipes-support/libgpiod/libgpiod_1.6.3.bb
+++ b/meta-oe/recipes-support/libgpiod/libgpiod_1.6.3.bb
@@ -14,7 +14,7 @@ SRC_URI[sha256sum] = "841be9d788f00bab08ef22c4be5c39866f0e46cb100a3ae49ed816ac9c
 
 inherit autotools pkgconfig python3native ptest
 
-PACKAGECONFIG[tests] = "--enable-tests,--disable-tests,kmod udev glib-2.0 catch2,bats python3-packaging"
+PACKAGECONFIG[tests] = "--enable-tests,--disable-tests,kmod udev glib-2.0 catch2"
 PACKAGECONFIG[cxx] = "--enable-bindings-cxx,--disable-bindings-cxx"
 PACKAGECONFIG[python3] = "--enable-bindings-python,--disable-bindings-python,python3"
 
@@ -54,6 +54,7 @@ RRECOMMENDS:${PN}-ptest += " \
     coreutils \
     ${@bb.utils.contains('PACKAGECONFIG', 'python3', 'python3-unittest', '', d)} \
 "
+RDEPENDS:${PN}-ptest += "${@bb.utils.contains('PACKAGECONFIG', 'tests', 'bats python3-packaging', '', d)}"
 
 PACKAGECONFIG:append = " ${@bb.utils.contains('DISTRO_FEATURES', 'ptest', 'tests', '', d)}"
 
-- 
2.32.0


-- 
---------
Tait Communications is changing its domain name from 
@taitradio.com <http://taitradio.com> to @taitcommunications.com 
<http://taitcommunications.com> on 22 February 2022.   Email contacts will 
change, for example jo.smith at taitradio.com <http://taitradio.com> 
becomes jo.smith at taitcommunications.com <http://taitcommunications.com>. 
 Existing email and other name formats using @taitradio will continue to 
work for some time.
----------
Tait Communications ändert seinen 
Domainnamen per 22. Februar 2022 von @taitradio.com <http://taitradio.com> 
in @taitcommunications.com <http://taitcommunications.com>.   Die 
E-Mail-Kontakte werden sich ändern, zum Beispiel wird jo.smith at 
taitradio.com <http://taitradio.com> zu jo.smith at taitcommunications.com 
<http://taitcommunications.com>.  Bestehende E-Mail- und andere 
Namensformate, die @taitradio verwenden, werden noch eine Zeit lang 
funktionieren.
----------
A Tait Communications está mudando efetivamente 
seu domínio de @taitradio.com <http://taitradio.com> para 
@taitcommunications.com <http://taitcommunications.com> em 22 de fevereiro 
de 2022. Todos os nossos endereços de e-mail serão alterados com essa 
mudança, por exemplo joao.silva @ taitradio.com <http://taitradio.com> irá 
virar joao.silva @ taitcommunications.com <http://taitcommunications.com>. 
Os e-mail existentes atualmente cujo domínio é @taitradio ainda continuarão 
funcionando por um determinado período de tempo.
----------
Tait 
Communications cambiará su nombre de dominio de @taitradio.com 
<http://taitradio.com> a @taitcommunications.com 
<http://taitcommunications.com> el 22 de febrero de 2022. Todos los 
contactos de correo electrónico cambiarán, por ejemplo, jo.smith en 
taitradio.com <http://taitradio.com> se convierte en jo.smith en 
taitcommunications.com <http://taitcommunications.com>. Los correos 
electrónicos existentes y otros formatos de nombre que utilizan @taitradio 
todavía seguirán funcionando durante algún tiempo.
----------
Tait 
Communications change son nom de domaine de @taitradio.com 
<http://taitradio.com> à @taitcommunications.com 
<http://taitcommunications.com> le 22 février 2022.   Les contacts par 
courriel changeront, par exemple jo.smith at taitradio.com 
<http://taitradio.com> devient jo.smith at taitcommunications.com 
<http://taitcommunications.com>.  Les adresses électroniques et autres 
formats de noms existants utilisant @taitradio continueront à fonctionner 
pendant un certain temps.
This communication is confidential. We only send 
and receive email on the
basis of the terms set out at 
www.taitradio.com/email_disclaimer 
<http://www.taitradio.com/email_disclaimer>

Re: [meta-oe][PATCH] libgpiod: RRECOMMENDS bats, python3-packaging for libgpiod-ptest

[Douglas Royds]

[-- Attachment #1: Type: text/plain, Size: 4767 bytes --]

I should be adding this to the RDEPENDS:${PN}-ptest, not the RRECOMMENDS.
I'll send another patch ...

On Mon, 21 Feb 2022 at 17:10, Douglas Royds <douglas.royds@taitradio.com>
wrote:

> When ptest is included in the DISTRO_FEATURES, we were adding bats and
> python3-packaging to the libgpiod RDEPENDS, and unwittingly dragging bash
> and
> python3 into the rootfs whether libgpiod-ptest was installed or not.
>
> Add bats and python3-packaging to the RRECOMMENDS for the libgpiod-ptest
> package only.
>
> Signed-off-by: Douglas Royds <douglas.royds@taitradio.com>
> ---
>  meta-oe/recipes-support/libgpiod/libgpiod_1.6.3.bb | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/meta-oe/recipes-support/libgpiod/libgpiod_1.6.3.bb
> b/meta-oe/recipes-support/libgpiod/libgpiod_1.6.3.bb
> index 51b74ba5b..c5323b417 100644
> --- a/meta-oe/recipes-support/libgpiod/libgpiod_1.6.3.bb
> +++ b/meta-oe/recipes-support/libgpiod/libgpiod_1.6.3.bb
> @@ -14,7 +14,7 @@ SRC_URI[sha256sum] =
> "841be9d788f00bab08ef22c4be5c39866f0e46cb100a3ae49ed816ac9c
>
>  inherit autotools pkgconfig python3native ptest
>
> -PACKAGECONFIG[tests] = "--enable-tests,--disable-tests,kmod udev glib-2.0
> catch2,bats python3-packaging"
> +PACKAGECONFIG[tests] = "--enable-tests,--disable-tests,kmod udev glib-2.0
> catch2"
>  PACKAGECONFIG[cxx] = "--enable-bindings-cxx,--disable-bindings-cxx"
>  PACKAGECONFIG[python3] =
> "--enable-bindings-python,--disable-bindings-python,python3"
>
> @@ -53,6 +53,7 @@ RRECOMMENDS:${PN}-ptest += " \
>      kernel-module-gpio-mockup \
>      coreutils \
>      ${@bb.utils.contains('PACKAGECONFIG', 'python3', 'python3-unittest',
> '', d)} \
> +    ${@bb.utils.contains('PACKAGECONFIG', 'tests', 'bats
> python3-packaging', '', d)} \
>  "
>
>  PACKAGECONFIG:append = " ${@bb.utils.contains('DISTRO_FEATURES', 'ptest',
> 'tests', '', d)}"
> --
> 2.32.0
>
>

-- 
---------
Tait Communications is changing its domain name from 
@taitradio.com <http://taitradio.com> to @taitcommunications.com 
<http://taitcommunications.com> on 22 February 2022.   Email contacts will 
change, for example jo.smith at taitradio.com <http://taitradio.com> 
becomes jo.smith at taitcommunications.com <http://taitcommunications.com>. 
 Existing email and other name formats using @taitradio will continue to 
work for some time.
----------
Tait Communications ändert seinen 
Domainnamen per 22. Februar 2022 von @taitradio.com <http://taitradio.com> 
in @taitcommunications.com <http://taitcommunications.com>.   Die 
E-Mail-Kontakte werden sich ändern, zum Beispiel wird jo.smith at 
taitradio.com <http://taitradio.com> zu jo.smith at taitcommunications.com 
<http://taitcommunications.com>.  Bestehende E-Mail- und andere 
Namensformate, die @taitradio verwenden, werden noch eine Zeit lang 
funktionieren.
----------
A Tait Communications está mudando efetivamente 
seu domínio de @taitradio.com <http://taitradio.com> para 
@taitcommunications.com <http://taitcommunications.com> em 22 de fevereiro 
de 2022. Todos os nossos endereços de e-mail serão alterados com essa 
mudança, por exemplo joao.silva @ taitradio.com <http://taitradio.com> irá 
virar joao.silva @ taitcommunications.com <http://taitcommunications.com>. 
Os e-mail existentes atualmente cujo domínio é @taitradio ainda continuarão 
funcionando por um determinado período de tempo.
----------
Tait 
Communications cambiará su nombre de dominio de @taitradio.com 
<http://taitradio.com> a @taitcommunications.com 
<http://taitcommunications.com> el 22 de febrero de 2022. Todos los 
contactos de correo electrónico cambiarán, por ejemplo, jo.smith en 
taitradio.com <http://taitradio.com> se convierte en jo.smith en 
taitcommunications.com <http://taitcommunications.com>. Los correos 
electrónicos existentes y otros formatos de nombre que utilizan @taitradio 
todavía seguirán funcionando durante algún tiempo.
----------
Tait 
Communications change son nom de domaine de @taitradio.com 
<http://taitradio.com> à @taitcommunications.com 
<http://taitcommunications.com> le 22 février 2022.   Les contacts par 
courriel changeront, par exemple jo.smith at taitradio.com 
<http://taitradio.com> devient jo.smith at taitcommunications.com 
<http://taitcommunications.com>.  Les adresses électroniques et autres 
formats de noms existants utilisant @taitradio continueront à fonctionner 
pendant un certain temps.
This communication is confidential. We only send 
and receive email on the
basis of the terms set out at 
www.taitradio.com/email_disclaimer 
<http://www.taitradio.com/email_disclaimer>


[-- Attachment #2: Type: text/html, Size: 6693 bytes --]

Re: [oe] [meta-oe][PATCH] libgpiod: RRECOMMENDS bats, python3-packaging for libgpiod-ptest

[Douglas Royds]

[-- Attachment #1: Type: text/plain, Size: 415 bytes --]

On 22/02/22 3:37 pm, Khem Raj wrote:
> On 2/21/22 12:26 PM, Douglas via lists.openembedded.org wrote:
>> I should be adding this to the RDEPENDS:${PN}-ptest, not the 
>> RRECOMMENDS. I'll send another patch ...
>>
>
> OK thanks. I will wait for v2


Did you see this one? It doesn't seem to have made it into master-next ...

    https://www.mail-archive.com/openembedded-devel@lists.openembedded.org/msg81249.html

[-- Attachment #2: Type: text/html, Size: 1032 bytes --]

Re: [oe] [meta-oe][PATCH] libgpiod: RRECOMMENDS bats, python3-packaging for libgpiod-ptest

[Khem Raj]

On 2/24/22 12:23 PM, Douglas Royds wrote:
> On 22/02/22 3:37 pm, Khem Raj wrote:
>> On 2/21/22 12:26 PM, Douglas via lists.openembedded.org wrote:
>>> I should be adding this to the RDEPENDS:${PN}-ptest, not the 
>>> RRECOMMENDS. I'll send another patch ...
>>>
>>
>> OK thanks. I will wait for v2
> 
> 
> Did you see this one? It doesn't seem to have made it into master-next ...
> 
>     https://www.mail-archive.com/openembedded-devel@lists.openembedded.org/msg81249.html
> 

Can you send a v3, it is not captured by lore or patchwork.