From: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
To: Enric Balletbo i Serra
<enric.balletbo-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
Cc: Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Catalin Marinas <catalin.marinas-5wv7dgnIgG8@public.gmane.org>,
Chris Zhong <zyw-TNX95d0MmH7DzftRWevZcw@public.gmane.org>,
Brian Norris
<briannorris-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
groeck-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org
Subject: Re: [PATCH 2/3] arm64: dts: rockchip: add cdn-dp node for rk3399.
Date: Sat, 10 Feb 2018 17:16:45 +0100 [thread overview]
Message-ID: <6229682.fDmaELEjz4@phil> (raw)
In-Reply-To: <20180207163150.16332-2-enric.balletbo-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
Hi Enric,
Am Mittwoch, 7. Februar 2018, 17:31:49 CET schrieb Enric Balletbo i Serra:
> From: Chris Zhong <zyw-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
>
> Add a node for the cdn DP controller which is embedded in the rk3399
> SoC.
>
> Signed-off-by: Chris Zhong <zyw-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
> ---
> arch/arm64/boot/dts/rockchip/rk3399.dtsi | 50 ++++++++++++++++++++++++++++++++
It looks like there is no binding document at all for cdn-dp? At least
I couldn't find one and the original series also didn't seem to include one.
And while I don't see anything problematic right with the used properties
right now, I'd think we should really have a binding and give dt-maintainers
a chance to complain, before adding devicetree nodes based on it.
I'd guess a mostly usable binding doc should already sit in the chromeos
tree, which you could base a v2 of this series on?
Thanks
Heiko
WARNING: multiple messages have this Message-ID (diff)
From: Heiko Stuebner <heiko@sntech.de>
To: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
Brian Norris <briannorris@chromium.org>,
groeck@chromium.org, devicetree@vger.kernel.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
Chris Zhong <zyw@rock-chips.com>
Subject: Re: [PATCH 2/3] arm64: dts: rockchip: add cdn-dp node for rk3399.
Date: Sat, 10 Feb 2018 17:16:45 +0100 [thread overview]
Message-ID: <6229682.fDmaELEjz4@phil> (raw)
In-Reply-To: <20180207163150.16332-2-enric.balletbo@collabora.com>
Hi Enric,
Am Mittwoch, 7. Februar 2018, 17:31:49 CET schrieb Enric Balletbo i Serra:
> From: Chris Zhong <zyw@rock-chips.com>
>
> Add a node for the cdn DP controller which is embedded in the rk3399
> SoC.
>
> Signed-off-by: Chris Zhong <zyw@rock-chips.com>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> ---
> arch/arm64/boot/dts/rockchip/rk3399.dtsi | 50 ++++++++++++++++++++++++++++++++
It looks like there is no binding document at all for cdn-dp? At least
I couldn't find one and the original series also didn't seem to include one.
And while I don't see anything problematic right with the used properties
right now, I'd think we should really have a binding and give dt-maintainers
a chance to complain, before adding devicetree nodes based on it.
I'd guess a mostly usable binding doc should already sit in the chromeos
tree, which you could base a v2 of this series on?
Thanks
Heiko
next prev parent reply other threads:[~2018-02-10 16:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-07 16:31 [PATCH 1/3] arm64: dts: rockchip: introduce pclk_vio_grf in eDP device node Enric Balletbo i Serra
[not found] ` <20180207163150.16332-1-enric.balletbo-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
2018-02-07 16:31 ` [PATCH 2/3] arm64: dts: rockchip: add cdn-dp node for rk3399 Enric Balletbo i Serra
2018-02-07 16:31 ` Enric Balletbo i Serra
[not found] ` <20180207163150.16332-2-enric.balletbo-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
2018-02-10 16:16 ` Heiko Stuebner [this message]
2018-02-10 16:16 ` Heiko Stuebner
2018-02-13 10:42 ` Enric Balletbo i Serra
2018-02-13 10:42 ` Enric Balletbo i Serra
2018-02-13 11:36 ` Enric Balletbo Serra
2018-02-13 11:52 ` Heiko Stübner
2018-02-07 16:31 ` [PATCH 3/3] arm64: dts: rockchip: enable DP for gru Enric Balletbo i Serra
2018-02-07 16:31 ` Enric Balletbo i Serra
2018-02-09 9:45 ` [PATCH 1/3] arm64: dts: rockchip: introduce pclk_vio_grf in eDP device node Heiko Stuebner
2018-02-09 9:45 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6229682.fDmaELEjz4@phil \
--to=heiko-4mtyjxux2i+zqb+pc5nmwq@public.gmane.org \
--cc=briannorris-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
--cc=catalin.marinas-5wv7dgnIgG8@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=enric.balletbo-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org \
--cc=groeck-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=will.deacon-5wv7dgnIgG8@public.gmane.org \
--cc=zyw-TNX95d0MmH7DzftRWevZcw@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.