From: John Fastabend <john.fastabend@gmail.com>
To: kkourt@kkourt.io, Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: dwarves@vger.kernel.org, bpf@vger.kernel.org,
linux-kernel@vger.kernel.org,
Kornilios Kourtis <kornilios@isovalent.com>
Subject: RE: [PATCH 2/2] dwarves: cus__load_files: set errno if load fails
Date: Wed, 16 Mar 2022 22:00:57 -0700 [thread overview]
Message-ID: <6232c089bbaf2_487f208db@john.notmuch> (raw)
In-Reply-To: <20220316132354.3226908-1-kkourt@kkourt.io>
kkourt@ wrote:
> From: Kornilios Kourtis <kornilios@isovalent.com>
>
> This patch improves the error seen by the user by setting errno in
> cus__load_files(). Otherwise, we get a "No such file or directory" error
> which might be confusing.
>
> Before the patch, using a bogus file:
> $ ./pahole -J ./vmlinux-5.3.18-24.102-default.debug
> pahole: ./vmlinux-5.3.18-24.102-default.debug: No such file or directory
> $ ls ./vmlinux-5.3.18-24.102-default.debug
> /home/kkourt/src/hubble-fgs/vmlinux-5.3.18-24.102-default.debug
>
> After the patch:
> $ ./pahole -J ./vmlinux-5.3.18-24.102-default.debug
> pahole: ./vmlinux-5.3.18-24.102-default.debug: Unknown error -22
>
> Which is not very helpful, but less confusing.
>
> Signed-off-by: Kornilios Kourtis <kornilios@isovalent.com>
> ---
With the err to -err fix Arnaldo proposed.
Acked-by: John Fastabend <john.fastabend@gmail.com>
next prev parent reply other threads:[~2022-03-17 5:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-04 11:38 [PATCH] pahole: avoid segfault when parsing a problematic file kkourt
2022-03-05 18:49 ` Arnaldo Carvalho de Melo
2022-03-16 13:16 ` Kornilios Kourtis
2022-03-16 13:23 ` [PATCH 1/2] pahole: avoid segfault when parsing bogus file kkourt
2022-03-17 4:59 ` John Fastabend
2022-03-16 13:23 ` [PATCH 2/2] dwarves: cus__load_files: set errno if load fails kkourt
2022-03-16 20:51 ` Arnaldo Carvalho de Melo
2022-03-16 20:55 ` Kornilios Kourtis
2022-03-17 5:00 ` John Fastabend [this message]
2022-03-17 15:19 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6232c089bbaf2_487f208db@john.notmuch \
--to=john.fastabend@gmail.com \
--cc=acme@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=dwarves@vger.kernel.org \
--cc=kkourt@kkourt.io \
--cc=kornilios@isovalent.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.