From: Kornilios Kourtis <kkourt@kkourt.io>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: dwarves@vger.kernel.org, bpf@vger.kernel.org,
linux-kernel@vger.kernel.org,
Kornilios Kourtis <kornilios@isovalent.com>
Subject: Re: [PATCH] pahole: avoid segfault when parsing a problematic file
Date: Wed, 16 Mar 2022 14:16:30 +0100 [thread overview]
Message-ID: <YjHjLkYBk/XfXSK0@tinh> (raw)
In-Reply-To: <YiOw06rlBwdw2uYx@kernel.org>
Hi Arnaldo,
Apologies for the delayed reply.
On Sat, Mar 05, 2022 at 03:49:55PM -0300, Arnaldo Carvalho de Melo wrote:
> Can you break this into two patches, one for checking dwfl_getmodules()
> failure and the second setting errno?
>
> We should try to avoid these patches that do multiple fixes, as
> sometimes one of the fixes isn't really correct and we end up not being
> able to use 'git revert' which should be the case when we figure out
> that some previous fix wasn't correct.
Yap, makes perfect sense. I will reply to this email with the two patches
momentarily.
--
Kornilios Kourtis.
next prev parent reply other threads:[~2022-03-16 13:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-04 11:38 [PATCH] pahole: avoid segfault when parsing a problematic file kkourt
2022-03-05 18:49 ` Arnaldo Carvalho de Melo
2022-03-16 13:16 ` Kornilios Kourtis [this message]
2022-03-16 13:23 ` [PATCH 1/2] pahole: avoid segfault when parsing bogus file kkourt
2022-03-17 4:59 ` John Fastabend
2022-03-16 13:23 ` [PATCH 2/2] dwarves: cus__load_files: set errno if load fails kkourt
2022-03-16 20:51 ` Arnaldo Carvalho de Melo
2022-03-16 20:55 ` Kornilios Kourtis
2022-03-17 5:00 ` John Fastabend
2022-03-17 15:19 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YjHjLkYBk/XfXSK0@tinh \
--to=kkourt@kkourt.io \
--cc=acme@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=dwarves@vger.kernel.org \
--cc=kornilios@isovalent.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.