All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Damjan Marion (damarion)" <damarion@cisco.com>
Cc: dev@dpdk.org, Jan Viktorin <viktorin@rehivetech.com>,
	Bruce Richardson <bruce.richardson@intel.com>,
	Konstantin Ananyev <konstantin.ananyev@intel.com>,
	David Marchand <david.marchand@6wind.com>
Subject: Re: spinlock: Move constructor function out of header file
Date: Fri, 15 Jul 2016 10:31:49 +0200	[thread overview]
Message-ID: <6282391.Mg1yxlkp5v@xps13> (raw)
In-Reply-To: <A8DE54E9-B995-491B-AFA3-CE6792E242BE@cisco.com>

2016-07-14 22:20, Damjan Marion:
> 
> > On 15 Jul 2016, at 00:06, Thomas Monjalon <thomas.monjalon@6wind.com> wrote:
> > 
> > 2016-07-14 18:10, Damjan Marion:
> >> Dear Jan,
> >> 
> >> Thank you for your comments. A bit too much overhead to submit simple patch
> >> so let’s forget about it. I will just add it as it is to our private
> >> collection of patches.
> > 
> > These are changes trivial to fix when applying.
> > I strongly prefer that you upstream patches instead of keeping patches
> > in the VPP repository. I will help you in this task.
> > Thanks for the effort.
> 
> Yeah, I agree with you, unfortunately it is all about time,
> for me it is still cheaper to rebase them.
> 
> I respect your rules, but I just don’t have enough free cycles
> to spend learning all of them, for my occasional patch submission.

We know there is a learning curve for the submission process.
That's why we do not expect it to be fully satisfied, especially
from occasional contributors.
I am used to do some not significant changes before applying to
help newcomers patches being accepted. That's what I will do in
your case.
As I said previously I will help you to drop your local patches.

Please continue sending other patches with a detailed explanation
and we will take care of them.

  reply	other threads:[~2016-07-15  8:31 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-14 13:27 [PATCH] spinlock: Move constructor function out of header file damarion
2016-07-14 18:03 ` Jan Viktorin
2016-07-14 18:10   ` Damjan Marion (damarion)
2016-07-14 22:06     ` Thomas Monjalon
2016-07-14 22:20       ` Damjan Marion (damarion)
2016-07-15  8:31         ` Thomas Monjalon [this message]
2016-07-15  9:54           ` Damjan Marion (damarion)
2016-07-15 10:09             ` Thomas Monjalon
2016-07-16 11:12               ` Damjan Marion (damarion)
2016-07-15 14:37   ` Thomas Monjalon
2016-07-15 15:08     ` Thomas Monjalon
2016-07-16 11:14       ` Damjan Marion (damarion)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6282391.Mg1yxlkp5v@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=bruce.richardson@intel.com \
    --cc=damarion@cisco.com \
    --cc=david.marchand@6wind.com \
    --cc=dev@dpdk.org \
    --cc=konstantin.ananyev@intel.com \
    --cc=viktorin@rehivetech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.