Re: [PATCH v3 07/14] migration: Make switchover-ack re-usable

[Avihai Horon <avihaih@nvidia.com>]

On 6/18/2026 11:38 AM, Cédric Le Goater wrote:
> External email: Use caution opening links or attachments
>
>
>>>>>> diff --git a/hw/core/machine.c b/hw/core/machine.c
>>>>>> index 4d8b15d99e..8219f13779 100644
>>>>>> --- a/hw/core/machine.c
>>>>>> +++ b/hw/core/machine.c
>>>>>> @@ -43,6 +43,7 @@ GlobalProperty hw_compat_11_0[] = {
>>>>>>        { "chardev-vc", "encoding", "cp437" },
>>>>>>        { "tpm-crb", "cap-chunk", "off" },
>>>>>>        { "tpm-crb", "x-allow-chunk-migration", "off" },
>>>>>> +    { "migration", "switchover-ack-legacy", "on" },
>>>>>>    };
>>>>> This line needs to be moved to the last patch, or people will get 
>>>>> very
>>>>> confused on last patch flipping default without caring about old 
>>>>> behavior..
>>>> This patch Implements the compatibility flows for legacy 
>>>> switchover-ack
>>>> which use this property, so moving this line to last patch sounds 
>>>> even more
>>>> confusing IMHO.
>>> My comment only applies to this one line to change hw_compat_11_0[], 
>>> not
>>> the property itself.  It won't affect this patch.  It's common 
>>> pattern to
>>> do this in one patch to "update default value, but let's keep the old
>>> machines unaffected".
>>>
>>> Btw, since this value still has a default value ON in this patch, 
>>> moving
>>> this line to the last patch won't change anything except making last 
>>> patch
>>> clearer.
>>
>> Alright, I'll move it to last patch.
>>
>> Cedric, would you like me to send v4 for this?
>
> Yes please.
>
> I think this series is ready for merge. So I have asked our QE
> to test it a bit. Should be done next week. Once done, I will
> send a vfio MR.

Thanks, Cedric. I will send v4 shortly.