All of lore.kernel.org
 help / color / mirror / Atom feed
From: tamizhr@codeaurora.org
To: Rob Herring <robh@kernel.org>
Cc: devicetree@vger.kernel.org, linux-wireless@vger.kernel.org,
	ath10k@lists.infradead.org
Subject: Re: [PATCH 1/2] dt-bindings: ath10k: Add new dt entries to identify coex support
Date: Mon, 30 Dec 2019 10:37:16 +0530	[thread overview]
Message-ID: <62b9e7b140a96401469f7075811d0d67@codeaurora.org> (raw)
In-Reply-To: <20191226185132.GA31120@bogus>

Hi Rob,

Thanks for your review comments.

>> This adds new dt entries qcom,coexist-support and 
>> qcom,coexist-gpio-pin
>> which will be used by ath10k driver to identify coex support
>> of a hardware and notify wifi firmware the gpio pin number.
>> This pin number information is needed for the hardware QCA4019.
>> 
>> Signed-off-by: Tamizh Chelvam <tamizhr@codeaurora.org>
>> ---
>>  Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt | 6 
>> ++++++
>>  1 file changed, 6 insertions(+)
>> 
>> diff --git 
>> a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt 
>> b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
>> index 0171283..a41e936 100644
>> --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
>> +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
>> @@ -87,6 +87,10 @@ Optional properties:
>>  	Definition: Quirk specifying that the firmware expects the 8bit 
>> version
>>  		    of the host capability QMI request
>>  - qcom,xo-cal-data: xo cal offset to be configured in xo trim 
>> register.
>> +- qcom,coexist-support : should contain eithr "0" or "1" to indicate 
>> coex
>> +			 support by the hardware.
>> +- qcom,coexist-gpio-pin : gpio pin number  information to support 
>> coex
>> +			  which will be used by wifi firmware.
> 
> What combinations of these 2 properties are valid?
> 
> Is qcom,coexist-gpio-pin required for coexist support? If so then it
> alone should be enough to enable/disable coexist.
> 
qcom,coexist-gpio-pin is required for QCA4019 devices. And other ath10k 
devices doesn't required that value.
So only added two fields to enable/disable coexist and another for 
notifying the gpio pin info.
>> 
>>  Example (to supply PCI based wifi block details):
>> 
>> @@ -156,6 +160,8 @@ wifi0: wifi@a000000 {
>>  	qcom,msi_addr = <0x0b006040>;
>>  	qcom,msi_base = <0x40>;
>>  	qcom,ath10k-pre-calibration-data = [ 01 02 03 ... ];
>> +	qcom,coexist-support = <1>;
>> +	qcom,coexist-gpio-pin = <0x33>;
>>  };
>> 
>>  Example (to supply wcn3990 SoC wifi block details):
>> --

Thanks,
Tamizh.

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

WARNING: multiple messages have this Message-ID (diff)
From: tamizhr@codeaurora.org
To: Rob Herring <robh@kernel.org>
Cc: ath10k@lists.infradead.org, devicetree@vger.kernel.org,
	linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: ath10k: Add new dt entries to identify coex support
Date: Mon, 30 Dec 2019 10:37:16 +0530	[thread overview]
Message-ID: <62b9e7b140a96401469f7075811d0d67@codeaurora.org> (raw)
In-Reply-To: <20191226185132.GA31120@bogus>

Hi Rob,

Thanks for your review comments.

>> This adds new dt entries qcom,coexist-support and 
>> qcom,coexist-gpio-pin
>> which will be used by ath10k driver to identify coex support
>> of a hardware and notify wifi firmware the gpio pin number.
>> This pin number information is needed for the hardware QCA4019.
>> 
>> Signed-off-by: Tamizh Chelvam <tamizhr@codeaurora.org>
>> ---
>>  Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt | 6 
>> ++++++
>>  1 file changed, 6 insertions(+)
>> 
>> diff --git 
>> a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt 
>> b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
>> index 0171283..a41e936 100644
>> --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
>> +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
>> @@ -87,6 +87,10 @@ Optional properties:
>>  	Definition: Quirk specifying that the firmware expects the 8bit 
>> version
>>  		    of the host capability QMI request
>>  - qcom,xo-cal-data: xo cal offset to be configured in xo trim 
>> register.
>> +- qcom,coexist-support : should contain eithr "0" or "1" to indicate 
>> coex
>> +			 support by the hardware.
>> +- qcom,coexist-gpio-pin : gpio pin number  information to support 
>> coex
>> +			  which will be used by wifi firmware.
> 
> What combinations of these 2 properties are valid?
> 
> Is qcom,coexist-gpio-pin required for coexist support? If so then it
> alone should be enough to enable/disable coexist.
> 
qcom,coexist-gpio-pin is required for QCA4019 devices. And other ath10k 
devices doesn't required that value.
So only added two fields to enable/disable coexist and another for 
notifying the gpio pin info.
>> 
>>  Example (to supply PCI based wifi block details):
>> 
>> @@ -156,6 +160,8 @@ wifi0: wifi@a000000 {
>>  	qcom,msi_addr = <0x0b006040>;
>>  	qcom,msi_base = <0x40>;
>>  	qcom,ath10k-pre-calibration-data = [ 01 02 03 ... ];
>> +	qcom,coexist-support = <1>;
>> +	qcom,coexist-gpio-pin = <0x33>;
>>  };
>> 
>>  Example (to supply wcn3990 SoC wifi block details):
>> --

Thanks,
Tamizh.

  reply	other threads:[~2019-12-30  5:07 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-16 11:40 [PATCH 1/2] dt-bindings: ath10k: Add new dt entries to identify coex support Tamizh Chelvam
2019-12-16 11:40 ` Tamizh Chelvam
2019-12-16 11:40 ` [PATCH 2/2] ath10k: Add support to read btcoex related data from DT Tamizh Chelvam
2019-12-16 11:40   ` Tamizh Chelvam
2019-12-26 18:51 ` [PATCH 1/2] dt-bindings: ath10k: Add new dt entries to identify coex support Rob Herring
2019-12-26 18:51   ` Rob Herring
2019-12-30  5:07   ` tamizhr [this message]
2019-12-30  5:07     ` tamizhr
2019-12-30 18:02     ` Rob Herring
2019-12-30 18:02       ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=62b9e7b140a96401469f7075811d0d67@codeaurora.org \
    --to=tamizhr@codeaurora.org \
    --cc=ath10k@lists.infradead.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.