From: Christian Marangi <ansuelsmth@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jens Axboe <axboe@kernel.dk>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [net-next PATCH] net: dsa: qca8k: move driver to qca dir
Date: Fri, 15 Jul 2022 03:57:46 +0200 [thread overview]
Message-ID: <62d12418.1c69fb81.90737.3a8e@mx.google.com> (raw)
In-Reply-To: <20220714220354.795c8992@kernel.org>
On Thu, Jul 14, 2022 at 10:03:54PM -0700, Jakub Kicinski wrote:
> On Wed, 13 Jul 2022 22:53:50 +0200 Christian Marangi wrote:
> > This is a start for the required changes for code
> > split. Greg wasn't so negative about this kind of change
> > so I think we can finally make the move.
> >
> > Still waiting some comments about the code split.
> > (Can I split qca8k to common function that will be
> > used by ipq4019? (and later propose the actual
> > ipq4019 driver?))
>
> Does the split mean that this code will move again?
> If so perhaps better to put this patch in the series
> that does the split? We're ~2 weeks away from the merge
> window so we don't want to end up moving the same code
> twice in two consecutive releases.
What to you mean with "will move again"?
The code will be split to qca8k-common.c and qca8k-8xxx.c
And later qca8k-ipq4019.c will be proposed.
So the files will all stay in qca/ dir.
Or should I just propose the move and the code split in one series?
Tell me what do you prefer.
--
Ansuel
next prev parent reply other threads:[~2022-07-15 8:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-13 20:53 [net-next PATCH] net: dsa: qca8k: move driver to qca dir Christian Marangi
2022-07-13 21:02 ` Florian Fainelli
2022-07-15 5:03 ` Jakub Kicinski
2022-07-15 1:57 ` Christian Marangi [this message]
2022-07-15 19:37 ` Jakub Kicinski
2022-07-15 19:16 ` Christian Marangi
2022-07-15 19:47 ` Jakub Kicinski
2022-07-15 19:25 ` Christian Marangi
2022-07-15 11:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=62d12418.1c69fb81.90737.3a8e@mx.google.com \
--to=ansuelsmth@gmail.com \
--cc=andrew@lunn.ch \
--cc=axboe@kernel.dk \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.