* [PATCH] bluetooth/btbcm: Remove goto in btbcm_patchram function
@ 2022-08-23 3:41 Zhou jie
2022-08-23 5:25 ` bluez.test.bot
0 siblings, 1 reply; 2+ messages in thread
From: Zhou jie @ 2022-08-23 3:41 UTC (permalink / raw)
To: marcel, johan.hedberg, luiz.dentz; +Cc: linux-bluetooth, linux-kernel, Zhou jie
Remove the goto statement in the btbcm_patchram function to optimize
program execution efficiency.
Signed-off-by: Zhou jie <zhoujie@nfschina.com>
---
drivers/bluetooth/btbcm.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/bluetooth/btbcm.c b/drivers/bluetooth/btbcm.c
index d9ceca7a7935..60827593ba36 100644
--- a/drivers/bluetooth/btbcm.c
+++ b/drivers/bluetooth/btbcm.c
@@ -175,7 +175,7 @@ int btbcm_patchram(struct hci_dev *hdev, const struct firmware *fw)
err = PTR_ERR(skb);
bt_dev_err(hdev, "BCM: Download Minidrv command failed (%d)",
err);
- goto done;
+ return err;
}
kfree_skb(skb);
@@ -194,8 +194,7 @@ int btbcm_patchram(struct hci_dev *hdev, const struct firmware *fw)
if (fw_size < cmd->plen) {
bt_dev_err(hdev, "BCM: Patch is corrupted");
- err = -EINVAL;
- goto done;
+ return -EINVAL;
}
cmd_param = fw_ptr;
@@ -210,7 +209,7 @@ int btbcm_patchram(struct hci_dev *hdev, const struct firmware *fw)
err = PTR_ERR(skb);
bt_dev_err(hdev, "BCM: Patch command %04x failed (%d)",
opcode, err);
- goto done;
+ return err;
}
kfree_skb(skb);
}
@@ -218,7 +217,6 @@ int btbcm_patchram(struct hci_dev *hdev, const struct firmware *fw)
/* 250 msec delay after Launch Ram completes */
msleep(250);
-done:
return err;
}
EXPORT_SYMBOL(btbcm_patchram);
--
2.18.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-08-23 5:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-08-23 3:41 [PATCH] bluetooth/btbcm: Remove goto in btbcm_patchram function Zhou jie
2022-08-23 5:25 ` bluez.test.bot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.