* [PATCH] Bluetooth: btusb: Add more device IDs for WCN6855
@ 2022-09-18 6:38 Shengyu Qu
2022-09-18 6:52 ` Paul Menzel
2022-09-18 7:15 ` bluez.test.bot
0 siblings, 2 replies; 5+ messages in thread
From: Shengyu Qu @ 2022-09-18 6:38 UTC (permalink / raw)
To: linux-bluetooth; +Cc: Shengyu Qu
Add IDs to usb_device_id table for WCN6855.
IDs are extracted from Windows driver of Lenovo
Thinkpad T14 Gen 2.
Signed-off-by: Shengyu Qu <wiagn233@outlook.com>
---
drivers/bluetooth/btusb.c | 84 +++++++++++++++++++++++++++++++++++++++
1 file changed, 84 insertions(+)
diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
index 15caa6469538..adf68affaead 100644
--- a/drivers/bluetooth/btusb.c
+++ b/drivers/bluetooth/btusb.c
@@ -316,6 +316,90 @@ static const struct usb_device_id blacklist_table[] = {
{ USB_DEVICE(0x0489, 0xe0d0), .driver_info = BTUSB_QCA_WCN6855 |
BTUSB_WIDEBAND_SPEECH |
BTUSB_VALID_LE_STATES },
+ { USB_DEVICE(0x10ab, 0x9108), .driver_info = BTUSB_QCA_WCN6855 |
+ BTUSB_WIDEBAND_SPEECH |
+ BTUSB_VALID_LE_STATES },
+ { USB_DEVICE(0x10ab, 0x9109), .driver_info = BTUSB_QCA_WCN6855 |
+ BTUSB_WIDEBAND_SPEECH |
+ BTUSB_VALID_LE_STATES },
+ { USB_DEVICE(0x10ab, 0x9208), .driver_info = BTUSB_QCA_WCN6855 |
+ BTUSB_WIDEBAND_SPEECH |
+ BTUSB_VALID_LE_STATES },
+ { USB_DEVICE(0x10ab, 0x9209), .driver_info = BTUSB_QCA_WCN6855 |
+ BTUSB_WIDEBAND_SPEECH |
+ BTUSB_VALID_LE_STATES },
+ { USB_DEVICE(0x10ab, 0x9308), .driver_info = BTUSB_QCA_WCN6855 |
+ BTUSB_WIDEBAND_SPEECH |
+ BTUSB_VALID_LE_STATES },
+ { USB_DEVICE(0x10ab, 0x9408), .driver_info = BTUSB_QCA_WCN6855 |
+ BTUSB_WIDEBAND_SPEECH |
+ BTUSB_VALID_LE_STATES },
+ { USB_DEVICE(0x10ab, 0x9508), .driver_info = BTUSB_QCA_WCN6855 |
+ BTUSB_WIDEBAND_SPEECH |
+ BTUSB_VALID_LE_STATES },
+ { USB_DEVICE(0x10ab, 0x9509), .driver_info = BTUSB_QCA_WCN6855 |
+ BTUSB_WIDEBAND_SPEECH |
+ BTUSB_VALID_LE_STATES },
+ { USB_DEVICE(0x10ab, 0x9608), .driver_info = BTUSB_QCA_WCN6855 |
+ BTUSB_WIDEBAND_SPEECH |
+ BTUSB_VALID_LE_STATES },
+ { USB_DEVICE(0x10ab, 0x9609), .driver_info = BTUSB_QCA_WCN6855 |
+ BTUSB_WIDEBAND_SPEECH |
+ BTUSB_VALID_LE_STATES },
+ { USB_DEVICE(0x10ab, 0x9f09), .driver_info = BTUSB_QCA_WCN6855 |
+ BTUSB_WIDEBAND_SPEECH |
+ BTUSB_VALID_LE_STATES },
+ { USB_DEVICE(0x04ca, 0x3022), .driver_info = BTUSB_QCA_WCN6855 |
+ BTUSB_WIDEBAND_SPEECH |
+ BTUSB_VALID_LE_STATES },
+ { USB_DEVICE(0x0489, 0xe0c7), .driver_info = BTUSB_QCA_WCN6855 |
+ BTUSB_WIDEBAND_SPEECH |
+ BTUSB_VALID_LE_STATES },
+ { USB_DEVICE(0x0489, 0xe0c9), .driver_info = BTUSB_QCA_WCN6855 |
+ BTUSB_WIDEBAND_SPEECH |
+ BTUSB_VALID_LE_STATES },
+ { USB_DEVICE(0x0489, 0xe0ca), .driver_info = BTUSB_QCA_WCN6855 |
+ BTUSB_WIDEBAND_SPEECH |
+ BTUSB_VALID_LE_STATES },
+ { USB_DEVICE(0x0489, 0xe0cb), .driver_info = BTUSB_QCA_WCN6855 |
+ BTUSB_WIDEBAND_SPEECH |
+ BTUSB_VALID_LE_STATES },
+ { USB_DEVICE(0x0489, 0xe0ce), .driver_info = BTUSB_QCA_WCN6855 |
+ BTUSB_WIDEBAND_SPEECH |
+ BTUSB_VALID_LE_STATES },
+ { USB_DEVICE(0x0489, 0xe0de), .driver_info = BTUSB_QCA_WCN6855 |
+ BTUSB_WIDEBAND_SPEECH |
+ BTUSB_VALID_LE_STATES },
+ { USB_DEVICE(0x0489, 0xe0df), .driver_info = BTUSB_QCA_WCN6855 |
+ BTUSB_WIDEBAND_SPEECH |
+ BTUSB_VALID_LE_STATES },
+ { USB_DEVICE(0x0489, 0xe0e1), .driver_info = BTUSB_QCA_WCN6855 |
+ BTUSB_WIDEBAND_SPEECH |
+ BTUSB_VALID_LE_STATES },
+ { USB_DEVICE(0x0489, 0xe0ea), .driver_info = BTUSB_QCA_WCN6855 |
+ BTUSB_WIDEBAND_SPEECH |
+ BTUSB_VALID_LE_STATES },
+ { USB_DEVICE(0x0489, 0xe0ec), .driver_info = BTUSB_QCA_WCN6855 |
+ BTUSB_WIDEBAND_SPEECH |
+ BTUSB_VALID_LE_STATES },
+ { USB_DEVICE(0x04ca, 0x3023), .driver_info = BTUSB_QCA_WCN6855 |
+ BTUSB_WIDEBAND_SPEECH |
+ BTUSB_VALID_LE_STATES },
+ { USB_DEVICE(0x04ca, 0x3024), .driver_info = BTUSB_QCA_WCN6855 |
+ BTUSB_WIDEBAND_SPEECH |
+ BTUSB_VALID_LE_STATES },
+ { USB_DEVICE(0x04ca, 0x3a22), .driver_info = BTUSB_QCA_WCN6855 |
+ BTUSB_WIDEBAND_SPEECH |
+ BTUSB_VALID_LE_STATES },
+ { USB_DEVICE(0x04ca, 0x3a24), .driver_info = BTUSB_QCA_WCN6855 |
+ BTUSB_WIDEBAND_SPEECH |
+ BTUSB_VALID_LE_STATES },
+ { USB_DEVICE(0x04ca, 0x3a26), .driver_info = BTUSB_QCA_WCN6855 |
+ BTUSB_WIDEBAND_SPEECH |
+ BTUSB_VALID_LE_STATES },
+ { USB_DEVICE(0x04ca, 0x3a27), .driver_info = BTUSB_QCA_WCN6855 |
+ BTUSB_WIDEBAND_SPEECH |
+ BTUSB_VALID_LE_STATES },
/* QCA WCN785x chipset */
{ USB_DEVICE(0x0cf3, 0xe700), .driver_info = BTUSB_QCA_WCN6855 |
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] Bluetooth: btusb: Add more device IDs for WCN6855
2022-09-18 6:38 [PATCH] Bluetooth: btusb: Add more device IDs for WCN6855 Shengyu Qu
@ 2022-09-18 6:52 ` Paul Menzel
2022-09-18 7:13 ` Shengyu Qu
2022-09-18 7:15 ` bluez.test.bot
1 sibling, 1 reply; 5+ messages in thread
From: Paul Menzel @ 2022-09-18 6:52 UTC (permalink / raw)
To: Shengyu Qu; +Cc: linux-bluetooth
Dear Shengyu,
Thank you for the patch. Two nits below.
Am 18.09.22 um 08:38 schrieb Shengyu Qu:
> Add IDs to usb_device_id table for WCN6855.
> IDs are extracted from Windows driver of Lenovo
> Thinkpad T14 Gen 2.
Please reflow for 75 characters per line, and maybe don’t add a line
break, or add a blnak between paragraphs.
Please add the Microsoft Windows driver version, and maybe the location
(Internet Archive URL) for reference.
[…]
Kind regards,
Paul
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Bluetooth: btusb: Add more device IDs for WCN6855
2022-09-18 6:52 ` Paul Menzel
@ 2022-09-18 7:13 ` Shengyu Qu
2022-09-18 7:46 ` Paul Menzel
0 siblings, 1 reply; 5+ messages in thread
From: Shengyu Qu @ 2022-09-18 7:13 UTC (permalink / raw)
To: Paul Menzel; +Cc: linux-bluetooth@vger.kernel.org
Thanks for your advice. Driver version is 1.0.0.1205 (Windows 10 driver).
Should I resend a patch with modified commit message?
________________________________________
From: Paul Menzel <pmenzel@molgen.mpg.de>
Sent: Sunday, September 18, 2022 14:52
To: Shengyu Qu
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] Bluetooth: btusb: Add more device IDs for WCN6855
Dear Shengyu,
Thank you for the patch. Two nits below.
Am 18.09.22 um 08:38 schrieb Shengyu Qu:
> Add IDs to usb_device_id table for WCN6855.
> IDs are extracted from Windows driver of Lenovo
> Thinkpad T14 Gen 2.
Please reflow for 75 characters per line, and maybe don’t add a line
break, or add a blnak between paragraphs.
Please add the Microsoft Windows driver version, and maybe the location
(Internet Archive URL) for reference.
[…]
Kind regards,
Paul
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: Bluetooth: btusb: Add more device IDs for WCN6855
2022-09-18 6:38 [PATCH] Bluetooth: btusb: Add more device IDs for WCN6855 Shengyu Qu
2022-09-18 6:52 ` Paul Menzel
@ 2022-09-18 7:15 ` bluez.test.bot
1 sibling, 0 replies; 5+ messages in thread
From: bluez.test.bot @ 2022-09-18 7:15 UTC (permalink / raw)
To: linux-bluetooth, wiagn233
[-- Attachment #1: Type: text/plain, Size: 1150 bytes --]
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=677926
---Test result---
Test Summary:
CheckPatch PASS 1.34 seconds
GitLint PASS 0.47 seconds
SubjectPrefix PASS 0.24 seconds
BuildKernel PASS 33.65 seconds
BuildKernel32 PASS 29.63 seconds
Incremental Build with patchesPASS 45.92 seconds
TestRunner: Setup PASS 499.00 seconds
TestRunner: l2cap-tester PASS 16.49 seconds
TestRunner: iso-tester PASS 15.30 seconds
TestRunner: bnep-tester PASS 5.91 seconds
TestRunner: mgmt-tester PASS 99.59 seconds
TestRunner: rfcomm-tester PASS 9.83 seconds
TestRunner: sco-tester PASS 8.96 seconds
TestRunner: smp-tester PASS 9.22 seconds
TestRunner: userchan-tester PASS 6.19 seconds
---
Regards,
Linux Bluetooth
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Bluetooth: btusb: Add more device IDs for WCN6855
2022-09-18 7:13 ` Shengyu Qu
@ 2022-09-18 7:46 ` Paul Menzel
0 siblings, 0 replies; 5+ messages in thread
From: Paul Menzel @ 2022-09-18 7:46 UTC (permalink / raw)
To: Shengyu Qu; +Cc: linux-bluetooth
Dear Shengyu,
Am 18.09.22 um 09:13 schrieb Shengyu Qu:
> Thanks for your advice. Driver version is 1.0.0.1205 (Windows 10 driver).
> Should I resend a patch with modified commit message?
Yes, a v2 would be wonderful.
git commit --amend
git format-patch -v 2 …
Kind regards,
Paul
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-09-18 7:46 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-18 6:38 [PATCH] Bluetooth: btusb: Add more device IDs for WCN6855 Shengyu Qu
2022-09-18 6:52 ` Paul Menzel
2022-09-18 7:13 ` Shengyu Qu
2022-09-18 7:46 ` Paul Menzel
2022-09-18 7:15 ` bluez.test.bot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.