[PATCH BlueZ v2] obexd: point DBUS service to obex.service directly

[PATCH BlueZ v2] obexd: point DBUS service to obex.service directly

[André W]

dbus-org.bluez.obex.service user service is not available until
obex.service is enabled in systemd. By pointing DBUS service directly
to obex.service, this step can be avoided. The [Alias] section in
systemd services then becomes unnecessary.
---
 obexd/src/obex.service.in        | 3 ---
 obexd/src/org.bluez.obex.service | 2 +-
 2 files changed, 1 insertion(+), 4 deletions(-)

diff --git a/obexd/src/obex.service.in b/obexd/src/obex.service.in
index fc0dce993..c3f822f55 100644
--- a/obexd/src/obex.service.in
+++ b/obexd/src/obex.service.in
@@ -5,6 +5,3 @@ Description=Bluetooth OBEX service
 Type=dbus
 BusName=org.bluez.obex
 ExecStart=@pkglibexecdir@/obexd
-
-[Install]
-Alias=dbus-org.bluez.obex.service
diff --git a/obexd/src/org.bluez.obex.service b/obexd/src/org.bluez.obex.service
index a53808884..c3917e415 100644
--- a/obexd/src/org.bluez.obex.service
+++ b/obexd/src/org.bluez.obex.service
@@ -1,4 +1,4 @@
 [D-BUS Service]
 Name=org.bluez.obex
 Exec=/bin/false
-SystemdService=dbus-org.bluez.obex.service
+SystemdService=obex.service
-- 
2.37.3

RE: [BlueZ,v2] obexd: point DBUS service to obex.service directly

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 1047 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=680278

---Test result---

Test Summary:
CheckPatch                    PASS      1.35 seconds
GitLint                       PASS      0.95 seconds
Prep - Setup ELL              PASS      26.07 seconds
Build - Prep                  PASS      0.80 seconds
Build - Configure             PASS      8.22 seconds
Build - Make                  PASS      725.54 seconds
Make Check                    PASS      11.76 seconds
Make Check w/Valgrind         PASS      286.43 seconds
Make Distcheck                PASS      235.99 seconds
Build w/ext ELL - Configure   PASS      8.30 seconds
Build w/ext ELL - Make        PASS      83.10 seconds
Incremental Build w/ patches  PASS      0.00 seconds
Scan Build                    PASS      463.62 seconds



---
Regards,
Linux Bluetooth

Re: [PATCH BlueZ v2] obexd: point DBUS service to obex.service directly

[Luiz Augusto von Dentz]

Hi André,

On Sun, Sep 25, 2022 at 12:08 PM André W <beppe85@gmail.com> wrote:
>
> dbus-org.bluez.obex.service user service is not available until
> obex.service is enabled in systemd. By pointing DBUS service directly
> to obex.service, this step can be avoided. The [Alias] section in
> systemd services then becomes unnecessary.

Can we have some more details here, perhaps quote the systemd
documentation if it states why the Alias is not necessary, also does
this affect how the service is activated? Afaik the dbus- suffix was
used to inform that this service starts a D-Bus name.

> ---
>  obexd/src/obex.service.in        | 3 ---
>  obexd/src/org.bluez.obex.service | 2 +-
>  2 files changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/obexd/src/obex.service.in b/obexd/src/obex.service.in
> index fc0dce993..c3f822f55 100644
> --- a/obexd/src/obex.service.in
> +++ b/obexd/src/obex.service.in
> @@ -5,6 +5,3 @@ Description=Bluetooth OBEX service
>  Type=dbus
>  BusName=org.bluez.obex
>  ExecStart=@pkglibexecdir@/obexd
> -
> -[Install]
> -Alias=dbus-org.bluez.obex.service
> diff --git a/obexd/src/org.bluez.obex.service b/obexd/src/org.bluez.obex.service
> index a53808884..c3917e415 100644
> --- a/obexd/src/org.bluez.obex.service
> +++ b/obexd/src/org.bluez.obex.service
> @@ -1,4 +1,4 @@
>  [D-BUS Service]
>  Name=org.bluez.obex
>  Exec=/bin/false
> -SystemdService=dbus-org.bluez.obex.service
> +SystemdService=obex.service
> --
> 2.37.3



-- 
Luiz Augusto von Dentz