From: Alexander Stein <alexander.stein-93q1YBGzJSMe9JSWTWOYM3xStJ4P+DSV@public.gmane.org>
To: Tomoya MORINAGA <tomoya.rohm-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>,
Ben Dooks <ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org>,
Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
Tomoya MORINAGA
<tomoya-linux-8lRStDepK8iSL1NxhRU65dBPR1lH4CV8@public.gmane.org>,
Feng Tang <feng.tang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Toshiharu Okada
<toshiharu-linux-ECg8zkTtlr0C6LszWs/t0g@public.gmane.org>,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] i2c-eg20t: Rework pch_i2c_wait_for_bus_idle to reduce wait time
Date: Mon, 13 Feb 2012 08:25 +0100 [thread overview]
Message-ID: <63318173.mcCRrit7Mu@ws-stein> (raw)
In-Reply-To: <CANKRQniXxZbY5Bs90v+xsU3PRU6JntXF53Vv0Yhx0Lyhn3fq6g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
Am Freitag, 10. Februar 2012, 09:52:03 schrieb Tomoya MORINAGA:
> 2012/2/9 Alexander Stein <alexander.stein-93q1YBGzJSMe9JSWTWOYM3xStJ4P+DSV@public.gmane.org> wrote:
> >
> > if ((ioread32(p + PCH_I2CSR) & I2CMBB_BIT) == 0)
> > return 0;
> >
>
> If this patch will be accepted,
> this code also looks redundant code.
Yep, you're right. I'll prepare a now patch after some days of possibly more comments.
Best regards,
Alexander
--
Dipl.-Inf. Alexander Stein
SYS TEC electronic GmbH
August-Bebel-Str. 29
D-07973 Greiz
Tel: +49-3661-6279-0, Fax: +49-3661-6279-99
eMail: Alexander.Stein-93q1YBGzJSMe9JSWTWOYM3xStJ4P+DSV@public.gmane.org
Internet: http://www.systec-electronic.com
Managing Director: Dipl.-Phys. Siegmar Schmidt
Commercial registry: Amtsgericht Jena, HRB 205563
WARNING: multiple messages have this Message-ID (diff)
From: Alexander Stein <alexander.stein@systec-electronic.com>
To: Tomoya MORINAGA <tomoya.rohm@gmail.com>
Cc: Jean Delvare <khali@linux-fr.org>,
Ben Dooks <ben-linux@fluff.org>,
Wolfram Sang <w.sang@pengutronix.de>,
Tomoya MORINAGA <tomoya-linux@dsn.lapis-semi.com>,
Feng Tang <feng.tang@intel.com>,
Toshiharu Okada <toshiharu-linux@dsn.okisemi.com>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i2c-eg20t: Rework pch_i2c_wait_for_bus_idle to reduce wait time
Date: Mon, 13 Feb 2012 08:25 +0100 [thread overview]
Message-ID: <63318173.mcCRrit7Mu@ws-stein> (raw)
In-Reply-To: <CANKRQniXxZbY5Bs90v+xsU3PRU6JntXF53Vv0Yhx0Lyhn3fq6g@mail.gmail.com>
Am Freitag, 10. Februar 2012, 09:52:03 schrieb Tomoya MORINAGA:
> 2012/2/9 Alexander Stein <alexander.stein@systec-electronic.com> wrote:
> >
> > if ((ioread32(p + PCH_I2CSR) & I2CMBB_BIT) == 0)
> > return 0;
> >
>
> If this patch will be accepted,
> this code also looks redundant code.
Yep, you're right. I'll prepare a now patch after some days of possibly more comments.
Best regards,
Alexander
--
Dipl.-Inf. Alexander Stein
SYS TEC electronic GmbH
August-Bebel-Str. 29
D-07973 Greiz
Tel: +49-3661-6279-0, Fax: +49-3661-6279-99
eMail: Alexander.Stein@systec-electronic.com
Internet: http://www.systec-electronic.com
Managing Director: Dipl.-Phys. Siegmar Schmidt
Commercial registry: Amtsgericht Jena, HRB 205563
next prev parent reply other threads:[~2012-02-13 7:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-09 8:32 [PATCH] i2c-eg20t: Rework pch_i2c_wait_for_bus_idle to reduce wait time Alexander Stein
2012-02-09 8:32 ` Alexander Stein
[not found] ` <1328776366-6881-1-git-send-email-alexander.stein-93q1YBGzJSMe9JSWTWOYM3xStJ4P+DSV@public.gmane.org>
2012-02-10 0:52 ` Tomoya MORINAGA
2012-02-10 0:52 ` Tomoya MORINAGA
[not found] ` <CANKRQniXxZbY5Bs90v+xsU3PRU6JntXF53Vv0Yhx0Lyhn3fq6g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-02-13 7:25 ` Alexander Stein [this message]
2012-02-13 7:25 ` Alexander Stein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63318173.mcCRrit7Mu@ws-stein \
--to=alexander.stein-93q1ybgzjsme9jswtwoym3xstj4p+dsv@public.gmane.org \
--cc=ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org \
--cc=feng.tang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=tomoya-linux-8lRStDepK8iSL1NxhRU65dBPR1lH4CV8@public.gmane.org \
--cc=tomoya.rohm-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=toshiharu-linux-ECg8zkTtlr0C6LszWs/t0g@public.gmane.org \
--cc=w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.