From: Casey Schaufler <casey@schaufler-ca.com>
To: Eric Paris <eparis@redhat.com>,
selinux@tycho.nsa.gov, nfs@lists.sourceforge.net
Cc: sds@tycho.nsa.gov, jmorris@namei.org, steved@redhat.com,
trond.myklebust@fys.uio.no
Subject: Re: [PATCH] 1/2 SELinux: Add get, set, and cloning of superblock security information
Date: Thu, 6 Sep 2007 08:59:03 -0700 (PDT) [thread overview]
Message-ID: <636439.78887.qm@web36607.mail.mud.yahoo.com> (raw)
In-Reply-To: <1189030563.3460.41.camel-8EcGF3LoIEk5T7vyJU6V4x/sF2h8X+2i0E9HWUfgJXw@public.gmane.org>
--- Eric Paris <eparis@redhat.com> wrote:
> Adds security_get_sb_mnt_opts, security_set_sb_mnt_opts, and
> security_clont_sb_mnt_opts to the LSM and to SELinux. This is in
> preparation for NFS to be able to own its own mount options and remove
> the NFS specific code from SELinux.
What is the purpose of security_clone_sb_mnt_opts? I see where it is
being used, but it's not clear to me why it is necessary. The old SELinux
code doesn't clone the options, it filters out the ones it cares about.
If that is the behavior you'd expect of this hook, I suggest the name
reflect that, perhaps security_filter_sb_mnt_opts.
Casey Schaufler
casey@schaufler-ca.com
WARNING: multiple messages have this Message-ID (diff)
From: Casey Schaufler <casey@schaufler-ca.com>
To: Eric Paris <eparis@redhat.com>,
selinux@tycho.nsa.gov, nfs@lists.sourceforge.net
Cc: sds@tycho.nsa.gov, jmorris@namei.org, steved@redhat.com,
trond.myklebust@fys.uio.no
Subject: Re: [PATCH] 1/2 SELinux: Add get, set, and cloning of superblock security information
Date: Thu, 6 Sep 2007 08:59:03 -0700 (PDT) [thread overview]
Message-ID: <636439.78887.qm@web36607.mail.mud.yahoo.com> (raw)
In-Reply-To: <1189030563.3460.41.camel@dhcp231-215.rdu.redhat.com>
--- Eric Paris <eparis@redhat.com> wrote:
> Adds security_get_sb_mnt_opts, security_set_sb_mnt_opts, and
> security_clont_sb_mnt_opts to the LSM and to SELinux. This is in
> preparation for NFS to be able to own its own mount options and remove
> the NFS specific code from SELinux.
What is the purpose of security_clone_sb_mnt_opts? I see where it is
being used, but it's not clear to me why it is necessary. The old SELinux
code doesn't clone the options, it filters out the ones it cares about.
If that is the behavior you'd expect of this hook, I suggest the name
reflect that, perhaps security_filter_sb_mnt_opts.
Casey Schaufler
casey@schaufler-ca.com
--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.
next prev parent reply other threads:[~2007-09-06 15:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-05 22:16 [PATCH] 1/2 SELinux: Add get, set, and cloning of superblock security information Eric Paris
2007-09-05 22:16 ` Eric Paris
[not found] ` <1189030563.3460.41.camel-8EcGF3LoIEk5T7vyJU6V4x/sF2h8X+2i0E9HWUfgJXw@public.gmane.org>
2007-09-06 15:59 ` Casey Schaufler [this message]
2007-09-06 15:59 ` Casey Schaufler
2007-09-06 16:15 ` Eric Paris
2007-09-06 16:15 ` Eric Paris
[not found] ` <1189095312.3418.9.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2007-09-06 16:28 ` Casey Schaufler
2007-09-06 16:28 ` Casey Schaufler
2007-09-06 16:34 ` Eric Paris
2007-09-06 16:34 ` Eric Paris
2007-09-06 18:33 ` Stephen Smalley
2007-09-06 18:33 ` Stephen Smalley
2007-09-06 19:21 ` Eric Paris
2007-09-06 19:21 ` Eric Paris
2007-09-06 19:59 ` Stephen Smalley
2007-09-06 19:59 ` Stephen Smalley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=636439.78887.qm@web36607.mail.mud.yahoo.com \
--to=casey@schaufler-ca.com \
--cc=eparis@redhat.com \
--cc=jmorris@namei.org \
--cc=nfs@lists.sourceforge.net \
--cc=sds@tycho.nsa.gov \
--cc=selinux@tycho.nsa.gov \
--cc=steved@redhat.com \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.