From: garsilva@embeddedor.com (Gustavo A. R. Silva)
To: cocci@systeme.lip6.fr
Subject: [Cocci] [PATCH] EDAC: remove unnecessary static in edac_fake_inject_write()
Date: Sat, 22 Jul 2017 11:22:13 -0500 [thread overview]
Message-ID: <638a94de-5eb4-eba4-7c28-4b4eb4bf8dbf@embeddedor.com> (raw)
In-Reply-To: <20170722063602.GB2050@nazgul.tnic>
Hi all,
On 07/22/2017 01:36 AM, Borislav Petkov wrote:
> On Fri, Jul 21, 2017 at 10:08:12PM +0200, Julia Lawall wrote:
>> Someone pointed out that the rule is probably not OK when the address of
>> the static variable is taken, because then it is likely being used as
>> permanent storage.
>
> Makes sense to me.
>
>> An improved rule is:
>
> Do you think it is worth having it in scripts/coccinelle/ ?
>
> I don't think Gustavo would mind putting it there :)
>
Absolutely, I'd be glad to help out. :)
--
Gustavo A. R. Silva
WARNING: multiple messages have this Message-ID (diff)
From: "Gustavo A. R. Silva" <garsilva@embeddedor.com>
To: Borislav Petkov <bp@alien8.de>, Julia Lawall <julia.lawall@lip6.fr>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org,
cocci@systeme.lip6.fr
Subject: EDAC: remove unnecessary static in edac_fake_inject_write()
Date: Sat, 22 Jul 2017 11:22:13 -0500 [thread overview]
Message-ID: <638a94de-5eb4-eba4-7c28-4b4eb4bf8dbf@embeddedor.com> (raw)
Hi all,
On 07/22/2017 01:36 AM, Borislav Petkov wrote:
> On Fri, Jul 21, 2017 at 10:08:12PM +0200, Julia Lawall wrote:
>> Someone pointed out that the rule is probably not OK when the address of
>> the static variable is taken, because then it is likely being used as
>> permanent storage.
>
> Makes sense to me.
>
>> An improved rule is:
>
> Do you think it is worth having it in scripts/coccinelle/ ?
>
> I don't think Gustavo would mind putting it there :)
>
Absolutely, I'd be glad to help out. :)
WARNING: multiple messages have this Message-ID (diff)
From: "Gustavo A. R. Silva" <garsilva@embeddedor.com>
To: Borislav Petkov <bp@alien8.de>, Julia Lawall <julia.lawall@lip6.fr>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org,
cocci@systeme.lip6.fr
Subject: Re: [PATCH] EDAC: remove unnecessary static in edac_fake_inject_write()
Date: Sat, 22 Jul 2017 11:22:13 -0500 [thread overview]
Message-ID: <638a94de-5eb4-eba4-7c28-4b4eb4bf8dbf@embeddedor.com> (raw)
In-Reply-To: <20170722063602.GB2050@nazgul.tnic>
Hi all,
On 07/22/2017 01:36 AM, Borislav Petkov wrote:
> On Fri, Jul 21, 2017 at 10:08:12PM +0200, Julia Lawall wrote:
>> Someone pointed out that the rule is probably not OK when the address of
>> the static variable is taken, because then it is likely being used as
>> permanent storage.
>
> Makes sense to me.
>
>> An improved rule is:
>
> Do you think it is worth having it in scripts/coccinelle/ ?
>
> I don't think Gustavo would mind putting it there :)
>
Absolutely, I'd be glad to help out. :)
--
Gustavo A. R. Silva
next prev parent reply other threads:[~2017-07-22 16:22 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-04 21:44 EDAC: remove unnecessary static in edac_fake_inject_write() Gustavo A. R. Silva
2017-07-04 21:44 ` [PATCH] " Gustavo A. R. Silva
2017-07-17 8:39 ` [Cocci] " Borislav Petkov
2017-07-17 8:39 ` Borislav Petkov
2017-07-17 8:39 ` Borislav Petkov
2017-07-21 20:08 ` [Cocci] [PATCH] " Julia Lawall
2017-07-21 20:08 ` Julia Lawall
2017-07-21 20:08 ` Julia Lawall
2017-07-22 6:36 ` [Cocci] [PATCH] " Borislav Petkov
2017-07-22 6:36 ` Borislav Petkov
2017-07-22 6:36 ` Borislav Petkov
2017-07-22 6:39 ` [Cocci] [PATCH] " Julia Lawall
2017-07-22 6:39 ` Julia Lawall
2017-07-22 6:39 ` Julia Lawall
2017-07-22 16:22 ` Gustavo A. R. Silva [this message]
2017-07-22 16:22 ` [PATCH] " Gustavo A. R. Silva
2017-07-22 16:22 ` Gustavo A. R. Silva
2017-07-23 2:31 ` [Cocci] [PATCH] " Gustavo A. R. Silva
2017-07-23 2:31 ` Gustavo A. R. Silva
2017-07-23 2:31 ` Gustavo A. R. Silva
2017-07-23 5:07 ` [Cocci] [PATCH] " Julia Lawall
2017-07-23 5:07 ` Julia Lawall
2017-07-23 5:07 ` Julia Lawall
2017-07-23 5:42 ` [Cocci] [PATCH] " Gustavo A. R. Silva
2017-07-23 5:42 ` Gustavo A. R. Silva
2017-07-23 5:42 ` Gustavo A. R. Silva
2017-07-23 5:53 ` [Cocci] [PATCH] " Julia Lawall
2017-07-23 5:53 ` Julia Lawall
2017-07-23 5:53 ` Julia Lawall
2017-07-23 6:25 ` [Cocci] [PATCH] " Gustavo A. R. Silva
2017-07-23 6:25 ` Gustavo A. R. Silva
2017-07-23 6:25 ` Gustavo A. R. Silva
2017-07-24 10:34 ` [Cocci] [PATCH] " Borislav Petkov
2017-07-24 10:34 ` Borislav Petkov
2017-07-24 10:34 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=638a94de-5eb4-eba4-7c28-4b4eb4bf8dbf@embeddedor.com \
--to=garsilva@embeddedor.com \
--cc=cocci@systeme.lip6.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.