* [PATCH v2 1/6] Bluetooth: hci_qca: don't call kfree_skb() under spin_lock_irqsave()
2022-12-07 2:18 [PATCH v2 0/6] Bluetooth: don't call kfree_skb() under spin_lock_irqsave() Yang Yingliang
@ 2022-12-07 2:18 ` Yang Yingliang
2022-12-07 2:41 ` Bluetooth: " bluez.test.bot
2022-12-07 2:18 ` [PATCH v2 2/6] Bluetooth: hci_ll: " Yang Yingliang
` (5 subsequent siblings)
6 siblings, 1 reply; 10+ messages in thread
From: Yang Yingliang @ 2022-12-07 2:18 UTC (permalink / raw)
To: marcel, johan.hedberg, luiz.dentz; +Cc: linux-bluetooth, yangyingliang
It is not allowed to call kfree_skb() from hardware interrupt
context or with interrupts being disabled. So replace kfree_skb()
with dev_kfree_skb_irq() under spin_lock_irqsave().
Fixes: 0ff252c1976d ("Bluetooth: hciuart: Add support QCA chipset for UART")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
drivers/bluetooth/hci_qca.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c
index 8df11016fd51..bae9b2a408d9 100644
--- a/drivers/bluetooth/hci_qca.c
+++ b/drivers/bluetooth/hci_qca.c
@@ -912,7 +912,7 @@ static int qca_enqueue(struct hci_uart *hu, struct sk_buff *skb)
default:
BT_ERR("Illegal tx state: %d (losing packet)",
qca->tx_ibs_state);
- kfree_skb(skb);
+ dev_kfree_skb_irq(skb);
break;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* RE: Bluetooth: don't call kfree_skb() under spin_lock_irqsave()
2022-12-07 2:18 ` [PATCH v2 1/6] Bluetooth: hci_qca: " Yang Yingliang
@ 2022-12-07 2:41 ` bluez.test.bot
0 siblings, 0 replies; 10+ messages in thread
From: bluez.test.bot @ 2022-12-07 2:41 UTC (permalink / raw)
To: linux-bluetooth, yangyingliang
[-- Attachment #1: Type: text/plain, Size: 1257 bytes --]
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=702385
---Test result---
Test Summary:
CheckPatch PASS 3.86 seconds
GitLint PASS 2.04 seconds
SubjectPrefix PASS 0.73 seconds
BuildKernel PASS 33.83 seconds
BuildKernel32 PASS 29.74 seconds
TestRunnerSetup PASS 419.28 seconds
TestRunner_l2cap-tester PASS 15.69 seconds
TestRunner_iso-tester PASS 15.34 seconds
TestRunner_bnep-tester PASS 5.32 seconds
TestRunner_mgmt-tester PASS 103.24 seconds
TestRunner_rfcomm-tester PASS 9.19 seconds
TestRunner_sco-tester PASS 8.62 seconds
TestRunner_ioctl-tester PASS 9.78 seconds
TestRunner_mesh-tester PASS 6.68 seconds
TestRunner_smp-tester PASS 8.49 seconds
TestRunner_userchan-tester PASS 5.56 seconds
IncrementalBuild PASS 59.18 seconds
---
Regards,
Linux Bluetooth
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v2 2/6] Bluetooth: hci_ll: don't call kfree_skb() under spin_lock_irqsave()
2022-12-07 2:18 [PATCH v2 0/6] Bluetooth: don't call kfree_skb() under spin_lock_irqsave() Yang Yingliang
2022-12-07 2:18 ` [PATCH v2 1/6] Bluetooth: hci_qca: " Yang Yingliang
@ 2022-12-07 2:18 ` Yang Yingliang
2022-12-07 2:18 ` [PATCH v2 3/6] Bluetooth: hci_h5: " Yang Yingliang
` (4 subsequent siblings)
6 siblings, 0 replies; 10+ messages in thread
From: Yang Yingliang @ 2022-12-07 2:18 UTC (permalink / raw)
To: marcel, johan.hedberg, luiz.dentz; +Cc: linux-bluetooth, yangyingliang
It is not allowed to call kfree_skb() from hardware interrupt
context or with interrupts being disabled. So replace kfree_skb()
with dev_kfree_skb_irq() under spin_lock_irqsave().
Fixes: 166d2f6a4332 ("[Bluetooth] Add UART driver for Texas Instruments' BRF63xx chips")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
drivers/bluetooth/hci_ll.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/bluetooth/hci_ll.c b/drivers/bluetooth/hci_ll.c
index 4eb420a9ed04..5abc01a2acf7 100644
--- a/drivers/bluetooth/hci_ll.c
+++ b/drivers/bluetooth/hci_ll.c
@@ -345,7 +345,7 @@ static int ll_enqueue(struct hci_uart *hu, struct sk_buff *skb)
default:
BT_ERR("illegal hcill state: %ld (losing packet)",
ll->hcill_state);
- kfree_skb(skb);
+ dev_kfree_skb_irq(skb);
break;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH v2 3/6] Bluetooth: hci_h5: don't call kfree_skb() under spin_lock_irqsave()
2022-12-07 2:18 [PATCH v2 0/6] Bluetooth: don't call kfree_skb() under spin_lock_irqsave() Yang Yingliang
2022-12-07 2:18 ` [PATCH v2 1/6] Bluetooth: hci_qca: " Yang Yingliang
2022-12-07 2:18 ` [PATCH v2 2/6] Bluetooth: hci_ll: " Yang Yingliang
@ 2022-12-07 2:18 ` Yang Yingliang
2022-12-07 2:18 ` [PATCH v2 4/6] Bluetooth: hci_bcsp: " Yang Yingliang
` (3 subsequent siblings)
6 siblings, 0 replies; 10+ messages in thread
From: Yang Yingliang @ 2022-12-07 2:18 UTC (permalink / raw)
To: marcel, johan.hedberg, luiz.dentz; +Cc: linux-bluetooth, yangyingliang
It is not allowed to call kfree_skb() from hardware interrupt
context or with interrupts being disabled. So replace kfree_skb()
with dev_kfree_skb_irq() under spin_lock_irqsave().
Fixes: 43eb12d78960 ("Bluetooth: Fix/implement Three-wire reliable packet sending")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
drivers/bluetooth/hci_h5.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/bluetooth/hci_h5.c b/drivers/bluetooth/hci_h5.c
index c5a0409ef84f..6455bc4fb5bb 100644
--- a/drivers/bluetooth/hci_h5.c
+++ b/drivers/bluetooth/hci_h5.c
@@ -313,7 +313,7 @@ static void h5_pkt_cull(struct h5 *h5)
break;
__skb_unlink(skb, &h5->unack);
- kfree_skb(skb);
+ dev_kfree_skb_irq(skb);
}
if (skb_queue_empty(&h5->unack))
--
2.25.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH v2 4/6] Bluetooth: hci_bcsp: don't call kfree_skb() under spin_lock_irqsave()
2022-12-07 2:18 [PATCH v2 0/6] Bluetooth: don't call kfree_skb() under spin_lock_irqsave() Yang Yingliang
` (2 preceding siblings ...)
2022-12-07 2:18 ` [PATCH v2 3/6] Bluetooth: hci_h5: " Yang Yingliang
@ 2022-12-07 2:18 ` Yang Yingliang
2022-12-07 2:18 ` [PATCH v2 5/6] Bluetooth: hci_core: " Yang Yingliang
` (2 subsequent siblings)
6 siblings, 0 replies; 10+ messages in thread
From: Yang Yingliang @ 2022-12-07 2:18 UTC (permalink / raw)
To: marcel, johan.hedberg, luiz.dentz; +Cc: linux-bluetooth, yangyingliang
It is not allowed to call kfree_skb() from hardware interrupt
context or with interrupts being disabled. So replace kfree_skb()
with dev_kfree_skb_irq() under spin_lock_irqsave().
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
drivers/bluetooth/hci_bcsp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/bluetooth/hci_bcsp.c b/drivers/bluetooth/hci_bcsp.c
index cf4a56095817..8055f63603f4 100644
--- a/drivers/bluetooth/hci_bcsp.c
+++ b/drivers/bluetooth/hci_bcsp.c
@@ -378,7 +378,7 @@ static void bcsp_pkt_cull(struct bcsp_struct *bcsp)
i++;
__skb_unlink(skb, &bcsp->unack);
- kfree_skb(skb);
+ dev_kfree_skb_irq(skb);
}
if (skb_queue_empty(&bcsp->unack))
--
2.25.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH v2 5/6] Bluetooth: hci_core: don't call kfree_skb() under spin_lock_irqsave()
2022-12-07 2:18 [PATCH v2 0/6] Bluetooth: don't call kfree_skb() under spin_lock_irqsave() Yang Yingliang
` (3 preceding siblings ...)
2022-12-07 2:18 ` [PATCH v2 4/6] Bluetooth: hci_bcsp: " Yang Yingliang
@ 2022-12-07 2:18 ` Yang Yingliang
2022-12-07 2:18 ` [PATCH v2 6/6] Bluetooth: RFCOMM: " Yang Yingliang
2022-12-07 21:20 ` [PATCH v2 0/6] Bluetooth: " patchwork-bot+bluetooth
6 siblings, 0 replies; 10+ messages in thread
From: Yang Yingliang @ 2022-12-07 2:18 UTC (permalink / raw)
To: marcel, johan.hedberg, luiz.dentz; +Cc: linux-bluetooth, yangyingliang
It is not allowed to call kfree_skb() from hardware interrupt
context or with interrupts being disabled. So replace kfree_skb()
with dev_kfree_skb_irq() under spin_lock_irqsave().
Fixes: 9238f36a5a50 ("Bluetooth: Add request cmd_complete and cmd_status functions")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
net/bluetooth/hci_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/bluetooth/hci_core.c b/net/bluetooth/hci_core.c
index 9d9fb3dff22a..03b2a85cbc80 100644
--- a/net/bluetooth/hci_core.c
+++ b/net/bluetooth/hci_core.c
@@ -3981,7 +3981,7 @@ void hci_req_cmd_complete(struct hci_dev *hdev, u16 opcode, u8 status,
*req_complete_skb = bt_cb(skb)->hci.req_complete_skb;
else
*req_complete = bt_cb(skb)->hci.req_complete;
- kfree_skb(skb);
+ dev_kfree_skb_irq(skb);
}
spin_unlock_irqrestore(&hdev->cmd_q.lock, flags);
}
--
2.25.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH v2 6/6] Bluetooth: RFCOMM: don't call kfree_skb() under spin_lock_irqsave()
2022-12-07 2:18 [PATCH v2 0/6] Bluetooth: don't call kfree_skb() under spin_lock_irqsave() Yang Yingliang
` (4 preceding siblings ...)
2022-12-07 2:18 ` [PATCH v2 5/6] Bluetooth: hci_core: " Yang Yingliang
@ 2022-12-07 2:18 ` Yang Yingliang
2022-12-07 21:20 ` [PATCH v2 0/6] Bluetooth: " patchwork-bot+bluetooth
6 siblings, 0 replies; 10+ messages in thread
From: Yang Yingliang @ 2022-12-07 2:18 UTC (permalink / raw)
To: marcel, johan.hedberg, luiz.dentz; +Cc: linux-bluetooth, yangyingliang
It is not allowed to call kfree_skb() from hardware interrupt
context or with interrupts being disabled. So replace kfree_skb()
with dev_kfree_skb_irq() under spin_lock_irqsave().
Fixes: 81be03e026dc ("Bluetooth: RFCOMM: Replace use of memcpy_from_msg with bt_skb_sendmmsg")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
net/bluetooth/rfcomm/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/bluetooth/rfcomm/core.c b/net/bluetooth/rfcomm/core.c
index 7324764384b6..8d6fce9005bd 100644
--- a/net/bluetooth/rfcomm/core.c
+++ b/net/bluetooth/rfcomm/core.c
@@ -590,7 +590,7 @@ int rfcomm_dlc_send(struct rfcomm_dlc *d, struct sk_buff *skb)
ret = rfcomm_dlc_send_frag(d, frag);
if (ret < 0) {
- kfree_skb(frag);
+ dev_kfree_skb_irq(frag);
goto unlock;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH v2 0/6] Bluetooth: don't call kfree_skb() under spin_lock_irqsave()
2022-12-07 2:18 [PATCH v2 0/6] Bluetooth: don't call kfree_skb() under spin_lock_irqsave() Yang Yingliang
` (5 preceding siblings ...)
2022-12-07 2:18 ` [PATCH v2 6/6] Bluetooth: RFCOMM: " Yang Yingliang
@ 2022-12-07 21:20 ` patchwork-bot+bluetooth
6 siblings, 0 replies; 10+ messages in thread
From: patchwork-bot+bluetooth @ 2022-12-07 21:20 UTC (permalink / raw)
To: Yang Yingliang; +Cc: marcel, johan.hedberg, luiz.dentz, linux-bluetooth
Hello:
This series was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:
On Wed, 7 Dec 2022 10:18:29 +0800 you wrote:
> It is not allowed to call kfree_skb() from hardware interrupt
> context or with interrupts being disabled. This patchset is
> replace kfree_skb() with dev_kfree_skb_irq() under
> spin_lock_irqsave().
>
> v1 -> v2:
> Replace kfree_skb() with dev_kfree_skb_irq().
>
> [...]
Here is the summary with links:
- [v2,1/6] Bluetooth: hci_qca: don't call kfree_skb() under spin_lock_irqsave()
https://git.kernel.org/bluetooth/bluetooth-next/c/53a3dd1fe59f
- [v2,2/6] Bluetooth: hci_ll: don't call kfree_skb() under spin_lock_irqsave()
https://git.kernel.org/bluetooth/bluetooth-next/c/1813c380e222
- [v2,3/6] Bluetooth: hci_h5: don't call kfree_skb() under spin_lock_irqsave()
https://git.kernel.org/bluetooth/bluetooth-next/c/a1e7f617bc0d
- [v2,4/6] Bluetooth: hci_bcsp: don't call kfree_skb() under spin_lock_irqsave()
https://git.kernel.org/bluetooth/bluetooth-next/c/0935d021bde3
- [v2,5/6] Bluetooth: hci_core: don't call kfree_skb() under spin_lock_irqsave()
https://git.kernel.org/bluetooth/bluetooth-next/c/a3381581499f
- [v2,6/6] Bluetooth: RFCOMM: don't call kfree_skb() under spin_lock_irqsave()
https://git.kernel.org/bluetooth/bluetooth-next/c/894e4bc8d807
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 10+ messages in thread